)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1cec5574ed973558325d7caed3172e8964d068ba","unresolved":false,"context_lines":[{"line_number":10,"context_line":"The following changes are part of this patch:"},{"line_number":11,"context_line":"1) location URL format: previously cinder://\u003cvolume-id\u003e, the format is"},{"line_number":12,"context_line":"now changed to cinder://\u003cstore-name\u003e/\u003cvolume-id\u003e"},{"line_number":13,"context_line":"2) Check for configured volume types: During initialization of service,"},{"line_number":14,"context_line":"all volume types configured in the cinder store(s) will be checked if"},{"line_number":15,"context_line":"they exist in deployment or not, the store with the wrong type will be"},{"line_number":16,"context_line":"disabled."},{"line_number":17,"context_line":"3) Update legacy images: This change is partially depedent on the glance"},{"line_number":18,"context_line":"changes[1] which trigger updating the URL for legacy images and the"},{"line_number":19,"context_line":"cinder store checks the configured stores volume type against the existing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_1ed064f7","line":16,"range":{"start_line":13,"start_character":3,"end_line":16,"end_character":9},"updated":"2020-08-17 16:44:21.000000000","message":"Also mention, in order to retain backward compatibility, if cinder store is configured using traditional/old way (i.e. using \u0027stores\u0027 config option) then this validation will not be performed.","commit_id":"105c703cf1ba9f0226bde4b039e441e210e2cefc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5d03325a574c77b928b85bb0ea91c89038e9c248","unresolved":false,"context_lines":[{"line_number":10,"context_line":"The following changes are part of this patch:"},{"line_number":11,"context_line":"1) location URL format: previously cinder://\u003cvolume-id\u003e, the format is"},{"line_number":12,"context_line":"now changed to cinder://\u003cstore-name\u003e/\u003cvolume-id\u003e"},{"line_number":13,"context_line":"2) Check for configured volume types: During initialization of service,"},{"line_number":14,"context_line":"all volume types configured in the cinder store(s) will be checked if"},{"line_number":15,"context_line":"they exist in deployment or not, the store with the wrong type will be"},{"line_number":16,"context_line":"disabled."},{"line_number":17,"context_line":"3) Update legacy images: This change is partially depedent on the glance"},{"line_number":18,"context_line":"changes[1] which trigger updating the URL for legacy images and the"},{"line_number":19,"context_line":"cinder store checks the configured stores volume type against the existing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_0a980719","line":16,"range":{"start_line":13,"start_character":3,"end_line":16,"end_character":9},"in_reply_to":"9f560f44_1ed064f7","updated":"2020-08-19 01:30:53.000000000","message":"Done","commit_id":"105c703cf1ba9f0226bde4b039e441e210e2cefc"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1cec5574ed973558325d7caed3172e8964d068ba","unresolved":false,"context_lines":[{"line_number":20,"context_line":"image-volume\u0027s type and update it respectively."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://review.opendev.org/#/c/742373/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I0ba36d1095886fd1d96926af37a3a65a178c004f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_e156b506","line":23,"updated":"2020-08-17 16:44:21.000000000","message":"I guess you also need to refer here\n\nImplements: blueprint multiple-cinder-backend-support","commit_id":"105c703cf1ba9f0226bde4b039e441e210e2cefc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5d03325a574c77b928b85bb0ea91c89038e9c248","unresolved":false,"context_lines":[{"line_number":20,"context_line":"image-volume\u0027s type and update it respectively."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://review.opendev.org/#/c/742373/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I0ba36d1095886fd1d96926af37a3a65a178c004f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_6a9f0303","line":23,"in_reply_to":"9f560f44_e156b506","updated":"2020-08-19 01:30:53.000000000","message":"Done","commit_id":"105c703cf1ba9f0226bde4b039e441e210e2cefc"}],"glance_store/_drivers/cinder.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1cec5574ed973558325d7caed3172e8964d068ba","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        Configure the Store to use the stored configuration options"},{"line_number":409,"context_line":"        Any store that needs special configuration should implement"},{"line_number":410,"context_line":"        this method. If the store was not able to successfully configure"},{"line_number":411,"context_line":"        itself, it should raise `exceptions.BadStoreConfiguration`"},{"line_number":412,"context_line":"        \"\"\""},{"line_number":413,"context_line":"        if self.backend_group:"},{"line_number":414,"context_line":"            cinder_volume_type \u003d self.store_conf.cinder_volume_type"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5e481ccb","line":411,"range":{"start_line":411,"start_character":16,"end_line":411,"end_character":66},"updated":"2020-08-17 16:44:21.000000000","message":"This method raises two different exceptions for two different cases. It should be better to mention those two different cases as well.","commit_id":"105c703cf1ba9f0226bde4b039e441e210e2cefc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5d03325a574c77b928b85bb0ea91c89038e9c248","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        Configure the Store to use the stored configuration options"},{"line_number":409,"context_line":"        Any store that needs special configuration should implement"},{"line_number":410,"context_line":"        this method. If the store was not able to successfully configure"},{"line_number":411,"context_line":"        itself, it should raise `exceptions.BadStoreConfiguration`"},{"line_number":412,"context_line":"        \"\"\""},{"line_number":413,"context_line":"        if self.backend_group:"},{"line_number":414,"context_line":"            cinder_volume_type \u003d self.store_conf.cinder_volume_type"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_eadaf314","line":411,"range":{"start_line":411,"start_character":16,"end_line":411,"end_character":66},"in_reply_to":"9f560f44_5e481ccb","updated":"2020-08-19 01:30:53.000000000","message":"Done","commit_id":"105c703cf1ba9f0226bde4b039e441e210e2cefc"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1cec5574ed973558325d7caed3172e8964d068ba","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                # NOTE: `cinder_volume_type` is configured, check"},{"line_number":417,"context_line":"                # configured volume_type is available in cinder or not"},{"line_number":418,"context_line":"                cinder_client \u003d self.get_cinderclient()"},{"line_number":419,"context_line":"                volume_type_configured \u003d False"},{"line_number":420,"context_line":"                # TODO(whoami-rajat): support get volume type by id from"},{"line_number":421,"context_line":"                # client and use it here rather than iterating over the list"},{"line_number":422,"context_line":"                for c_type in cinder_client.volume_types.list():"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7e7b60f3","line":419,"range":{"start_line":419,"start_character":16,"end_line":419,"end_character":46},"updated":"2020-08-17 16:44:21.000000000","message":"Above Note at line #416 you are saying cinder_volume_type is configured and here it sounds ambiguous.\n\nMay be rename is to vaild_volume_type or something similar.","commit_id":"105c703cf1ba9f0226bde4b039e441e210e2cefc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5d03325a574c77b928b85bb0ea91c89038e9c248","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                # NOTE: `cinder_volume_type` is configured, check"},{"line_number":417,"context_line":"                # configured volume_type is available in cinder or not"},{"line_number":418,"context_line":"                cinder_client \u003d self.get_cinderclient()"},{"line_number":419,"context_line":"                volume_type_configured \u003d False"},{"line_number":420,"context_line":"                # TODO(whoami-rajat): support get volume type by id from"},{"line_number":421,"context_line":"                # client and use it here rather than iterating over the list"},{"line_number":422,"context_line":"                for c_type in cinder_client.volume_types.list():"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_2a06ab87","line":419,"range":{"start_line":419,"start_character":16,"end_line":419,"end_character":46},"in_reply_to":"9f560f44_7e7b60f3","updated":"2020-08-19 01:30:53.000000000","message":"Done","commit_id":"105c703cf1ba9f0226bde4b039e441e210e2cefc"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1cec5574ed973558325d7caed3172e8964d068ba","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                    if len(self.conf.enabled_backends) \u003e 1:"},{"line_number":429,"context_line":"                        reason \u003d _(\"Invalid `cinder_volume_type %s`\""},{"line_number":430,"context_line":"                                   % cinder_volume_type)"},{"line_number":431,"context_line":"                        LOG.debug(reason)"},{"line_number":432,"context_line":"                        raise exceptions.BadStoreConfiguration("},{"line_number":433,"context_line":"                            store_name\u003dself.backend_group, reason\u003dreason)"},{"line_number":434,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7ec9a023","line":431,"range":{"start_line":431,"start_character":24,"end_line":431,"end_character":41},"updated":"2020-08-17 16:44:21.000000000","message":"Shouldn\u0027t this will be info or warning?","commit_id":"105c703cf1ba9f0226bde4b039e441e210e2cefc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5d03325a574c77b928b85bb0ea91c89038e9c248","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                    if len(self.conf.enabled_backends) \u003e 1:"},{"line_number":429,"context_line":"                        reason \u003d _(\"Invalid `cinder_volume_type %s`\""},{"line_number":430,"context_line":"                                   % cinder_volume_type)"},{"line_number":431,"context_line":"                        LOG.debug(reason)"},{"line_number":432,"context_line":"                        raise exceptions.BadStoreConfiguration("},{"line_number":433,"context_line":"                            store_name\u003dself.backend_group, reason\u003dreason)"},{"line_number":434,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_aaf91b81","line":431,"range":{"start_line":431,"start_character":24,"end_line":431,"end_character":41},"in_reply_to":"9f560f44_7ec9a023","updated":"2020-08-19 01:30:53.000000000","message":"I think LOG.exception will be better here\nDone","commit_id":"105c703cf1ba9f0226bde4b039e441e210e2cefc"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1cec5574ed973558325d7caed3172e8964d068ba","unresolved":false,"context_lines":[{"line_number":437,"context_line":"                        LOG.exception(msg)"},{"line_number":438,"context_line":"                        raise exceptions.BackendException(msg)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    def associate_images_to_stores(self, context, volume_id):"},{"line_number":441,"context_line":"        try:"},{"line_number":442,"context_line":"            cinder_client \u003d self.get_cinderclient(context\u003dcontext,"},{"line_number":443,"context_line":"                                                  legacy_update\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_3e544821","line":440,"range":{"start_line":440,"start_character":8,"end_line":440,"end_character":34},"updated":"2020-08-17 16:44:21.000000000","message":"This method is for updating legacy images, right?\nI guess it will be better to add docstring describing what this image is actually doing.\n\nAlso at a time, this method will deal with single image and also it is returning boolean value, so either rename it to \n\nis_image_associated_with_store or\nis_image_belongs_to_this_store\n\nor something like that.","commit_id":"105c703cf1ba9f0226bde4b039e441e210e2cefc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5d03325a574c77b928b85bb0ea91c89038e9c248","unresolved":false,"context_lines":[{"line_number":437,"context_line":"                        LOG.exception(msg)"},{"line_number":438,"context_line":"                        raise exceptions.BackendException(msg)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    def associate_images_to_stores(self, context, volume_id):"},{"line_number":441,"context_line":"        try:"},{"line_number":442,"context_line":"            cinder_client \u003d self.get_cinderclient(context\u003dcontext,"},{"line_number":443,"context_line":"                                                  legacy_update\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0a65a745","line":440,"range":{"start_line":440,"start_character":8,"end_line":440,"end_character":34},"in_reply_to":"9f560f44_3e544821","updated":"2020-08-19 01:30:53.000000000","message":"Note: The false condition should be handled on glance properly showing a bad upgrade.\nsee comment on https://review.opendev.org/#/c/741498/15\nDone","commit_id":"105c703cf1ba9f0226bde4b039e441e210e2cefc"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"e5314cbadd9b1dafd2362beabea35535b10164be","unresolved":false,"context_lines":[{"line_number":421,"context_line":"                # NOTE: `cinder_volume_type` is configured, check"},{"line_number":422,"context_line":"                # configured volume_type is available in cinder or not"},{"line_number":423,"context_line":"                cinder_client \u003d self.get_cinderclient()"},{"line_number":424,"context_line":"                vaild_volume_type \u003d False"},{"line_number":425,"context_line":"                # TODO(whoami-rajat): support get volume type by id from"},{"line_number":426,"context_line":"                # client and use it here rather than iterating over the list"},{"line_number":427,"context_line":"                for c_type in cinder_client.volume_types.list():"},{"line_number":428,"context_line":"                    if c_type.name \u003d\u003d cinder_volume_type:"},{"line_number":429,"context_line":"                        vaild_volume_type \u003d True"},{"line_number":430,"context_line":"                        break"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"                if not vaild_volume_type:"},{"line_number":433,"context_line":"                    if len(self.conf.enabled_backends) \u003e 1:"},{"line_number":434,"context_line":"                        reason \u003d _(\"Invalid `cinder_volume_type %s`\""},{"line_number":435,"context_line":"                                   % cinder_volume_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_2d1e6eba","line":432,"range":{"start_line":424,"start_character":0,"end_line":432,"end_character":41},"updated":"2020-08-24 17:35:18.000000000","message":"Instead of all this we could do:\n\n``\ntry:\n    # We don\u0027t even need the volume type object, as long\n    # as this returns clean, we know the name is good.\n    cinder_client.volume_types.find(name\u003dcinder_volume_type)\n# No need to worry NoUniqueMatch as volume type name is unique\nexcept cinder_exception.NotFound:\n``\n\nand then do our error handling dance below. (The NoUniqueMatch might not needed if the volume type name is forced to be unique at cinder side)","commit_id":"b955bc9e83f552d1b7b5a489760a1671d41db2a0"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"49ddd2e646368c5ad7b95dd9f326f5bd7e2d8a09","unresolved":false,"context_lines":[{"line_number":421,"context_line":"                # NOTE: `cinder_volume_type` is configured, check"},{"line_number":422,"context_line":"                # configured volume_type is available in cinder or not"},{"line_number":423,"context_line":"                cinder_client \u003d self.get_cinderclient()"},{"line_number":424,"context_line":"                vaild_volume_type \u003d False"},{"line_number":425,"context_line":"                # TODO(whoami-rajat): support get volume type by id from"},{"line_number":426,"context_line":"                # client and use it here rather than iterating over the list"},{"line_number":427,"context_line":"                for c_type in cinder_client.volume_types.list():"},{"line_number":428,"context_line":"                    if c_type.name \u003d\u003d cinder_volume_type:"},{"line_number":429,"context_line":"                        vaild_volume_type \u003d True"},{"line_number":430,"context_line":"                        break"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"                if not vaild_volume_type:"},{"line_number":433,"context_line":"                    if len(self.conf.enabled_backends) \u003e 1:"},{"line_number":434,"context_line":"                        reason \u003d _(\"Invalid `cinder_volume_type %s`\""},{"line_number":435,"context_line":"                                   % cinder_volume_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_6d31860b","line":432,"range":{"start_line":424,"start_character":0,"end_line":432,"end_character":41},"in_reply_to":"9f560f44_2d1e6eba","updated":"2020-08-24 17:40:45.000000000","message":"Oops, only partially amended the above after I got verification that the volyme type name is unique, so please ignore the last sentence.","commit_id":"b955bc9e83f552d1b7b5a489760a1671d41db2a0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cc794cee4e695f8aa9b2a101837635e39da59c15","unresolved":false,"context_lines":[{"line_number":421,"context_line":"                # NOTE: `cinder_volume_type` is configured, check"},{"line_number":422,"context_line":"                # configured volume_type is available in cinder or not"},{"line_number":423,"context_line":"                cinder_client \u003d self.get_cinderclient()"},{"line_number":424,"context_line":"                vaild_volume_type \u003d False"},{"line_number":425,"context_line":"                # TODO(whoami-rajat): support get volume type by id from"},{"line_number":426,"context_line":"                # client and use it here rather than iterating over the list"},{"line_number":427,"context_line":"                for c_type in cinder_client.volume_types.list():"},{"line_number":428,"context_line":"                    if c_type.name \u003d\u003d cinder_volume_type:"},{"line_number":429,"context_line":"                        vaild_volume_type \u003d True"},{"line_number":430,"context_line":"                        break"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"                if not vaild_volume_type:"},{"line_number":433,"context_line":"                    if len(self.conf.enabled_backends) \u003e 1:"},{"line_number":434,"context_line":"                        reason \u003d _(\"Invalid `cinder_volume_type %s`\""},{"line_number":435,"context_line":"                                   % cinder_volume_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_4f6635ef","line":432,"range":{"start_line":424,"start_character":0,"end_line":432,"end_character":41},"in_reply_to":"9f560f44_6d31860b","updated":"2020-08-24 19:35:12.000000000","message":"Done","commit_id":"b955bc9e83f552d1b7b5a489760a1671d41db2a0"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"e5314cbadd9b1dafd2362beabea35535b10164be","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                        break"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"                if not vaild_volume_type:"},{"line_number":433,"context_line":"                    if len(self.conf.enabled_backends) \u003e 1:"},{"line_number":434,"context_line":"                        reason \u003d _(\"Invalid `cinder_volume_type %s`\""},{"line_number":435,"context_line":"                                   % cinder_volume_type)"},{"line_number":436,"context_line":"                        LOG.exception(reason)"},{"line_number":437,"context_line":"                        raise exceptions.BadStoreConfiguration("},{"line_number":438,"context_line":"                            store_name\u003dself.backend_group, reason\u003dreason)"},{"line_number":439,"context_line":"                    else:"},{"line_number":440,"context_line":"                        msg \u003d _LE(\"Invalid `cinder_volume_type %s`\""},{"line_number":441,"context_line":"                                  % cinder_volume_type)"},{"line_number":442,"context_line":"                        LOG.exception(msg)"},{"line_number":443,"context_line":"                        raise exceptions.BackendException(msg)"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    def is_image_associated_with_store(self, context, volume_id):"},{"line_number":446,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0de0ca25","line":443,"range":{"start_line":433,"start_character":20,"end_line":443,"end_character":62},"updated":"2020-08-24 17:35:18.000000000","message":"We do not want to use log.exception here. That will log full stack trace with no reason to do so. I think error() is appropriate for the first and critical() for the second as we prevent the service to start in that case.\n\nAlso the message can be created just once (just do it before the `if` with _() translation) as we\u0027re raising exception out of it in both cases.","commit_id":"b955bc9e83f552d1b7b5a489760a1671d41db2a0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cc794cee4e695f8aa9b2a101837635e39da59c15","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                        break"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"                if not vaild_volume_type:"},{"line_number":433,"context_line":"                    if len(self.conf.enabled_backends) \u003e 1:"},{"line_number":434,"context_line":"                        reason \u003d _(\"Invalid `cinder_volume_type %s`\""},{"line_number":435,"context_line":"                                   % cinder_volume_type)"},{"line_number":436,"context_line":"                        LOG.exception(reason)"},{"line_number":437,"context_line":"                        raise exceptions.BadStoreConfiguration("},{"line_number":438,"context_line":"                            store_name\u003dself.backend_group, reason\u003dreason)"},{"line_number":439,"context_line":"                    else:"},{"line_number":440,"context_line":"                        msg \u003d _LE(\"Invalid `cinder_volume_type %s`\""},{"line_number":441,"context_line":"                                  % cinder_volume_type)"},{"line_number":442,"context_line":"                        LOG.exception(msg)"},{"line_number":443,"context_line":"                        raise exceptions.BackendException(msg)"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    def is_image_associated_with_store(self, context, volume_id):"},{"line_number":446,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_af61d1d5","line":443,"range":{"start_line":433,"start_character":20,"end_line":443,"end_character":62},"in_reply_to":"9f560f44_0de0ca25","updated":"2020-08-24 19:35:12.000000000","message":"Done","commit_id":"b955bc9e83f552d1b7b5a489760a1671d41db2a0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fb08f0f6b28de3f5c7734f1f35c60a796c83d583","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                default_type \u003d cinder_client.volume_types.default()[\u0027name\u0027]"},{"line_number":464,"context_line":"                if volume.volume_type \u003d\u003d default_type:"},{"line_number":465,"context_line":"                    return True"},{"line_number":466,"context_line":"        except Exception:"},{"line_number":467,"context_line":"            pass"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        return False"},{"line_number":470,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_36d1d6fc","line":467,"range":{"start_line":466,"start_character":8,"end_line":467,"end_character":16},"updated":"2020-08-20 13:47:11.000000000","message":"I would suggest to add comment here, why we are ignoring these failures.","commit_id":"b955bc9e83f552d1b7b5a489760a1671d41db2a0"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"49ddd2e646368c5ad7b95dd9f326f5bd7e2d8a09","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                default_type \u003d cinder_client.volume_types.default()[\u0027name\u0027]"},{"line_number":464,"context_line":"                if volume.volume_type \u003d\u003d default_type:"},{"line_number":465,"context_line":"                    return True"},{"line_number":466,"context_line":"        except Exception:"},{"line_number":467,"context_line":"            pass"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        return False"},{"line_number":470,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ed2476c8","line":467,"range":{"start_line":466,"start_character":8,"end_line":467,"end_character":16},"in_reply_to":"9f560f44_36d1d6fc","updated":"2020-08-24 17:40:45.000000000","message":"I agree, an explanation why we ignore absolutely any and every error here would be nice.","commit_id":"b955bc9e83f552d1b7b5a489760a1671d41db2a0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cc794cee4e695f8aa9b2a101837635e39da59c15","unresolved":false,"context_lines":[{"line_number":463,"context_line":"                default_type \u003d cinder_client.volume_types.default()[\u0027name\u0027]"},{"line_number":464,"context_line":"                if volume.volume_type \u003d\u003d default_type:"},{"line_number":465,"context_line":"                    return True"},{"line_number":466,"context_line":"        except Exception:"},{"line_number":467,"context_line":"            pass"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        return False"},{"line_number":470,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ef9c69c1","line":467,"range":{"start_line":466,"start_character":8,"end_line":467,"end_character":16},"in_reply_to":"9f560f44_ed2476c8","updated":"2020-08-24 19:35:12.000000000","message":"Done","commit_id":"b955bc9e83f552d1b7b5a489760a1671d41db2a0"}],"glance_store/tests/unit/test_cinder_store.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1cec5574ed973558325d7caed3172e8964d068ba","unresolved":false,"context_lines":[{"line_number":409,"context_line":"            self.store.delete(loc, context\u003dself.context)"},{"line_number":410,"context_line":"            fake_volume.delete.assert_called_once_with()"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    def test__set_url_prefix(self):"},{"line_number":413,"context_line":"        self.assertEqual(\u0027cinder://\u0027, self.store._url_prefix)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4117a146","line":412,"range":{"start_line":412,"start_character":13,"end_line":412,"end_character":14},"updated":"2020-08-17 16:44:21.000000000","message":"remove this _","commit_id":"105c703cf1ba9f0226bde4b039e441e210e2cefc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5d03325a574c77b928b85bb0ea91c89038e9c248","unresolved":false,"context_lines":[{"line_number":409,"context_line":"            self.store.delete(loc, context\u003dself.context)"},{"line_number":410,"context_line":"            fake_volume.delete.assert_called_once_with()"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    def test__set_url_prefix(self):"},{"line_number":413,"context_line":"        self.assertEqual(\u0027cinder://\u0027, self.store._url_prefix)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_2ac7cb14","line":412,"range":{"start_line":412,"start_character":13,"end_line":412,"end_character":14},"in_reply_to":"9f560f44_4117a146","updated":"2020-08-19 01:30:53.000000000","message":"In cinder, we follow the convention of prefix \u0027test_\u0027 followed by method name which is here \u0027_set_url_prefix\u0027, but i don\u0027t see this followed in glance_store so will change it.","commit_id":"105c703cf1ba9f0226bde4b039e441e210e2cefc"}]}