)]}'
{"glance_store/_drivers/rbd.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"aa4f676580c63e12aa837464bd356a23042fc04d","unresolved":true,"context_lines":[{"line_number":263,"context_line":"                    with rbd.Image(ioctx, self.name,"},{"line_number":264,"context_line":"                                   snapshot\u003dself.snapshot) as image:"},{"line_number":265,"context_line":"                        size \u003d image.size()"},{"line_number":266,"context_line":"                        if self.partial:"},{"line_number":267,"context_line":"                            bytes_left \u003d self.chunk_size"},{"line_number":268,"context_line":"                            if self.offset \u003c 0:"},{"line_number":269,"context_line":"                                return"}],"source_content_type":"text/x-python","patch_set":5,"id":"72ac0bcc_f7d254e0","line":266,"updated":"2022-08-11 14:29:52.000000000","message":"Why are you using this flag and a different read loop if the offset is set?\n\nIt looks to me like you should be able to use the same chunk read loop with a default offset(\u003d0) and chunk_size so that the implementation is the same. It looks to me like offset defaults to zero in the get() method anyway.\n\nI think offset should probably never be passed in as None, but if it is, just do:\n\n self.offset \u003d offset or 0\n \nin __init__() so that you can always assume it\u0027s available. This already exists for self.chunk_size, so that\u0027s fine.","commit_id":"39f1fd0aaebf7208f606cfc5225c3c2bcf7b6298"}]}