)]}'
{"glance_store/common/attachment_state_manager.py":[{"author":{"_account_id":34665,"name":"anguoming","email":"agm_daydayup@foxmail.com","username":"guomingan"},"change_message_id":"6f00b2ebaf354c1bbda16253468dba0c5bf615af","unresolved":true,"context_lines":[{"line_number":192,"context_line":"            except Exception:"},{"line_number":193,"context_line":"                LOG.exception(_LE(\u0027Error attaching volume %(volume_id)s\u0027,"},{"line_number":194,"context_line":"                              {\u0027volume_id\u0027: volume_id}))"},{"line_number":195,"context_line":"                del self.volumes[volume_id]"},{"line_number":196,"context_line":"                raise"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"            vol_attachment.add_attachment(attachment[\u0027id\u0027], host)"}],"source_content_type":"text/x-python","patch_set":9,"id":"4445b144_81010547","line":195,"range":{"start_line":195,"start_character":0,"end_line":195,"end_character":43},"updated":"2022-06-05 01:25:49.000000000","message":"Hello, Could you please explain why we need 195th line here? \n\nThis is my understanding below 😊:\nIf there are some attachments of one volume already(for example the attachment ids are 1,2,3), then we create an new attachment failed, if we call 195th line, we will lost attachment info of 1,2,3","commit_id":"ecda7f640fe4e807ba07981abfc1a637ddb496cd"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5545e6427a4ec046f2caa4d2016214732d2a1261","unresolved":true,"context_lines":[{"line_number":192,"context_line":"            except Exception:"},{"line_number":193,"context_line":"                LOG.exception(_LE(\u0027Error attaching volume %(volume_id)s\u0027,"},{"line_number":194,"context_line":"                              {\u0027volume_id\u0027: volume_id}))"},{"line_number":195,"context_line":"                del self.volumes[volume_id]"},{"line_number":196,"context_line":"                raise"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"            vol_attachment.add_attachment(attachment[\u0027id\u0027], host)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fc672f85_fc30e424","line":195,"range":{"start_line":195,"start_character":0,"end_line":195,"end_character":43},"in_reply_to":"4445b144_81010547","updated":"2023-02-21 10:49:39.000000000","message":"Your assessment looks correct. There is no reason to delete the volume record and all of the existing attachments along with it. This might cause failures during detach time. I will propose a followup to fix this.","commit_id":"ecda7f640fe4e807ba07981abfc1a637ddb496cd"}],"glance_store/common/cinder_utils.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b7bfb08a864e6669efd741e00e17286b473138a5","unresolved":true,"context_lines":[{"line_number":50,"context_line":"def _retry_on_bad_request(e):"},{"line_number":51,"context_line":"    if isinstance(e, cinder_exception.BadRequest):"},{"line_number":52,"context_line":"        return True"},{"line_number":53,"context_line":"    return False"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class API(object):"}],"source_content_type":"text/x-python","patch_set":9,"id":"6651322f_d935143c","line":53,"updated":"2021-08-16 06:25:42.000000000","message":"We do need a test to cover this scenario/code.","commit_id":"ecda7f640fe4e807ba07981abfc1a637ddb496cd"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7b6baf97a0e4694140e6e04472d5db1f74cc9e2f","unresolved":true,"context_lines":[{"line_number":50,"context_line":"def _retry_on_bad_request(e):"},{"line_number":51,"context_line":"    if isinstance(e, cinder_exception.BadRequest):"},{"line_number":52,"context_line":"        return True"},{"line_number":53,"context_line":"    return False"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class API(object):"}],"source_content_type":"text/x-python","patch_set":9,"id":"77d088aa_fa804a3f","line":53,"in_reply_to":"6651322f_d935143c","updated":"2021-08-16 06:57:24.000000000","message":"This is already a test for this here\nhttps://review.opendev.org/c/openstack/glance_store/+/786410/9/glance_store/tests/unit/common/test_cinder_utils.py","commit_id":"ecda7f640fe4e807ba07981abfc1a637ddb496cd"}]}