)]}'
{"glance_store/_drivers/cinder.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a10a2e7477d25c61bf06d454556317666cbebbe4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b4822203_0f8904e9","updated":"2021-07-16 11:42:18.000000000","message":"We should log the new messages as debug as this part of code has potential for massive flood of logs and they are not exactly something of constant interest. Also logged messages should not be put for translation anymore.","commit_id":"94c970faec576ce235cf4963d7987a9a145e7b04"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a10a2e7477d25c61bf06d454556317666cbebbe4","unresolved":true,"context_lines":[{"line_number":349,"context_line":"* A string representing absolute path of mount point."},{"line_number":350,"context_line":"\"\"\"),"},{"line_number":351,"context_line":"    cfg.IntOpt(\u0027cinder_volume_open_retry\u0027,"},{"line_number":352,"context_line":"               min\u003d1,"},{"line_number":353,"context_line":"               default\u003d1,"},{"line_number":354,"context_line":"               help\u003d\"\"\""},{"line_number":355,"context_line":"The number of attempts to get the expected state of the volume"},{"line_number":356,"context_line":"For a high availability configuration, glance may be waiting for volume in"}],"source_content_type":"text/x-python","patch_set":14,"id":"d3108aab_8d78fc3f","line":353,"range":{"start_line":352,"start_character":0,"end_line":353,"end_character":25},"updated":"2021-07-16 11:42:18.000000000","message":"for clarity we likely should default to 0 and change the line 646 to while retry \u003c\u003d retry_max. Just so that we do not give an idea to the operator that there must be retry happening every time. Technically our first try is not retry ;)","commit_id":"94c970faec576ce235cf4963d7987a9a145e7b04"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a10a2e7477d25c61bf06d454556317666cbebbe4","unresolved":true,"context_lines":[{"line_number":352,"context_line":"               min\u003d1,"},{"line_number":353,"context_line":"               default\u003d1,"},{"line_number":354,"context_line":"               help\u003d\"\"\""},{"line_number":355,"context_line":"The number of attempts to get the expected state of the volume"},{"line_number":356,"context_line":"For a high availability configuration, glance may be waiting for volume in"},{"line_number":357,"context_line":"the expected state"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"Minimum value 1"},{"line_number":360,"context_line":"\"\"\"),"},{"line_number":361,"context_line":"    cfg.IntOpt(\u0027cinder_volume_open_interval_retry\u0027,"},{"line_number":362,"context_line":"               min\u003d1,"},{"line_number":363,"context_line":"               default\u003d1,"},{"line_number":364,"context_line":"               help\u003d\"\"\""},{"line_number":365,"context_line":"Waiting time between checking the volume status"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"Minimum value 1"},{"line_number":368,"context_line":"\"\"\"),"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":14,"id":"ce8c216b_4264e012","line":367,"range":{"start_line":355,"start_character":0,"end_line":367,"end_character":15},"updated":"2021-07-16 11:42:18.000000000","message":"please highlight the connection between these two config keys in their help texts.","commit_id":"94c970faec576ce235cf4963d7987a9a145e7b04"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a10a2e7477d25c61bf06d454556317666cbebbe4","unresolved":true,"context_lines":[{"line_number":636,"context_line":"            root_helper, host, use_multipath, enforce_multipath)"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"        retry \u003d 0"},{"line_number":639,"context_line":"        retry_max \u003d int(self.store_conf.cinder_volume_open_retry)"},{"line_number":640,"context_line":"        retry_interval \u003d self.store_conf.cinder_volume_open_interval_retry"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        LOG.info((_(\u0027Try to reserve volume %(volume_id)s.\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"730c710a_a6883e0e","line":639,"range":{"start_line":639,"start_character":20,"end_line":639,"end_character":24},"updated":"2021-07-16 11:42:18.000000000","message":"should not be needed as the config option is specified as int already, there will not be any other values coming from it.","commit_id":"94c970faec576ce235cf4963d7987a9a145e7b04"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a10a2e7477d25c61bf06d454556317666cbebbe4","unresolved":true,"context_lines":[{"line_number":650,"context_line":"                LOG.info((_(\u0027Successfully reserved volume %(volume_id)s.\u0027)"},{"line_number":651,"context_line":"                          % {\u0027volume_id\u0027: volume.id}))"},{"line_number":652,"context_line":"                break"},{"line_number":653,"context_line":"            except cinder_exception.ClientException as e:"},{"line_number":654,"context_line":"                msg \u003d (_(\u0027Failed to reserve volume %(volume_id)s: %(error)s\u0027)"},{"line_number":655,"context_line":"                       % {\u0027volume_id\u0027: volume.id, \u0027error\u0027: e})"},{"line_number":656,"context_line":"                LOG.info((_(\u0027Retry to reserve volume %(volume_id)s. \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"7fe6a612_bca10d7d","line":653,"range":{"start_line":653,"start_character":36,"end_line":653,"end_character":51},"updated":"2021-07-16 11:42:18.000000000","message":"I\u0027m sure we get more specific exception than just generic client exception we can trigger the retry from. this will retry regardless what\u0027s wrong rather than this specific case where the volume is not available at the moment due someone else attaching it.\n\nWe shouldn\u0027t be retrying unless we can identify this specific issue that likely gets solved over time.","commit_id":"94c970faec576ce235cf4963d7987a9a145e7b04"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a10a2e7477d25c61bf06d454556317666cbebbe4","unresolved":true,"context_lines":[{"line_number":659,"context_line":"                          % {\u0027volume_id\u0027: volume.id,"},{"line_number":660,"context_line":"                             \u0027count\u0027: retry,"},{"line_number":661,"context_line":"                             \u0027max_count\u0027: retry_max}))"},{"line_number":662,"context_line":"                time.sleep(retry_interval)"},{"line_number":663,"context_line":"        if msg is not None and retry \u003e\u003d retry_max:"},{"line_number":664,"context_line":"            LOG.error(msg)"},{"line_number":665,"context_line":"            raise exceptions.BackendException(msg)"}],"source_content_type":"text/x-python","patch_set":14,"id":"e31b5e4d_5dae0490","line":662,"range":{"start_line":662,"start_character":16,"end_line":662,"end_character":42},"updated":"2021-07-16 11:42:18.000000000","message":"Should only sleep if this is not the last/only try.","commit_id":"94c970faec576ce235cf4963d7987a9a145e7b04"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a10a2e7477d25c61bf06d454556317666cbebbe4","unresolved":true,"context_lines":[{"line_number":660,"context_line":"                             \u0027count\u0027: retry,"},{"line_number":661,"context_line":"                             \u0027max_count\u0027: retry_max}))"},{"line_number":662,"context_line":"                time.sleep(retry_interval)"},{"line_number":663,"context_line":"        if msg is not None and retry \u003e\u003d retry_max:"},{"line_number":664,"context_line":"            LOG.error(msg)"},{"line_number":665,"context_line":"            raise exceptions.BackendException(msg)"},{"line_number":666,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7c8f44f2_e85983fc","line":663,"range":{"start_line":663,"start_character":37,"end_line":663,"end_character":39},"updated":"2021-07-16 11:42:18.000000000","message":"if min\u003d0 this would then become \u003e","commit_id":"94c970faec576ce235cf4963d7987a9a145e7b04"}]}