)]}'
{"glance_store/_drivers/cinder.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"26b6a60645acc88b1049dd56507a347037e7bb78","unresolved":true,"context_lines":[{"line_number":558,"context_line":"        session \u003d get_cinder_session(self.store_conf)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        if user_overriden:"},{"line_number":561,"context_line":"            username \u003d self.store_conf.cinder_store_user_name"},{"line_number":562,"context_line":"            url \u003d self.store_conf.cinder_store_auth_address"},{"line_number":563,"context_line":"            # use auth that is already in the session"},{"line_number":564,"context_line":"            auth \u003d None"},{"line_number":565,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"d2ff8786_b30b396f","line":562,"range":{"start_line":561,"start_character":12,"end_line":562,"end_character":59},"updated":"2021-06-23 16:54:09.000000000","message":"I don\u0027t see it used further in the code since you are passing session while creating client object at line #592. If that is the case then what is the use of this if condition as well.\n\nI guess you need to modify get_cinder_session method that it will accept user name and other parameters either from the conf or from the context if \u0027user_overriden\u0027 is true or False.","commit_id":"4ea33139516250f32ba4e7d07eee0ed52352d0be"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a940da74c37783a44e3b48150b09db8ff824e48a","unresolved":true,"context_lines":[{"line_number":558,"context_line":"        session \u003d get_cinder_session(self.store_conf)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        if user_overriden:"},{"line_number":561,"context_line":"            username \u003d self.store_conf.cinder_store_user_name"},{"line_number":562,"context_line":"            url \u003d self.store_conf.cinder_store_auth_address"},{"line_number":563,"context_line":"            # use auth that is already in the session"},{"line_number":564,"context_line":"            auth \u003d None"},{"line_number":565,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fc1e6edd_149a54ba","line":562,"range":{"start_line":561,"start_character":12,"end_line":562,"end_character":59},"in_reply_to":"72cb66e4_fdaf2ef9","updated":"2021-06-24 11:58:56.000000000","message":"Ahh, Don\u0027t know why due to some browser glitch I was not able to see the log message.\nMakes sense now.\n\nThanks for explaining in detail.","commit_id":"4ea33139516250f32ba4e7d07eee0ed52352d0be"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"c270b7a11f677dedd34833f2466fb32ddcd313f8","unresolved":true,"context_lines":[{"line_number":558,"context_line":"        session \u003d get_cinder_session(self.store_conf)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        if user_overriden:"},{"line_number":561,"context_line":"            username \u003d self.store_conf.cinder_store_user_name"},{"line_number":562,"context_line":"            url \u003d self.store_conf.cinder_store_auth_address"},{"line_number":563,"context_line":"            # use auth that is already in the session"},{"line_number":564,"context_line":"            auth \u003d None"},{"line_number":565,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"72cb66e4_fdaf2ef9","line":562,"range":{"start_line":561,"start_character":12,"end_line":562,"end_character":59},"in_reply_to":"8ab8b446_96e18dd3","updated":"2021-06-24 09:54:01.000000000","message":"not sure I understand you. We still need the \u0027if\u0027 to generate the tokenendpoint auth to override the one in the session, or to pass None as an auth to the cinderclient so that it uses the auth that is embedded in the session,\nand AFAIU we\u0027d like to keep logging under which user we execute request, and that user is different for two cases.","commit_id":"4ea33139516250f32ba4e7d07eee0ed52352d0be"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"379bb722449e22f394cda1f03abe2d70706c7aad","unresolved":true,"context_lines":[{"line_number":558,"context_line":"        session \u003d get_cinder_session(self.store_conf)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        if user_overriden:"},{"line_number":561,"context_line":"            username \u003d self.store_conf.cinder_store_user_name"},{"line_number":562,"context_line":"            url \u003d self.store_conf.cinder_store_auth_address"},{"line_number":563,"context_line":"            # use auth that is already in the session"},{"line_number":564,"context_line":"            auth \u003d None"},{"line_number":565,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"d6f0b3ba_98f36a8f","line":562,"range":{"start_line":561,"start_character":12,"end_line":562,"end_character":59},"in_reply_to":"d2ff8786_b30b396f","updated":"2021-06-24 09:18:42.000000000","message":"It is used solely for \u0027logging at L596 below (was trying to keep the log the same as before, so had to provide some values for those).\n\nThe idea of a \"cinder session\" is that it is static, instantiated once from creds and connection info in the config, so it can be made \u0027global\u0027.\nFor the un-overridden user one would have to re-create session+auth every time, while only the auth may be changed to a proper TokenEndpoint one,\nso I\u0027d rather keep the get_session as is, effectively caching the session object for the runtime of the process.","commit_id":"4ea33139516250f32ba4e7d07eee0ed52352d0be"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d2dd384fb700c5325e00393619abc1e7e9613f2a","unresolved":true,"context_lines":[{"line_number":558,"context_line":"        session \u003d get_cinder_session(self.store_conf)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        if user_overriden:"},{"line_number":561,"context_line":"            username \u003d self.store_conf.cinder_store_user_name"},{"line_number":562,"context_line":"            url \u003d self.store_conf.cinder_store_auth_address"},{"line_number":563,"context_line":"            # use auth that is already in the session"},{"line_number":564,"context_line":"            auth \u003d None"},{"line_number":565,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"8ab8b446_96e18dd3","line":562,"range":{"start_line":561,"start_character":12,"end_line":562,"end_character":59},"in_reply_to":"d6f0b3ba_98f36a8f","updated":"2021-06-24 09:45:18.000000000","message":"If that\u0027s the case then we can get rid of this if condition, rigth?\nIt is very confusing.","commit_id":"4ea33139516250f32ba4e7d07eee0ed52352d0be"}]}