)]}'
{"glance_store/_drivers/cinder.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"34fdd5f8e24288a283d081fd3dd4f0b976565838","unresolved":true,"context_lines":[{"line_number":712,"context_line":"            conn \u003d connector.InitiatorConnector.factory("},{"line_number":713,"context_line":"                connection_info[\u0027driver_volume_type\u0027], root_helper,"},{"line_number":714,"context_line":"                conn\u003dconnection_info, use_multipath\u003duse_multipath)"},{"line_number":715,"context_line":"            # The format info of nfs volumes is exposed via attachment_get"},{"line_number":716,"context_line":"            # API hence it is not available in the connection info of"},{"line_number":717,"context_line":"            # attachment object received from attachment_update and we need"},{"line_number":718,"context_line":"            # to do this call"},{"line_number":719,"context_line":"            vol_attachment \u003d self.volume_api.attachment_get("},{"line_number":720,"context_line":"                client, attachment.id)"},{"line_number":721,"context_line":"            if connection_info[\u0027driver_volume_type\u0027] \u003d\u003d \u0027nfs\u0027:"},{"line_number":722,"context_line":"                if (volume.encrypted or"},{"line_number":723,"context_line":"                        vol_attachment.connection_info[\u0027format\u0027] \u003d\u003d \u0027qcow2\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7639e55e_a876a6c7","line":720,"range":{"start_line":715,"start_character":0,"end_line":720,"end_character":38},"updated":"2021-07-28 13:49:54.000000000","message":"If this is just for NFS, why aren\u0027t we doing it inside the conditional below? Doesn\u0027t this make us always hit cinder even if we don\u0027t need the format?","commit_id":"a411e10e3065f29afed2232575f68769babffa76"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a157d995ee1cbd7ac73f4731f13fa291497c7f33","unresolved":false,"context_lines":[{"line_number":712,"context_line":"            conn \u003d connector.InitiatorConnector.factory("},{"line_number":713,"context_line":"                connection_info[\u0027driver_volume_type\u0027], root_helper,"},{"line_number":714,"context_line":"                conn\u003dconnection_info, use_multipath\u003duse_multipath)"},{"line_number":715,"context_line":"            # The format info of nfs volumes is exposed via attachment_get"},{"line_number":716,"context_line":"            # API hence it is not available in the connection info of"},{"line_number":717,"context_line":"            # attachment object received from attachment_update and we need"},{"line_number":718,"context_line":"            # to do this call"},{"line_number":719,"context_line":"            vol_attachment \u003d self.volume_api.attachment_get("},{"line_number":720,"context_line":"                client, attachment.id)"},{"line_number":721,"context_line":"            if connection_info[\u0027driver_volume_type\u0027] \u003d\u003d \u0027nfs\u0027:"},{"line_number":722,"context_line":"                if (volume.encrypted or"},{"line_number":723,"context_line":"                        vol_attachment.connection_info[\u0027format\u0027] \u003d\u003d \u0027qcow2\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"57bfd25f_53522122","line":720,"range":{"start_line":715,"start_character":0,"end_line":720,"end_character":38},"in_reply_to":"7639e55e_a876a6c7","updated":"2021-07-28 15:18:25.000000000","message":"Agreed. I\u0027m trying to remember why I did it this way, Maybe i thought the connection info is fetched from this attachment object and forgot we already have it available from attachment update call or we need to use this attachment object at more places.\nSince I don\u0027t see any of the above to be utilized here, will change as per your suggestion.","commit_id":"a411e10e3065f29afed2232575f68769babffa76"}],"glance_store/tests/unit/test_cinder_store.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"34fdd5f8e24288a283d081fd3dd4f0b976565838","unresolved":true,"context_lines":[{"line_number":232,"context_line":"                else:"},{"line_number":233,"context_line":"                    do_open()"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"                if not (encrypted_nfs or qcow2_vol):"},{"line_number":236,"context_line":"                    mock_conn.assert_called_once_with("},{"line_number":237,"context_line":"                        root_helper, socket.gethostname(),"},{"line_number":238,"context_line":"                        multipath_supported, enforce_multipath)"}],"source_content_type":"text/x-python","patch_set":3,"id":"a1439bae_c63952e8","line":235,"updated":"2021-07-28 13:49:54.000000000","message":"More detailed comment on the next file, but the same applies here. I see that this is the precedent for just ignoring all these exceptions if encrypted_nfs, but... not sure that\u0027s the best plan.","commit_id":"a411e10e3065f29afed2232575f68769babffa76"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a157d995ee1cbd7ac73f4731f13fa291497c7f33","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                else:"},{"line_number":233,"context_line":"                    do_open()"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"                if not (encrypted_nfs or qcow2_vol):"},{"line_number":236,"context_line":"                    mock_conn.assert_called_once_with("},{"line_number":237,"context_line":"                        root_helper, socket.gethostname(),"},{"line_number":238,"context_line":"                        multipath_supported, enforce_multipath)"}],"source_content_type":"text/x-python","patch_set":3,"id":"08a9b446_581c0b4e","line":235,"in_reply_to":"a1439bae_c63952e8","updated":"2021-07-28 15:18:25.000000000","message":"Done","commit_id":"a411e10e3065f29afed2232575f68769babffa76"}],"glance_store/tests/unit/test_multistore_cinder.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"34fdd5f8e24288a283d081fd3dd4f0b976565838","unresolved":true,"context_lines":[{"line_number":284,"context_line":"                    attach_complete.assert_called_once_with("},{"line_number":285,"context_line":"                        fake_client, fake_attachment_id)"},{"line_number":286,"context_line":"                    attach_delete.assert_called_once_with(fake_client,"},{"line_number":287,"context_line":"                                                          fake_attachment_id)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def test_open_cinder_volume_rw(self):"},{"line_number":290,"context_line":"        self._test_open_cinder_volume(\u0027wb\u0027, \u0027rw\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"48ea7dff_d9dcc676","line":287,"updated":"2021-07-28 13:49:54.000000000","message":"Wouldn\u0027t it be better to change this to assert all of these things in all cases? Either assert the above, or assert the opposite if encrypted/qcow2. It seems like you\u0027re just disabling a bunch of assertions if we\u0027re doing this kind of NFS instead of filling in with the actual ones.","commit_id":"a411e10e3065f29afed2232575f68769babffa76"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a157d995ee1cbd7ac73f4731f13fa291497c7f33","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                    attach_complete.assert_called_once_with("},{"line_number":285,"context_line":"                        fake_client, fake_attachment_id)"},{"line_number":286,"context_line":"                    attach_delete.assert_called_once_with(fake_client,"},{"line_number":287,"context_line":"                                                          fake_attachment_id)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def test_open_cinder_volume_rw(self):"},{"line_number":290,"context_line":"        self._test_open_cinder_volume(\u0027wb\u0027, \u0027rw\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ec05db4f_706bc682","line":287,"in_reply_to":"48ea7dff_d9dcc676","updated":"2021-07-28 15:18:25.000000000","message":"Makes sense, updating in next PS.","commit_id":"a411e10e3065f29afed2232575f68769babffa76"}]}