)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4625e23e662a97a1c5b20a020fd23aaeacc9b5ad","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Pavlo Shchelokovskyy \u003cshchelokovskyy@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-07-01 19:37:44 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Honor cinder_catalog_info for cinder service user"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"currently the service user is always using the public endpoint and \u0027volumev3\u0027"},{"line_number":10,"context_line":"service type when accessing Cinder (defaults in cinderclient.v3)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"324e93b5_7b296b94","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":49},"updated":"2021-12-10 15:35:39.000000000","message":"it\u0027s not always cinder user or service project, we can set any user  and project in ``cinder_store_user_name`` and ``cinder_store_project_name`` but it\u0027s good to use that as a standard.","commit_id":"efeadf18dadb1b4e515ab8999ed0a5eedc67edef"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"9cb40c6859fccde447b6373d0a62cbf93d76702b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Pavlo Shchelokovskyy \u003cshchelokovskyy@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-07-01 19:37:44 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Honor cinder_catalog_info for cinder service user"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"currently the service user is always using the public endpoint and \u0027volumev3\u0027"},{"line_number":10,"context_line":"service type when accessing Cinder (defaults in cinderclient.v3)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"66161527_8cad2958","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":49},"in_reply_to":"324e93b5_7b296b94","updated":"2022-05-13 14:27:54.000000000","message":"\u0027cinder service user\u0027 means \u0027service user configured for Cinder services\u0027. I could capitalize that if needed.","commit_id":"efeadf18dadb1b4e515ab8999ed0a5eedc67edef"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4625e23e662a97a1c5b20a020fd23aaeacc9b5ad","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Honor cinder_catalog_info for cinder service user"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"currently the service user is always using the public endpoint and \u0027volumev3\u0027"},{"line_number":10,"context_line":"service type when accessing Cinder (defaults in cinderclient.v3)"},{"line_number":11,"context_line":"which are not optimal for some deployments."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5dbd4532_205eb064","line":9,"range":{"start_line":9,"start_character":68,"end_line":9,"end_character":76},"updated":"2021-12-10 15:35:39.000000000","message":"Just to mention we\u0027ve removed v2 and this is the only service type available for cinder as of now. This is defaulted in both glance store config cinder_catalog_info[1] and on cinderclient v3 client[2] but it might change when we\u0027ve a new endpoint let\u0027s say v4\n\n[1] https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/cinder.py#L62\n[2] https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/client.py#L63-L64","commit_id":"efeadf18dadb1b4e515ab8999ed0a5eedc67edef"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"9cb40c6859fccde447b6373d0a62cbf93d76702b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Honor cinder_catalog_info for cinder service user"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"currently the service user is always using the public endpoint and \u0027volumev3\u0027"},{"line_number":10,"context_line":"service type when accessing Cinder (defaults in cinderclient.v3)"},{"line_number":11,"context_line":"which are not optimal for some deployments."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ca120a47_0e0ec10c","line":9,"range":{"start_line":9,"start_character":68,"end_line":9,"end_character":76},"in_reply_to":"5dbd4532_205eb064","updated":"2022-05-13 14:27:54.000000000","message":"This is why it is still better to actually parse the service type from the config if we allow to set it there.\n\nBesides, the more pressing point here is the unconditional usage of public endpoint, many deployments simply are not wired for services being able to access the public endpoints (that\u0027s why internal ones are there at all).","commit_id":"efeadf18dadb1b4e515ab8999ed0a5eedc67edef"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4625e23e662a97a1c5b20a020fd23aaeacc9b5ad","unresolved":true,"context_lines":[{"line_number":10,"context_line":"service type when accessing Cinder (defaults in cinderclient.v3)"},{"line_number":11,"context_line":"which are not optimal for some deployments."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch makes the service user honor the interface and service type"},{"line_number":14,"context_line":"set in the cinder_catalog_info config option."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Id4466e29b4de6c7add445be455a430fa0e706838"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9203af10_cf72f209","line":13,"range":{"start_line":13,"start_character":21,"end_line":13,"end_character":33},"updated":"2021-12-10 15:35:39.000000000","message":"i think you mean cinder user","commit_id":"efeadf18dadb1b4e515ab8999ed0a5eedc67edef"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4625e23e662a97a1c5b20a020fd23aaeacc9b5ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"572aae13_4e96f6d3","updated":"2021-12-10 15:35:39.000000000","message":"This change makes sense but the commit message isn\u0027t very clear. Also one concern regarding the code that fixed an issue which here is mentioned as a Related bug.","commit_id":"efeadf18dadb1b4e515ab8999ed0a5eedc67edef"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ee46002f2eed1dca9ba2a008deda9ad86dfcedc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6e9bbdf0_a3ff730d","updated":"2022-08-11 14:33:56.000000000","message":"This needs a test, but otherwise I think this is good.","commit_id":"3d69da251e821cf9f5e67ba9a9d5015877afd448"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"86996a2a49320d845666bb67d1e1c3b384fcb4dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0f042d3b_26c5f586","in_reply_to":"6e9bbdf0_a3ff730d","updated":"2023-08-31 15:24:31.000000000","message":"done","commit_id":"3d69da251e821cf9f5e67ba9a9d5015877afd448"}],"glance_store/_drivers/cinder.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4625e23e662a97a1c5b20a020fd23aaeacc9b5ad","unresolved":true,"context_lines":[{"line_number":412,"context_line":"def get_cinder_session(conf):"},{"line_number":413,"context_line":"    global CINDER_SESSION"},{"line_number":414,"context_line":"    if not CINDER_SESSION:"},{"line_number":415,"context_line":"        auth \u003d ksa_identity.V3Password("},{"line_number":416,"context_line":"            password\u003dconf.cinder_store_password,"},{"line_number":417,"context_line":"            username\u003dconf.cinder_store_user_name,"},{"line_number":418,"context_line":"            user_domain_name\u003dconf.cinder_store_user_domain_name,"},{"line_number":419,"context_line":"            project_name\u003dconf.cinder_store_project_name,"},{"line_number":420,"context_line":"            project_domain_name\u003dconf.cinder_store_project_domain_name,"},{"line_number":421,"context_line":"            auth_url\u003dconf.cinder_store_auth_address"},{"line_number":422,"context_line":"        )"},{"line_number":423,"context_line":"        if conf.cinder_api_insecure:"},{"line_number":424,"context_line":"            verify \u003d False"},{"line_number":425,"context_line":"        elif conf.cinder_ca_certificates_file:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5052e4b0_c8c92662","line":422,"range":{"start_line":415,"start_character":0,"end_line":422,"end_character":9},"updated":"2021-12-10 15:35:39.000000000","message":"I didn\u0027t review the original patch introducing this but this doesn\u0027t take into consideration that the username, password and other options might not be set in glance-api.conf and these values needs to be fetched from context. Not sure if it will even create a valid session in that case with None values.","commit_id":"efeadf18dadb1b4e515ab8999ed0a5eedc67edef"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"c2fa7932ff71ad49007821ec34d227acfc8e5dc4","unresolved":false,"context_lines":[{"line_number":412,"context_line":"def get_cinder_session(conf):"},{"line_number":413,"context_line":"    global CINDER_SESSION"},{"line_number":414,"context_line":"    if not CINDER_SESSION:"},{"line_number":415,"context_line":"        auth \u003d ksa_identity.V3Password("},{"line_number":416,"context_line":"            password\u003dconf.cinder_store_password,"},{"line_number":417,"context_line":"            username\u003dconf.cinder_store_user_name,"},{"line_number":418,"context_line":"            user_domain_name\u003dconf.cinder_store_user_domain_name,"},{"line_number":419,"context_line":"            project_name\u003dconf.cinder_store_project_name,"},{"line_number":420,"context_line":"            project_domain_name\u003dconf.cinder_store_project_domain_name,"},{"line_number":421,"context_line":"            auth_url\u003dconf.cinder_store_auth_address"},{"line_number":422,"context_line":"        )"},{"line_number":423,"context_line":"        if conf.cinder_api_insecure:"},{"line_number":424,"context_line":"            verify \u003d False"},{"line_number":425,"context_line":"        elif conf.cinder_ca_certificates_file:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d1f16c85_21f11b6c","line":422,"range":{"start_line":415,"start_character":0,"end_line":422,"end_character":9},"in_reply_to":"5052e4b0_c8c92662","updated":"2022-01-18 17:54:15.000000000","message":"We don\u0027t support project owning the cinder volume where the image is stored. The service account (this does not need to be cinder service account per se, but a dedicated account owning the images ith sufficient quotas and prrivileges) needs to be always set in the configs.","commit_id":"efeadf18dadb1b4e515ab8999ed0a5eedc67edef"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"9cb40c6859fccde447b6373d0a62cbf93d76702b","unresolved":false,"context_lines":[{"line_number":412,"context_line":"def get_cinder_session(conf):"},{"line_number":413,"context_line":"    global CINDER_SESSION"},{"line_number":414,"context_line":"    if not CINDER_SESSION:"},{"line_number":415,"context_line":"        auth \u003d ksa_identity.V3Password("},{"line_number":416,"context_line":"            password\u003dconf.cinder_store_password,"},{"line_number":417,"context_line":"            username\u003dconf.cinder_store_user_name,"},{"line_number":418,"context_line":"            user_domain_name\u003dconf.cinder_store_user_domain_name,"},{"line_number":419,"context_line":"            project_name\u003dconf.cinder_store_project_name,"},{"line_number":420,"context_line":"            project_domain_name\u003dconf.cinder_store_project_domain_name,"},{"line_number":421,"context_line":"            auth_url\u003dconf.cinder_store_auth_address"},{"line_number":422,"context_line":"        )"},{"line_number":423,"context_line":"        if conf.cinder_api_insecure:"},{"line_number":424,"context_line":"            verify \u003d False"},{"line_number":425,"context_line":"        elif conf.cinder_ca_certificates_file:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ef121337_7159cfc7","line":422,"range":{"start_line":415,"start_character":0,"end_line":422,"end_character":9},"in_reply_to":"d1f16c85_21f11b6c","updated":"2022-05-13 14:27:54.000000000","message":"Rajat,\nthis is handled in the code block around L589 below, where the required auth info is created from the incoming user token, and then injected into the cinderclient, overriding the auth info from this session.","commit_id":"efeadf18dadb1b4e515ab8999ed0a5eedc67edef"}]}