)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d57bbd6997d9974dce3cfbb0f0ebee1cd759d3b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"57562de2_cb9868db","updated":"2021-12-02 04:27:58.000000000","message":"recheck","commit_id":"00f4a3fa346dc40131a4858e17f416b0fff4949b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"80806feba471102c01546eaf1e3eed493caa1af1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d642a832_30d4e515","updated":"2021-11-30 04:21:55.000000000","message":"recheck","commit_id":"00f4a3fa346dc40131a4858e17f416b0fff4949b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0ce74180aad69d03ffbdf39cee15e1bb83544159","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5f28dc2e_0a99b680","updated":"2022-03-09 05:46:34.000000000","message":"Thanks Cyril, see reply inline.","commit_id":"3e1039fa41165e41afdebcd6d1d8617f128b8349"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"92437051b534641ca40e5cd56e2f020c41eb3380","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"48e7a004_664fc838","updated":"2022-02-16 09:09:26.000000000","message":"recheck\n\nunrelated failure in tempest.scenario.test_server_basic_ops.TestServerBasicOps\t\n\n: Failed while verifying metadata on server. Result of command \"curl http://169.254.169.254/latest/meta-data/public-ipv4\" is NOT \"172.24.5.78\".\n","commit_id":"3e1039fa41165e41afdebcd6d1d8617f128b8349"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2166d805dcf8ff0d0cf656dd2b918cac47711e42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"032ead44_3391a338","updated":"2022-07-20 08:27:19.000000000","message":"Looks good to me, will be helpful for debugging!","commit_id":"6851cab51a3d5dbf018f755efee8e0e640ac12ab"}],"glance_store/tests/unit/test_cinder_store.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"c85ba9dff7ecd641172079a455c3ad2974483a42","unresolved":true,"context_lines":[{"line_number":228,"context_line":"                                  \u0027gethostname\u0027) as mock_get_host, \\"},{"line_number":229,"context_line":"                mock.patch.object(socket,"},{"line_number":230,"context_line":"                                  \u0027getaddrinfo\u0027) as mock_get_host_ip, \\"},{"line_number":231,"context_line":"                mock.patch.object(cinder.strutils, \u0027mask_dict_password\u0027):"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"            fake_host \u003d \u0027fake_host\u0027"},{"line_number":234,"context_line":"            fake_addr_info \u003d [[0, 1, 2, 3, [\u0027127.0.0.1\u0027]]]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5baac83d_f273e941","line":231,"range":{"start_line":231,"start_character":16,"end_line":231,"end_character":33},"updated":"2022-03-07 21:25:30.000000000","message":"Why do we need to mock make_dict_password? Can we not use the real method on mocked data?","commit_id":"3e1039fa41165e41afdebcd6d1d8617f128b8349"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0ce74180aad69d03ffbdf39cee15e1bb83544159","unresolved":true,"context_lines":[{"line_number":228,"context_line":"                                  \u0027gethostname\u0027) as mock_get_host, \\"},{"line_number":229,"context_line":"                mock.patch.object(socket,"},{"line_number":230,"context_line":"                                  \u0027getaddrinfo\u0027) as mock_get_host_ip, \\"},{"line_number":231,"context_line":"                mock.patch.object(cinder.strutils, \u0027mask_dict_password\u0027):"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"            fake_host \u003d \u0027fake_host\u0027"},{"line_number":234,"context_line":"            fake_addr_info \u003d [[0, 1, 2, 3, [\u0027127.0.0.1\u0027]]]"}],"source_content_type":"text/x-python","patch_set":4,"id":"a9d8925a_ddebe458","line":231,"range":{"start_line":231,"start_character":16,"end_line":231,"end_character":33},"in_reply_to":"5baac83d_f273e941","updated":"2022-03-09 05:46:34.000000000","message":"The problem here is that connection_info is a mocked object (attachment.connection_info doesn\u0027t exist and mock object is returned, see L#172) instead of a dict and the reason for not creating it as a dict is it needs all the keys used in actual run of the open_cinder_volume method. That is one thing I plan to improve to emulate a real scenario but again that seems to much change unrelated to this patch. I will surely keep in mind to work on it as a refactoring effort later.","commit_id":"3e1039fa41165e41afdebcd6d1d8617f128b8349"}],"glance_store/tests/unit/test_multistore_cinder.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"c85ba9dff7ecd641172079a455c3ad2974483a42","unresolved":true,"context_lines":[{"line_number":262,"context_line":"                                  \u0027gethostname\u0027) as mock_get_host, \\"},{"line_number":263,"context_line":"                mock.patch.object(socket,"},{"line_number":264,"context_line":"                                  \u0027getaddrinfo\u0027) as mock_get_host_ip, \\"},{"line_number":265,"context_line":"                mock.patch.object(cinder.strutils, \u0027mask_dict_password\u0027):"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"            fake_host \u003d \u0027fake_host\u0027"},{"line_number":268,"context_line":"            fake_addr_info \u003d [[0, 1, 2, 3, [\u0027127.0.0.1\u0027]]]"}],"source_content_type":"text/x-python","patch_set":4,"id":"942a257d_3ef7e7a7","line":265,"updated":"2022-03-07 21:25:30.000000000","message":"Ditto","commit_id":"3e1039fa41165e41afdebcd6d1d8617f128b8349"}]}