)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f9b4de3b5c8d06f2081b303e3bc79cc4b4a92514","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     whoami-rajat \u003crajatdhasmana@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-23 11:21:40 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass ip and host correctly to os-brick"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the glance cinder store code, while getting connector info,"},{"line_number":10,"context_line":"passes the host in the ip field and doesn\u0027t pass the ip address at all."},{"line_number":11,"context_line":"This patch corrects the behavior of passing right values to right fields"},{"line_number":12,"context_line":"while calling os-brick."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1955668"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e6736aed_c828470f","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":23},"updated":"2021-12-23 16:31:15.000000000","message":"Pass valid IP address to os-brick\n\nWhile fetching connector information the cinder driver of glance-store is passing \u0027hostname\u0027 as IP address whereas it actually needs IP address.\n\nThis path fetches the IPV4 or IPV6 address from the available \u0027hostname\u0027 and passes it to os-brick.\n\n\n(Also mention why it is failing for dell and working for other cinder backends if possible)","commit_id":"425ab4eb12b80410e8719b01765f1f78e8dcfc84"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ba403259056ea8b88e76a9c8570a2a0601773257","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     whoami-rajat \u003crajatdhasmana@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-23 11:21:40 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass ip and host correctly to os-brick"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the glance cinder store code, while getting connector info,"},{"line_number":10,"context_line":"passes the host in the ip field and doesn\u0027t pass the ip address at all."},{"line_number":11,"context_line":"This patch corrects the behavior of passing right values to right fields"},{"line_number":12,"context_line":"while calling os-brick."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1955668"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d28bcb2a_89d71d36","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":23},"in_reply_to":"e6736aed_c828470f","updated":"2021-12-23 16:47:16.000000000","message":"Done","commit_id":"425ab4eb12b80410e8719b01765f1f78e8dcfc84"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5a0fede67a463d80816a9a5a4ef13cb457a04044","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"116ea287_be0ee628","updated":"2021-12-23 16:24:21.000000000","message":"Thanks Abhishek for the review.","commit_id":"425ab4eb12b80410e8719b01765f1f78e8dcfc84"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"64df8ee853c79b7af39639478a826e4cac152e48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ded4f609_f9d0586b","updated":"2021-12-23 17:11:54.000000000","message":"Looks good to me, thank you Rajat!","commit_id":"8b4d97a6f7ce0805a430dac6756495db7a5aacb4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"62e692d47aceafba777399e69bd417de0918b1d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ccd63347_adf33bb7","updated":"2021-12-24 06:33:32.000000000","message":"Ninja approving as rest of the core team is on vacation till new year. If there are any suggestions then we can provide a followup later.\n\nThank you Rajat for quick fix!","commit_id":"8b4d97a6f7ce0805a430dac6756495db7a5aacb4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ba403259056ea8b88e76a9c8570a2a0601773257","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ffba314f_ce7c3071","updated":"2021-12-23 16:47:16.000000000","message":"Thanks Abhishek.","commit_id":"8b4d97a6f7ce0805a430dac6756495db7a5aacb4"}],"glance_store/_drivers/cinder.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"18affcb0127a38a32956c7e60759d97c5738f024","unresolved":true,"context_lines":[{"line_number":698,"context_line":"        mount_point_base \u003d self.store_conf.cinder_mount_point_base"},{"line_number":699,"context_line":"        volume_id \u003d volume.id"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        try:"},{"line_number":702,"context_line":"            my_ip \u003d socket.getaddrinfo(host, None, socket.AF_INET6)"},{"line_number":703,"context_line":"        except socket.gaierror:"},{"line_number":704,"context_line":"            my_ip \u003d socket.getaddrinfo(host, None, socket.AF_INET)"},{"line_number":705,"context_line":"        my_ip \u003d my_ip[0][4][0]"},{"line_number":706,"context_line":"        connector_prop \u003d connector.get_connector_properties("},{"line_number":707,"context_line":"            root_helper, my_ip, use_multipath, enforce_multipath, host\u003dhost)"},{"line_number":708,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1bec4133_6091bfdc","line":705,"range":{"start_line":701,"start_character":8,"end_line":705,"end_character":30},"updated":"2021-12-23 15:13:53.000000000","message":"extract this code to private method and then just return valid ip from there,\n\nmy_ip \u003d self._get_ip_address(host)\n\ndef _get_ip_address(self, host):\n    try:\n        return socket.getaddrinfo(host, None, socket.AF_INET6)[0][4][0]\n    except socket.gaierror:\n        return socket.getaddrinfo(host, None, socket.AF_INET)[0][4][0]\n\nMaybe you can have this method static as well","commit_id":"cba3bb7f1117cf908c173c63a5de1fa00431c32e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5a0fede67a463d80816a9a5a4ef13cb457a04044","unresolved":false,"context_lines":[{"line_number":698,"context_line":"        mount_point_base \u003d self.store_conf.cinder_mount_point_base"},{"line_number":699,"context_line":"        volume_id \u003d volume.id"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        try:"},{"line_number":702,"context_line":"            my_ip \u003d socket.getaddrinfo(host, None, socket.AF_INET6)"},{"line_number":703,"context_line":"        except socket.gaierror:"},{"line_number":704,"context_line":"            my_ip \u003d socket.getaddrinfo(host, None, socket.AF_INET)"},{"line_number":705,"context_line":"        my_ip \u003d my_ip[0][4][0]"},{"line_number":706,"context_line":"        connector_prop \u003d connector.get_connector_properties("},{"line_number":707,"context_line":"            root_helper, my_ip, use_multipath, enforce_multipath, host\u003dhost)"},{"line_number":708,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"36a53c0d_84a321b3","line":705,"range":{"start_line":701,"start_character":8,"end_line":705,"end_character":30},"in_reply_to":"1bec4133_6091bfdc","updated":"2021-12-23 16:24:21.000000000","message":"Done","commit_id":"cba3bb7f1117cf908c173c63a5de1fa00431c32e"}]}