)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"007316bf7adad7a19abdd09705ebdcdaddff2232","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5dd1af16_9e1aea37","updated":"2022-03-14 16:57:23.000000000","message":"Thanks Abhishek","commit_id":"fba6d0dd836a6d5741bceddfb4fa37c4af7daff6"}],"glance_store/tests/unit/test_cinder_base.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c79eee9e7099cc18862cd68e38908c64cc289226","unresolved":true,"context_lines":[{"line_number":390,"context_line":"            self.config(cinder_volume_type\u003d\u0027some_type\u0027, group\u003dbackend)"},{"line_number":391,"context_line":"            expected_location \u003d \u0027cinder://%s/%s\u0027 % (backend, fake_volume.id)"},{"line_number":392,"context_line":"        else:"},{"line_number":393,"context_line":"            self.config(cinder_volume_type\u003d\u0027some_type\u0027)"},{"line_number":394,"context_line":"            expected_location \u003d \u0027cinder://%s\u0027 % fake_volume.id"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        fake_client \u003d mock.MagicMock(auth_token\u003dNone, management_url\u003dNone)"}],"source_content_type":"text/x-python","patch_set":1,"id":"63ac7e5f_816cec59","line":393,"range":{"start_line":393,"start_character":12,"end_line":393,"end_character":55},"updated":"2022-03-14 14:16:48.000000000","message":"Also I think if it is not multistore then this option should be set under \u0027glance_store\u0027 section","commit_id":"fb10a8c197ad05e1f00e23d0b2040731f3fcea15"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"007316bf7adad7a19abdd09705ebdcdaddff2232","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            self.config(cinder_volume_type\u003d\u0027some_type\u0027, group\u003dbackend)"},{"line_number":391,"context_line":"            expected_location \u003d \u0027cinder://%s/%s\u0027 % (backend, fake_volume.id)"},{"line_number":392,"context_line":"        else:"},{"line_number":393,"context_line":"            self.config(cinder_volume_type\u003d\u0027some_type\u0027)"},{"line_number":394,"context_line":"            expected_location \u003d \u0027cinder://%s\u0027 % fake_volume.id"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        fake_client \u003d mock.MagicMock(auth_token\u003dNone, management_url\u003dNone)"}],"source_content_type":"text/x-python","patch_set":1,"id":"cfc9cf09_9a1d1f0b","line":393,"range":{"start_line":393,"start_character":12,"end_line":393,"end_character":55},"in_reply_to":"63ac7e5f_816cec59","updated":"2022-03-14 16:57:23.000000000","message":"by default (if no value is passed), then we register config in glance_store section but i will modify it to eliminate the if-else block as suggested\nhttps://github.com/openstack/glance_store/blob/master/glance_store/tests/base.py#L68","commit_id":"fb10a8c197ad05e1f00e23d0b2040731f3fcea15"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c79eee9e7099cc18862cd68e38908c64cc289226","unresolved":true,"context_lines":[{"line_number":384,"context_line":"        expected_checksum \u003d md5(expected_file_contents,"},{"line_number":385,"context_line":"                                usedforsecurity\u003dFalse).hexdigest()"},{"line_number":386,"context_line":"        expected_multihash \u003d hashlib.sha256(expected_file_contents).hexdigest()"},{"line_number":387,"context_line":"        if is_multi_store:"},{"line_number":388,"context_line":"            if not backend:"},{"line_number":389,"context_line":"                backend \u003d \u0027cinder1\u0027"},{"line_number":390,"context_line":"            self.config(cinder_volume_type\u003d\u0027some_type\u0027, group\u003dbackend)"},{"line_number":391,"context_line":"            expected_location \u003d \u0027cinder://%s/%s\u0027 % (backend, fake_volume.id)"},{"line_number":392,"context_line":"        else:"},{"line_number":393,"context_line":"            self.config(cinder_volume_type\u003d\u0027some_type\u0027)"},{"line_number":394,"context_line":"            expected_location \u003d \u0027cinder://%s\u0027 % fake_volume.id"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        fake_client \u003d mock.MagicMock(auth_token\u003dNone, management_url\u003dNone)"},{"line_number":397,"context_line":"        fake_volume.manager.get.return_value \u003d fake_volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"4646a223_99162df2","line":394,"range":{"start_line":387,"start_character":8,"end_line":394,"end_character":62},"updated":"2022-03-14 14:16:48.000000000","message":"you can avoid else block here;\n\nbackend_group \u003d \u0027glance_store\u0027\nexpected_location \u003d \u0027cinder://%s\u0027 % fake_volume.id\nif is_multi_store:\n    expected_location \u003d \u0027cinder://%s/%s\u0027 % (backend, fake_volume.id)\n    backend_group \u003d \u0027cinder1\u0027\n\nself.config(cinder_volume_type\u003d\u0027some_type\u0027, group\u003dbackend)","commit_id":"fb10a8c197ad05e1f00e23d0b2040731f3fcea15"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"007316bf7adad7a19abdd09705ebdcdaddff2232","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        expected_checksum \u003d md5(expected_file_contents,"},{"line_number":385,"context_line":"                                usedforsecurity\u003dFalse).hexdigest()"},{"line_number":386,"context_line":"        expected_multihash \u003d hashlib.sha256(expected_file_contents).hexdigest()"},{"line_number":387,"context_line":"        if is_multi_store:"},{"line_number":388,"context_line":"            if not backend:"},{"line_number":389,"context_line":"                backend \u003d \u0027cinder1\u0027"},{"line_number":390,"context_line":"            self.config(cinder_volume_type\u003d\u0027some_type\u0027, group\u003dbackend)"},{"line_number":391,"context_line":"            expected_location \u003d \u0027cinder://%s/%s\u0027 % (backend, fake_volume.id)"},{"line_number":392,"context_line":"        else:"},{"line_number":393,"context_line":"            self.config(cinder_volume_type\u003d\u0027some_type\u0027)"},{"line_number":394,"context_line":"            expected_location \u003d \u0027cinder://%s\u0027 % fake_volume.id"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        fake_client \u003d mock.MagicMock(auth_token\u003dNone, management_url\u003dNone)"},{"line_number":397,"context_line":"        fake_volume.manager.get.return_value \u003d fake_volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"7d164477_00b93148","line":394,"range":{"start_line":387,"start_character":8,"end_line":394,"end_character":62},"in_reply_to":"4646a223_99162df2","updated":"2022-03-14 16:57:23.000000000","message":"Done","commit_id":"fb10a8c197ad05e1f00e23d0b2040731f3fcea15"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3d9171c3bec8e66ffe4f54531f935443c1a9b88a","unresolved":true,"context_lines":[{"line_number":390,"context_line":"            # Default backend is \u0027glance_store\u0027 for single store but in case"},{"line_number":391,"context_line":"            # of multi store, if the backend option is not passed, we should"},{"line_number":392,"context_line":"            # assign it to the default i.e. \u0027cinder1\u0027"},{"line_number":393,"context_line":"            if backend \u003d\u003d \u0027glance_store\u0027:"},{"line_number":394,"context_line":"                backend \u003d \u0027cinder1\u0027"},{"line_number":395,"context_line":"            expected_location \u003d \u0027cinder://%s/%s\u0027 % (backend, fake_volume.id)"},{"line_number":396,"context_line":"        self.config(cinder_volume_type\u003d\u0027some_type\u0027, group\u003dbackend)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a5e699a0_1835f7d3","line":393,"range":{"start_line":393,"start_character":12,"end_line":393,"end_character":41},"updated":"2022-03-15 05:35:25.000000000","message":"nit: you can remove this if condition because we are sure that if is_multi_store is true then backend should be cinder1\n\nFix it if respin is required.","commit_id":"fba6d0dd836a6d5741bceddfb4fa37c4af7daff6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"317281753274a117122952527190e8a809d833ec","unresolved":true,"context_lines":[{"line_number":390,"context_line":"            # Default backend is \u0027glance_store\u0027 for single store but in case"},{"line_number":391,"context_line":"            # of multi store, if the backend option is not passed, we should"},{"line_number":392,"context_line":"            # assign it to the default i.e. \u0027cinder1\u0027"},{"line_number":393,"context_line":"            if backend \u003d\u003d \u0027glance_store\u0027:"},{"line_number":394,"context_line":"                backend \u003d \u0027cinder1\u0027"},{"line_number":395,"context_line":"            expected_location \u003d \u0027cinder://%s/%s\u0027 % (backend, fake_volume.id)"},{"line_number":396,"context_line":"        self.config(cinder_volume_type\u003d\u0027some_type\u0027, group\u003dbackend)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2eb48459_d7711120","line":393,"range":{"start_line":393,"start_character":12,"end_line":393,"end_character":41},"in_reply_to":"a5e699a0_1835f7d3","updated":"2022-03-15 06:29:22.000000000","message":"it\u0027s not always the case, we\u0027ve a test specifically with a different backend test_cinder_add_different_backend[1] in the multistore tests which passes \u0027cinder2\u0027 as a backend.\n\n[1] https://review.opendev.org/c/openstack/glance_store/+/833226/2/glance_store/tests/unit/test_multistore_cinder.py#256","commit_id":"fba6d0dd836a6d5741bceddfb4fa37c4af7daff6"}]}