)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"1c2d19433db6a6c517530265294a30c056ea0812","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c1d63847_4ce33d96","updated":"2022-03-16 19:56:55.000000000","message":"I really like how clean the tests become after refactoring everything, nice job!","commit_id":"c0c4969a4a6ce77c61f84fcb37b3efdac71d6418"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a6de3f9270be95c76c5bda54cd6459c9fc532ddd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fa433c74_4643024e","updated":"2022-03-15 05:31:52.000000000","message":"Thank you!!","commit_id":"c0c4969a4a6ce77c61f84fcb37b3efdac71d6418"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"565dd0d8cbffecb011d65f7323436ba606f445a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3ccd3a81_e57c5801","updated":"2022-03-14 16:58:16.000000000","message":"Thanks Abhishek","commit_id":"c0c4969a4a6ce77c61f84fcb37b3efdac71d6418"}],"glance_store/tests/unit/test_cinder_base.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"75dfa0cf1961ab4005360df09b040ec1a6d4ac36","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        if group:"},{"line_number":61,"context_line":"            self.config(**cinderclient_opts, group\u003dgroup)"},{"line_number":62,"context_line":"        else:"},{"line_number":63,"context_line":"            self.config(**cinderclient_opts)"},{"line_number":64,"context_line":"        cc \u003d self.store.get_cinderclient(self.context)"},{"line_number":65,"context_line":"        return cc"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"39a1f0fd_f9fb15e7","line":63,"range":{"start_line":63,"start_character":12,"end_line":63,"end_character":44},"updated":"2022-03-14 14:18:46.000000000","message":"ditto, this should be registered under glance_store section and not Default","commit_id":"28fe3989de6d54d0aa14295ffe6d0cc041473a2f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"565dd0d8cbffecb011d65f7323436ba606f445a7","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        if group:"},{"line_number":61,"context_line":"            self.config(**cinderclient_opts, group\u003dgroup)"},{"line_number":62,"context_line":"        else:"},{"line_number":63,"context_line":"            self.config(**cinderclient_opts)"},{"line_number":64,"context_line":"        cc \u003d self.store.get_cinderclient(self.context)"},{"line_number":65,"context_line":"        return cc"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c9cc0a0e_d325df51","line":63,"range":{"start_line":63,"start_character":12,"end_line":63,"end_character":44},"in_reply_to":"39a1f0fd_f9fb15e7","updated":"2022-03-14 16:58:16.000000000","message":"by default (if no value is passed), then we register config in glance_store section[1] but to eliminate the if-else block, I\u0027ve modified it to pass glance_store explicitly.\n[1] https://github.com/openstack/glance_store/blob/master/glance_store/tests/base.py#L68","commit_id":"28fe3989de6d54d0aa14295ffe6d0cc041473a2f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a6de3f9270be95c76c5bda54cd6459c9fc532ddd","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        if group:"},{"line_number":61,"context_line":"            self.config(**cinderclient_opts, group\u003dgroup)"},{"line_number":62,"context_line":"        else:"},{"line_number":63,"context_line":"            self.config(**cinderclient_opts)"},{"line_number":64,"context_line":"        cc \u003d self.store.get_cinderclient(self.context)"},{"line_number":65,"context_line":"        return cc"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"797b1e1d_ae392eb7","line":63,"range":{"start_line":63,"start_character":12,"end_line":63,"end_character":44},"in_reply_to":"c9cc0a0e_d325df51","updated":"2022-03-15 05:31:52.000000000","message":"Ack, I forgot this is a store library.\nMakes sense.","commit_id":"28fe3989de6d54d0aa14295ffe6d0cc041473a2f"}]}