)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d1c1a1712200b465bc8c7cc7038a8608bed86026","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c589a4c7_f9959145","updated":"2022-03-15 05:35:49.000000000","message":"recheck","commit_id":"64aae33ec60c83a96ac065c236bb940996ce3686"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"05e5565ce10f09aadb12e76db8a56f639de995b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8cec7c91_a45a7641","updated":"2022-03-17 10:40:27.000000000","message":"Thanks Cyril, updated the test.","commit_id":"3666d2d2e4be4524c47ba2531e39984e260c8ce8"}],"glance_store/tests/unit/test_cinder_base.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"ee464ba1b94eadc949c834ee030a5aec36fcf711","unresolved":true,"context_lines":[{"line_number":515,"context_line":"                fake_vol, fake_file)"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"    def test_process_specs(self):"},{"line_number":518,"context_line":"        self.location.process_specs()"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    def _test_get_uri(self, expected_uri):"},{"line_number":521,"context_line":"        uri \u003d self.location.get_uri()"}],"source_content_type":"text/x-python","patch_set":2,"id":"4135bc6b_0734ac84","line":518,"updated":"2022-03-16 20:01:16.000000000","message":"What exactly are we testing here? It does improve coverage, but I feel we\u0027re not really testing anything, and are just trying to get the coverage tool to give us a better mark.","commit_id":"64aae33ec60c83a96ac065c236bb940996ce3686"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"05e5565ce10f09aadb12e76db8a56f639de995b4","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                fake_vol, fake_file)"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"    def test_process_specs(self):"},{"line_number":518,"context_line":"        self.location.process_specs()"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    def _test_get_uri(self, expected_uri):"},{"line_number":521,"context_line":"        uri \u003d self.location.get_uri()"}],"source_content_type":"text/x-python","patch_set":2,"id":"4632240f_9735a5a5","line":518,"in_reply_to":"4135bc6b_0734ac84","updated":"2022-03-17 10:40:27.000000000","message":"I had the thought that even if we are not asserting anything, we should at least cover the syntax errors here and didn\u0027t add asserts as the values set in this method are already done while initializing the location object[1].\nI will add the asserts in next PS just to be sure the method is at least setting the right values (not modifying existing values and correcting any wrong values set before).\nThanks for pointing this out.\n\n[1] https://github.com/openstack/glance_store/blob/master/glance_store/location.py#L204","commit_id":"64aae33ec60c83a96ac065c236bb940996ce3686"}]}