)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"a497a2b34c05939226458bf376e71d9e69c962c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"475bbc90_0135bccc","updated":"2022-12-01 21:30:24.000000000","message":"Now that the spec is merged, is there anything else I should do on this patchset?","commit_id":"3ad5e92f695b1a3a75f538230ac7097adf753ed9"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"389a921bb4633fad321d243194bbe4056a8d1280","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fe4b7d3_f647a8fe","updated":"2022-08-16 09:45:03.000000000","message":"One other option could be to add an \"s3_store_extra_location\" instead of region_name which could be then used in get_s3_location.\nThat would be simpler to implement, but I dont like the hardcoded stuff anyway and I think having a region_name reflect more what we configure with awscli","commit_id":"3ad5e92f695b1a3a75f538230ac7097adf753ed9"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"df0788244e47d6027342af46b7d201ad5c23fb1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"806bc96e_5096ed1d","updated":"2022-08-18 16:30:30.000000000","message":"This is a new support which requires a spec/lite spec to discuss the use case. Please add this topic to PTG planning etherpad to discuss during PTG if you are interested to contribute for the same.\n\nhttps://etherpad.opendev.org/p/antelope-ptg-glance-planning","commit_id":"3ad5e92f695b1a3a75f538230ac7097adf753ed9"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3939ec5878b8d937b4ebd93baca33bdeb8572e36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b04feaa3_335e4d69","updated":"2022-12-02 06:02:29.000000000","message":"one correction in help message and I think you should add similar unit test  in test_multistore_s3.py as well (soon we will be removing single store support and keeping multistore only).","commit_id":"3ad5e92f695b1a3a75f538230ac7097adf753ed9"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"0453c768fddb47200d7a2fec30efc2e3b048de99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"75953638_02bdd20f","in_reply_to":"0a9b0e17_db5ce59d","updated":"2022-12-05 09:21:57.000000000","message":"Done","commit_id":"3ad5e92f695b1a3a75f538230ac7097adf753ed9"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"404a58a91b320849ac31858ebd6cd461dbde07a6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6167d840_ec507d03","in_reply_to":"41f2e2b3_16b42d3a","updated":"2022-08-19 09:38:09.000000000","message":"Hi Arnaud,\n\nAnyway we will not be able to get this feature merged in the current cycle as glance store release is in next week and as per upstream policy we don\u0027t allow any new feature to be discussed/approved post milestone 2. \n\nAs a result this feature will be accepted in new development cycle only.\nFor light spec you can refere the template from glance-specs repo.\n\nhttps://github.com/openstack/glance-specs/blob/master/specs/spec-lite-template.rst","commit_id":"3ad5e92f695b1a3a75f538230ac7097adf753ed9"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"3c1e09f7e892a9b9f6382e933388704f841d96c7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0a9b0e17_db5ce59d","in_reply_to":"60760abb_24a2941c","updated":"2022-08-23 07:21:51.000000000","message":"Here is the review https://review.opendev.org/c/openstack/glance-specs/+/854112","commit_id":"3ad5e92f695b1a3a75f538230ac7097adf753ed9"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"cbf03a15b9ab58328fe5ed178b92b8fcc0900360","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"60760abb_24a2941c","in_reply_to":"6167d840_ec507d03","updated":"2022-08-19 09:49:11.000000000","message":"Hey,\nThanks for the lite-spec link, will do the job.\n\nI am aware that this wont be merged in the current cycle, no problem for this.\n\nI\u0027ll do my best to be there on PTG, but if we can move on with this outside of PTG, that would be easier to me 😊","commit_id":"3ad5e92f695b1a3a75f538230ac7097adf753ed9"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"c19000ee8f312868e332b8564fa3a7287e126b25","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"41f2e2b3_16b42d3a","in_reply_to":"806bc96e_5096ed1d","updated":"2022-08-19 09:34:07.000000000","message":"Hello for lite spec.\nIs there any doc on how to proceed for this?\n\nFor PTG, sounds overkill to wait for it, no?","commit_id":"3ad5e92f695b1a3a75f538230ac7097adf753ed9"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"d702e753c3c2f7f26f3afdb7f24cc8e91a8960f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1ee36d2e_e14ab25c","in_reply_to":"b04feaa3_335e4d69","updated":"2022-12-02 10:48:12.000000000","message":"done","commit_id":"3ad5e92f695b1a3a75f538230ac7097adf753ed9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"965407bbe49b8945307d8e87d27af52987f05e3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dbb178f7_d6724802","updated":"2022-12-05 14:49:23.000000000","message":"Looks good to me, but will leave to someone else to do the merge.","commit_id":"2ad4a73e7f4278fe961e8c75f7f9bdbf51382b64"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"062f9a085ba77e7f6dc51036b6a75ee902b9a2a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3c3449b6_2220f34e","updated":"2022-12-05 09:24:36.000000000","message":"Looks good to me, thank you!","commit_id":"2ad4a73e7f4278fe961e8c75f7f9bdbf51382b64"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"89095eda1d732f5c84fd4c9ca1b46321e5e957cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aa15cf0a_ecdd451c","updated":"2022-12-13 05:22:51.000000000","message":"Thank you!","commit_id":"2ad4a73e7f4278fe961e8c75f7f9bdbf51382b64"}],"glance_store/_drivers/s3.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3939ec5878b8d937b4ebd93baca33bdeb8572e36","unresolved":true,"context_lines":[{"line_number":71,"context_line":"The S3 region name."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"This parameter will set the region_name used by boto."},{"line_number":74,"context_line":"If this parameter is not set, we we will try to compute if from the"},{"line_number":75,"context_line":"s3_store_host."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"965f8141_9bd6de97","line":74,"range":{"start_line":74,"start_character":56,"end_line":74,"end_character":58},"updated":"2022-12-02 06:02:29.000000000","message":"it?","commit_id":"3ad5e92f695b1a3a75f538230ac7097adf753ed9"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"d702e753c3c2f7f26f3afdb7f24cc8e91a8960f5","unresolved":false,"context_lines":[{"line_number":71,"context_line":"The S3 region name."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"This parameter will set the region_name used by boto."},{"line_number":74,"context_line":"If this parameter is not set, we we will try to compute if from the"},{"line_number":75,"context_line":"s3_store_host."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"67941c5a_0853ab58","line":74,"range":{"start_line":74,"start_character":56,"end_line":74,"end_character":58},"in_reply_to":"965f8141_9bd6de97","updated":"2022-12-02 10:48:12.000000000","message":"Done","commit_id":"3ad5e92f695b1a3a75f538230ac7097adf753ed9"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"e595e9d54e414d343d67556ba78f1e95124cc419","unresolved":true,"context_lines":[{"line_number":929,"context_line":"              Amazon S3, and if user wants to use S3 compatible storage,"},{"line_number":930,"context_line":"              returns \u0027\u0027"},{"line_number":931,"context_line":"    \"\"\""},{"line_number":932,"context_line":"    # NOTE(arnaud): maybe get rid of hardcoded amazon stuff here?"},{"line_number":933,"context_line":"    locations \u003d {"},{"line_number":934,"context_line":"        \u0027s3.amazonaws.com\u0027: \u0027\u0027,"},{"line_number":935,"context_line":"        \u0027s3-us-east-1.amazonaws.com\u0027: \u0027us-east-1\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"12f8b201_0d6eb99b","line":932,"range":{"start_line":932,"start_character":19,"end_line":932,"end_character":20},"updated":"2022-10-05 18:41:55.000000000","message":"With what would we replace this? Is there a way to dynamically get the s3 location?","commit_id":"3ad5e92f695b1a3a75f538230ac7097adf753ed9"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"91c8ecfda1e4be50087e07ab313db784badfbf33","unresolved":true,"context_lines":[{"line_number":929,"context_line":"              Amazon S3, and if user wants to use S3 compatible storage,"},{"line_number":930,"context_line":"              returns \u0027\u0027"},{"line_number":931,"context_line":"    \"\"\""},{"line_number":932,"context_line":"    # NOTE(arnaud): maybe get rid of hardcoded amazon stuff here?"},{"line_number":933,"context_line":"    locations \u003d {"},{"line_number":934,"context_line":"        \u0027s3.amazonaws.com\u0027: \u0027\u0027,"},{"line_number":935,"context_line":"        \u0027s3-us-east-1.amazonaws.com\u0027: \u0027us-east-1\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"f55e8aac_61540564","line":932,"range":{"start_line":932,"start_character":19,"end_line":932,"end_character":20},"in_reply_to":"12f8b201_0d6eb99b","updated":"2022-10-18 14:38:57.000000000","message":"Hello,\nI was mostly thinking about forcing the operator to set a region in config.","commit_id":"3ad5e92f695b1a3a75f538230ac7097adf753ed9"},{"author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"change_message_id":"0453c768fddb47200d7a2fec30efc2e3b048de99","unresolved":false,"context_lines":[{"line_number":929,"context_line":"              Amazon S3, and if user wants to use S3 compatible storage,"},{"line_number":930,"context_line":"              returns \u0027\u0027"},{"line_number":931,"context_line":"    \"\"\""},{"line_number":932,"context_line":"    # NOTE(arnaud): maybe get rid of hardcoded amazon stuff here?"},{"line_number":933,"context_line":"    locations \u003d {"},{"line_number":934,"context_line":"        \u0027s3.amazonaws.com\u0027: \u0027\u0027,"},{"line_number":935,"context_line":"        \u0027s3-us-east-1.amazonaws.com\u0027: \u0027us-east-1\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"04cae8cf_775e30f4","line":932,"range":{"start_line":932,"start_character":19,"end_line":932,"end_character":20},"in_reply_to":"f55e8aac_61540564","updated":"2022-12-05 09:21:57.000000000","message":"Done","commit_id":"3ad5e92f695b1a3a75f538230ac7097adf753ed9"}]}