)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"f4ac6f994bc24f37c5cb98e3be81c29d9a086695","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2848b487_710a5f22","updated":"2022-09-06 00:00:38.000000000","message":"Thanks for your patch, a few suggestions inline.","commit_id":"293d1ea507e2f8fb044933e61890a8ed76fc8976"}],"glance_store/tests/unit/test_driver.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"f4ac6f994bc24f37c5cb98e3be81c29d9a086695","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        self.assertIn(self.img_id, x[0])"},{"line_number":76,"context_line":"        self.assertEqual(self.img_size, x[1])"},{"line_number":77,"context_line":"        self.assertEqual(self.img_checksum, x[2])"},{"line_number":78,"context_line":"        self.assertEqual(dict, type(x[3]))"},{"line_number":79,"context_line":"        self.assertIsNone(x[3][\u0027context_obj\u0027])"},{"line_number":80,"context_line":"        self.assertIsNone(x[3][\u0027verifier_obj\u0027])"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"43aaa7f2_3a4f5ede","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":24},"updated":"2022-09-06 00:00:38.000000000","message":"For all of these, wouldn\u0027t we rather want\n\n\nself.assertIsInstance(x[3], dict)\n\n?","commit_id":"293d1ea507e2f8fb044933e61890a8ed76fc8976"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"750f9abcec6433e9f79bbb125da884b0cf9ac225","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.assertIn(self.img_id, x[0])"},{"line_number":76,"context_line":"        self.assertEqual(self.img_size, x[1])"},{"line_number":77,"context_line":"        self.assertEqual(self.img_checksum, x[2])"},{"line_number":78,"context_line":"        self.assertEqual(dict, type(x[3]))"},{"line_number":79,"context_line":"        self.assertIsNone(x[3][\u0027context_obj\u0027])"},{"line_number":80,"context_line":"        self.assertIsNone(x[3][\u0027verifier_obj\u0027])"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8aa9f61d_6576df40","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":24},"in_reply_to":"43aaa7f2_3a4f5ede","updated":"2022-09-10 12:26:58.000000000","message":"Done","commit_id":"293d1ea507e2f8fb044933e61890a8ed76fc8976"}],"glance_store/tests/unit/test_swift_store.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"f4ac6f994bc24f37c5cb98e3be81c29d9a086695","unresolved":true,"context_lines":[{"line_number":2181,"context_line":""},{"line_number":2182,"context_line":"    def test_buffer(self):"},{"line_number":2183,"context_line":"        self.reader.read(4)"},{"line_number":2184,"context_line":"        self.assertEqual(True, self.reader._buffered)"},{"line_number":2185,"context_line":""},{"line_number":2186,"context_line":"        # test buffer position"},{"line_number":2187,"context_line":"        self.assertEqual(4, self.reader.tell())"}],"source_content_type":"text/x-python","patch_set":1,"id":"d0f3e52f_60a84da8","line":2184,"range":{"start_line":2184,"start_character":25,"end_line":2184,"end_character":29},"updated":"2022-09-06 00:00:38.000000000","message":"Wouldn\u0027t we rather want:\n\nself.assertTrue(self.reader._buffered)\n\n?","commit_id":"293d1ea507e2f8fb044933e61890a8ed76fc8976"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"750f9abcec6433e9f79bbb125da884b0cf9ac225","unresolved":true,"context_lines":[{"line_number":2181,"context_line":""},{"line_number":2182,"context_line":"    def test_buffer(self):"},{"line_number":2183,"context_line":"        self.reader.read(4)"},{"line_number":2184,"context_line":"        self.assertEqual(True, self.reader._buffered)"},{"line_number":2185,"context_line":""},{"line_number":2186,"context_line":"        # test buffer position"},{"line_number":2187,"context_line":"        self.assertEqual(4, self.reader.tell())"}],"source_content_type":"text/x-python","patch_set":1,"id":"e28e70f7_19569fa1","line":2184,"range":{"start_line":2184,"start_character":25,"end_line":2184,"end_character":29},"in_reply_to":"d0f3e52f_60a84da8","updated":"2022-09-10 12:26:58.000000000","message":"The assertTrue statement checks whether bool(self.reader._buffered) is True or not.\nIf self.reader._buffered \u003d 1, the assertTrue succeeds.\nHowever checking whether self.reader._buffered equals True or not is required.\nSo it is appropriate to use assertEqual.","commit_id":"293d1ea507e2f8fb044933e61890a8ed76fc8976"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"b99823eab9f0f19c25186ad07d040c9713f00598","unresolved":false,"context_lines":[{"line_number":2181,"context_line":""},{"line_number":2182,"context_line":"    def test_buffer(self):"},{"line_number":2183,"context_line":"        self.reader.read(4)"},{"line_number":2184,"context_line":"        self.assertEqual(True, self.reader._buffered)"},{"line_number":2185,"context_line":""},{"line_number":2186,"context_line":"        # test buffer position"},{"line_number":2187,"context_line":"        self.assertEqual(4, self.reader.tell())"}],"source_content_type":"text/x-python","patch_set":1,"id":"6c66ce9f_c0475484","line":2184,"range":{"start_line":2184,"start_character":25,"end_line":2184,"end_character":29},"in_reply_to":"e28e70f7_19569fa1","updated":"2022-09-14 16:31:34.000000000","message":"Ack","commit_id":"293d1ea507e2f8fb044933e61890a8ed76fc8976"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2119b4fff931a48b6805d41ac7633f12b252cddc","unresolved":true,"context_lines":[{"line_number":2181,"context_line":""},{"line_number":2182,"context_line":"    def test_buffer(self):"},{"line_number":2183,"context_line":"        self.reader.read(4)"},{"line_number":2184,"context_line":"        self.assertEqual(True, self.reader._buffered)"},{"line_number":2185,"context_line":""},{"line_number":2186,"context_line":"        # test buffer position"},{"line_number":2187,"context_line":"        self.assertEqual(4, self.reader.tell())"}],"source_content_type":"text/x-python","patch_set":4,"id":"99618144_6b1a55b1","line":2184,"range":{"start_line":2184,"start_character":8,"end_line":2184,"end_character":53},"updated":"2022-11-17 13:38:31.000000000","message":"IMO this should be self.assertTrue(self.reader._buffered)","commit_id":"cafbab30ee43d550d694a25e947d1f2fdd34c8a4"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"3276d807d0a42de1b9ff935db6ad46cb1bd9b11d","unresolved":false,"context_lines":[{"line_number":2181,"context_line":""},{"line_number":2182,"context_line":"    def test_buffer(self):"},{"line_number":2183,"context_line":"        self.reader.read(4)"},{"line_number":2184,"context_line":"        self.assertEqual(True, self.reader._buffered)"},{"line_number":2185,"context_line":""},{"line_number":2186,"context_line":"        # test buffer position"},{"line_number":2187,"context_line":"        self.assertEqual(4, self.reader.tell())"}],"source_content_type":"text/x-python","patch_set":4,"id":"4fbfc29e_1213105f","line":2184,"range":{"start_line":2184,"start_character":8,"end_line":2184,"end_character":53},"in_reply_to":"99618144_6b1a55b1","updated":"2023-02-12 01:41:56.000000000","message":"Done","commit_id":"cafbab30ee43d550d694a25e947d1f2fdd34c8a4"}]}