)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"9d5074d0ac4819c96b6fde7776390e70b5e5001a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"94938fba_47a57bea","updated":"2022-10-12 14:14:59.000000000","message":"Thanks!","commit_id":"0df64d5af92b46457fd3f13aceb69b4f94b8b53c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"95efcb6d19c97cd24ec9f084c689c63f78bbf222","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"530950a3_e8d57e18","updated":"2022-10-12 15:44:15.000000000","message":"recheck tempest-full-py3 : timeout in tempest.api.compute.servers.test_server_rescue.ServerStableDeviceRescueTest.test_stable_device_rescue_disk_virtio_with_volume_attached -- looks like a kernel panic in the test server (obviously not related to this patch)","commit_id":"0df64d5af92b46457fd3f13aceb69b4f94b8b53c"}],"glance_store/tests/unit/test_cinder_base.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"79fd38fdb086cd6971a58e3e1e38ff94777039ea","unresolved":true,"context_lines":[{"line_number":595,"context_line":"        # CPython implementation detail: __len__ cannot return \u003e sys.maxsize,"},{"line_number":596,"context_line":"        # which on a 32-bit system is 2*units.Gi - 1"},{"line_number":597,"context_line":"        # https://docs.python.org/3/reference/datamodel.html#object.__len__"},{"line_number":598,"context_line":"        fakebuffer.__len__.return_value \u003d units.Gi"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        def get_fake_hash(type, secure\u003dFalse):"},{"line_number":601,"context_line":"            if type \u003d\u003d \u0027md5\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"99415452_943e4881","line":598,"range":{"start_line":598,"start_character":42,"end_line":598,"end_character":50},"updated":"2022-10-05 18:48:39.000000000","message":"Why don\u0027t you use \"int(expected_volume_size/2)\" here as you do in the other tests?","commit_id":"c08c10b574a8263f62b93f96bbf714f150ac7f92"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5b3abf90b5ae5103804603a4a06ea74bbb23277f","unresolved":true,"context_lines":[{"line_number":595,"context_line":"        # CPython implementation detail: __len__ cannot return \u003e sys.maxsize,"},{"line_number":596,"context_line":"        # which on a 32-bit system is 2*units.Gi - 1"},{"line_number":597,"context_line":"        # https://docs.python.org/3/reference/datamodel.html#object.__len__"},{"line_number":598,"context_line":"        fakebuffer.__len__.return_value \u003d units.Gi"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        def get_fake_hash(type, secure\u003dFalse):"},{"line_number":601,"context_line":"            if type \u003d\u003d \u0027md5\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"cf4ab37c_6cf1d991","line":598,"range":{"start_line":598,"start_character":42,"end_line":598,"end_character":50},"in_reply_to":"99415452_943e4881","updated":"2022-10-12 13:41:18.000000000","message":"I had to use it in the other tests, because otherwise pep8 reported expected_volume_size as an unused variable, and I didn\u0027t want to remove it because at the time I thought it made the tests more readable.  I didn\u0027t change this line because I didn\u0027t have to, but I agree that the inconsistency is a distraction, and having the explicit division by 2 here makes it easier to understand why fakebuffer is being returned twice at line 610.  I\u0027ll push a new patch set with the change.","commit_id":"c08c10b574a8263f62b93f96bbf714f150ac7f92"}]}
