)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"24963f5cd5ae522397d32fbbcee12c5704d9549f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5c8e9929_5d4334af","updated":"2023-01-16 17:56:35.000000000","message":"need new UTs for the online extend methods.","commit_id":"2151a4f70e766762c7addf761c8cb19980f4c8de"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"48d3276b52929a06dc6fba8a5cf8caf3e6a5e13f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"88beaa9c_0366303d","updated":"2023-02-06 09:40:18.000000000","message":"Looks good to me!","commit_id":"a7edc87b0e97d537c1b26ca521e18605a352cdfa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0e1bbdb36b00033c601cfd4aa0e20d2eaab0b21d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9ee1262e_cf69c023","updated":"2023-02-06 08:08:04.000000000","message":"Thanks Cyril for review, please find my replies inline.","commit_id":"a7edc87b0e97d537c1b26ca521e18605a352cdfa"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"460295946adc5ac97b1c9ef9c13d984b9e34886a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3c9c9720_3c7fb366","updated":"2023-02-06 19:27:39.000000000","message":"Thanks for your answers!","commit_id":"a7edc87b0e97d537c1b26ca521e18605a352cdfa"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"5bbd3c036252829e8ec9acd7db757c0228dd9db3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b593f168_c1196938","updated":"2023-02-02 15:41:25.000000000","message":"Would this fix https://bugs.launchpad.net/glance/+bug/2002932 ?","commit_id":"a7edc87b0e97d537c1b26ca521e18605a352cdfa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"63994a3cce244e2d2b79d31324e6fa271a1d3c5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c06c89f2_35666c45","updated":"2023-02-08 18:41:12.000000000","message":"recheck cinder dependency merged","commit_id":"a7edc87b0e97d537c1b26ca521e18605a352cdfa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0e1bbdb36b00033c601cfd4aa0e20d2eaab0b21d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fb9fd39d_3787f2c8","in_reply_to":"b593f168_c1196938","updated":"2023-02-06 08:08:04.000000000","message":"Not exactly. The solution to this bug is to pass the correct image size to cinder store from glance side which is a different effort that needs to be added in glance. Erno asked me to mention it in the spec[1] but not something that is related to this change.\n\n[1] https://specs.openstack.org/openstack/glance-specs/specs/2023.1/approved/glance_store/cinder_extend_in-use_volumes.html","commit_id":"a7edc87b0e97d537c1b26ca521e18605a352cdfa"}],"glance_store/_drivers/cinder/store.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"5bbd3c036252829e8ec9acd7db757c0228dd9db3","unresolved":true,"context_lines":[{"line_number":416,"context_line":"Possible values:"},{"line_number":417,"context_line":"    * True or False"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"\"\"\"),"},{"line_number":420,"context_line":"]"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"CINDER_SESSION \u003d None"}],"source_content_type":"text/x-python","patch_set":11,"id":"23146798_92417fe2","line":419,"range":{"start_line":419,"start_character":2,"end_line":419,"end_character":3},"updated":"2023-02-02 15:41:25.000000000","message":"So this would be yet another configuration option, which would need to be set by the admins (or by the installer).\n\nIs there any reason why an admin would choose not to enable this option if it is available? If this is something that we *always* want to turn on (when it\u0027s available, of course) then shouldn\u0027t we autodetect that the Cinder backend can perform the extension?","commit_id":"a7edc87b0e97d537c1b26ca521e18605a352cdfa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0e1bbdb36b00033c601cfd4aa0e20d2eaab0b21d","unresolved":true,"context_lines":[{"line_number":416,"context_line":"Possible values:"},{"line_number":417,"context_line":"    * True or False"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"\"\"\"),"},{"line_number":420,"context_line":"]"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"CINDER_SESSION \u003d None"}],"source_content_type":"text/x-python","patch_set":11,"id":"42ea9143_bb54003c","line":419,"range":{"start_line":419,"start_character":2,"end_line":419,"end_character":3},"in_reply_to":"23146798_92417fe2","updated":"2023-02-06 08:08:04.000000000","message":"The problem with \"always\" enabling it is if the cinder volume driver doesn\u0027t support extending attached volumes, it will raise an exception and cinder will put the volume in unusable state. For e.g., In cinder NFS driver, if we call extend API to extend in-use volume, it raises ExtendVolumeError[1] which cinder catches and changes the volume status to \"error_extending\" [2] i.e. making it unusable.\n\nThere is no way to know if a driver can perform the extend volume operation for attached volumes unless we actually perform that operation but it can cause the volume to be inaccessible, as mentioned above, so we only want to perform this unless we\u0027re 100% sure the driver can perform this for which we\u0027re introducing this new config option.\n\n[1] https://github.com/openstack/cinder/blob/f11ff244b78f5d353cfc8c06c21adf63d2f2c5a1/cinder/volume/drivers/nfs.py#L377\n[2] https://github.com/openstack/cinder/blob/f11ff244b78f5d353cfc8c06c21adf63d2f2c5a1/cinder/volume/manager.py#L2967-L2968","commit_id":"a7edc87b0e97d537c1b26ca521e18605a352cdfa"}]}