)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"1289db3b5640e0f155fe45663bffd567a3765f09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"74fc660c_c85b3093","updated":"2023-11-14 18:51:25.000000000","message":"Thanks! If this is something you\u0027re thinking of backporting, we may required a Launchpad bug though.","commit_id":"d6205ff3a63c6ac9fdb308d46a2ee99f628086e3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3b1c03cfc776c9dcf386c5aa6370676f4b11adb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"216e5b28_c32022f3","updated":"2023-11-05 09:15:35.000000000","message":"recheck unrelated error","commit_id":"d6205ff3a63c6ac9fdb308d46a2ee99f628086e3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bb0cf527c66e156d496b235b6701969c37f7ff24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"34a50de1_cde344d0","in_reply_to":"74fc660c_c85b3093","updated":"2023-11-15 12:21:00.000000000","message":"I initially skipped creating a bug because the issue may be trivial, but it\u0027d be probably better to have it to explain the problem better. so I created https://bugs.launchpad.net/glance-store/+bug/2043583 .","commit_id":"d6205ff3a63c6ac9fdb308d46a2ee99f628086e3"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9e58ccee078cf5da02060d66b4678101eff7d8e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"34ecffa3_967cf973","updated":"2023-12-07 13:08:49.000000000","message":"recheck","commit_id":"651f41a95a1703c5717fc47b8d9847d4da98c7de"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"e91accc067e25d8e02b84f7bcf689bebbb774a07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"eb596fe8_4b6a0b1d","updated":"2023-12-13 03:01:20.000000000","message":"recheck timeout","commit_id":"651f41a95a1703c5717fc47b8d9847d4da98c7de"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6c007f7a3acaef3fb985f147a6c1a2b398701689","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7f2e9341_e4a62d06","updated":"2023-11-15 15:19:08.000000000","message":"recheck unrelated timeout","commit_id":"651f41a95a1703c5717fc47b8d9847d4da98c7de"}],"glance_store/_drivers/cinder/store.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"1289db3b5640e0f155fe45663bffd567a3765f09","unresolved":true,"context_lines":[{"line_number":498,"context_line":"            self.store_conf \u003d self.conf.glance_store"},{"line_number":499,"context_line":"        self.volume_api \u003d cinder_utils.API()"},{"line_number":500,"context_line":"        if os_brick:"},{"line_number":501,"context_line":"            os_brick.setup(CONF)"},{"line_number":502,"context_line":"        # The purpose of this map is to store the connector object for a"},{"line_number":503,"context_line":"        # particular volume as we will need to call os-brick extend_volume"},{"line_number":504,"context_line":"        # method for the kernel to realize the new size change after cinder"}],"source_content_type":"text/x-python","patch_set":4,"id":"52b73b05_e414a8ed","line":501,"range":{"start_line":501,"start_character":27,"end_line":501,"end_character":31},"updated":"2023-11-14 18:51:25.000000000","message":"Thanks, this seems more readable than the call to getattr() :)","commit_id":"d6205ff3a63c6ac9fdb308d46a2ee99f628086e3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bb0cf527c66e156d496b235b6701969c37f7ff24","unresolved":false,"context_lines":[{"line_number":498,"context_line":"            self.store_conf \u003d self.conf.glance_store"},{"line_number":499,"context_line":"        self.volume_api \u003d cinder_utils.API()"},{"line_number":500,"context_line":"        if os_brick:"},{"line_number":501,"context_line":"            os_brick.setup(CONF)"},{"line_number":502,"context_line":"        # The purpose of this map is to store the connector object for a"},{"line_number":503,"context_line":"        # particular volume as we will need to call os-brick extend_volume"},{"line_number":504,"context_line":"        # method for the kernel to realize the new size change after cinder"}],"source_content_type":"text/x-python","patch_set":4,"id":"4ebc967f_c8bd443a","line":501,"range":{"start_line":501,"start_character":27,"end_line":501,"end_character":31},"in_reply_to":"52b73b05_e414a8ed","updated":"2023-11-15 12:21:00.000000000","message":"Yeah that\u0027s why I updated this logic.","commit_id":"d6205ff3a63c6ac9fdb308d46a2ee99f628086e3"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"1289db3b5640e0f155fe45663bffd567a3765f09","unresolved":true,"context_lines":[{"line_number":524,"context_line":"                reason \u003d _(\"%s is not available.\" % module_name)"},{"line_number":525,"context_line":"                LOG.error(reason)"},{"line_number":526,"context_line":"                raise exceptions.BadStoreConfiguration(store_name\u003d\"cinder\","},{"line_number":527,"context_line":"                                                       reason\u003dreason)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        cinder_volume_type \u003d self.store_conf.cinder_volume_type"},{"line_number":530,"context_line":"        if cinder_volume_type:"}],"source_content_type":"text/x-python","patch_set":4,"id":"2f152bcd_b5f3736b","line":527,"range":{"start_line":527,"start_character":0,"end_line":527,"end_character":55},"updated":"2023-11-14 18:51:25.000000000","message":"The reason we\u0027re doing this here instead of at import level is because we might import this file even when not using the Cinder driver, right?","commit_id":"d6205ff3a63c6ac9fdb308d46a2ee99f628086e3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bb0cf527c66e156d496b235b6701969c37f7ff24","unresolved":false,"context_lines":[{"line_number":524,"context_line":"                reason \u003d _(\"%s is not available.\" % module_name)"},{"line_number":525,"context_line":"                LOG.error(reason)"},{"line_number":526,"context_line":"                raise exceptions.BadStoreConfiguration(store_name\u003d\"cinder\","},{"line_number":527,"context_line":"                                                       reason\u003dreason)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        cinder_volume_type \u003d self.store_conf.cinder_volume_type"},{"line_number":530,"context_line":"        if cinder_volume_type:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5487163e_3a27bc6f","line":527,"range":{"start_line":527,"start_character":0,"end_line":527,"end_character":55},"in_reply_to":"23cfc19e_b21cb15d","updated":"2023-11-15 12:21:00.000000000","message":"I\u0027ve described the same in https://bugs.launchpad.net/glance-store/+bug/2043583 so please let me know in case anything is unclear.","commit_id":"d6205ff3a63c6ac9fdb308d46a2ee99f628086e3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b14c8218f33035fd56e27e67515eb77d92d7a536","unresolved":true,"context_lines":[{"line_number":524,"context_line":"                reason \u003d _(\"%s is not available.\" % module_name)"},{"line_number":525,"context_line":"                LOG.error(reason)"},{"line_number":526,"context_line":"                raise exceptions.BadStoreConfiguration(store_name\u003d\"cinder\","},{"line_number":527,"context_line":"                                                       reason\u003dreason)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        cinder_volume_type \u003d self.store_conf.cinder_volume_type"},{"line_number":530,"context_line":"        if cinder_volume_type:"}],"source_content_type":"text/x-python","patch_set":4,"id":"23cfc19e_b21cb15d","line":527,"range":{"start_line":527,"start_character":0,"end_line":527,"end_character":55},"in_reply_to":"2f152bcd_b5f3736b","updated":"2023-11-15 12:12:15.000000000","message":"No. That is already covered by the existing ImportError fallback .\n\nWhat is being fixed is the timing when missing libraries are detected.\n\nThe current implementation (without this fix) ignores missing os-brock or oslo-privsep when cinder driver is used. These libraries are actually used in some of the logics, but missing libraries are not detected until the libraries are actually called and causes operation errors.\n\nFor example oslo-privsep is used by the _open_cinder_volume method, so in case the oslo-provsep library is missing then a cinder store is initialized without error then any operation requiring data access to cinder volumes fails because of AttributeError.\n\nThis change makes the missing libraries handled at the store initialization to let operators notice their incomplete deployment.","commit_id":"d6205ff3a63c6ac9fdb308d46a2ee99f628086e3"}]}