)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9bb87459fbb25bbc56b9f2b106803b4da10ddbd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bde0b707_2f46cc37","updated":"2025-10-08 08:03:38.000000000","message":"Looks good to me, just one question inline for curiosity","commit_id":"3d55084cde7f30aba2ec41c003242d2762cf4413"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"f5f6dcc7423ef7368e9cc7030be680c580558929","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"508fde8c_dab78a5b","updated":"2025-10-08 14:30:38.000000000","message":"Thanks, I\u0027ll trust you with knowing what the right approach is :)","commit_id":"3d55084cde7f30aba2ec41c003242d2762cf4413"}],"glance_store/_drivers/cinder/store.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9bb87459fbb25bbc56b9f2b106803b4da10ddbd5","unresolved":true,"context_lines":[{"line_number":574,"context_line":"            except exceptions.BackendException as e:"},{"line_number":575,"context_line":"                # \u0027Volume \u003cvol-id\u003e could not be found."},{"line_number":576,"context_line":"                # (HTTP 404) (Request-ID: \u003creq-id\u003e)\u0027"},{"line_number":577,"context_line":"                if \u0027HTTP 404\u0027 in str(e):"},{"line_number":578,"context_line":"                    reason \u003d (_LW(\"Image-Volume %s not found. If you have \""},{"line_number":579,"context_line":"                                  \"upgraded your environment from single \""},{"line_number":580,"context_line":"                                  \"store to multi store, transfer all your \""}],"source_content_type":"text/x-python","patch_set":2,"id":"49a7eaa9_8f9dee2c","line":577,"range":{"start_line":577,"start_character":16,"end_line":577,"end_character":40},"updated":"2025-10-08 08:03:38.000000000","message":"is there any specific reason to check this, I think we should log message and return False without checking for the error code","commit_id":"3d55084cde7f30aba2ec41c003242d2762cf4413"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"06970a192fdae8fcdff33c67fc8ea0eb0cb7f325","unresolved":true,"context_lines":[{"line_number":574,"context_line":"            except exceptions.BackendException as e:"},{"line_number":575,"context_line":"                # \u0027Volume \u003cvol-id\u003e could not be found."},{"line_number":576,"context_line":"                # (HTTP 404) (Request-ID: \u003creq-id\u003e)\u0027"},{"line_number":577,"context_line":"                if \u0027HTTP 404\u0027 in str(e):"},{"line_number":578,"context_line":"                    reason \u003d (_LW(\"Image-Volume %s not found. If you have \""},{"line_number":579,"context_line":"                                  \"upgraded your environment from single \""},{"line_number":580,"context_line":"                                  \"store to multi store, transfer all your \""}],"source_content_type":"text/x-python","patch_set":2,"id":"f0ed3e93_1e0fb1fe","line":577,"range":{"start_line":577,"start_character":16,"end_line":577,"end_character":40},"in_reply_to":"49a7eaa9_8f9dee2c","updated":"2025-10-08 13:50:05.000000000","message":"The reason for this check is preserving the old behavior.\nSo the @handle_exceptions decorator in volume_api.get method can raise BackendException for the following cases.\n\n    keystone_exc.NotFound,\n    cinder_exception.NotFound,\n    cinder_exception.OverLimit\n\nWe can only can provide info about one i.e. Cinder\u0027s NotFound where we feel a volume transfer is needed otherwise the NotFound is confusing in itself.\nProbably you are right that we will only get Cinder\u0027s NotFound here but I\u0027m not sure about the other two happening here but my idea was to handle the cinder_exception.NotFound as we did before.","commit_id":"3d55084cde7f30aba2ec41c003242d2762cf4413"}]}