)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e1956d511bd48d79ce5e65609b806c5e2f78a832","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d7579504_fbcfd57c","updated":"2025-10-08 08:16:37.000000000","message":"Looks good, just one suggestion inline if we need another PS","commit_id":"915dffabc19493e0116cd2bf79c8b4f4dd47c9a3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f3fb18d143ee06b0a145b7f8b2687ff97978017f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"611a9dbe_02a24536","updated":"2025-10-06 09:33:05.000000000","message":"recheck build-openstack-releasenotes ran into POST_FAILURE and glance_store-src-ceph-tempest timed out","commit_id":"915dffabc19493e0116cd2bf79c8b4f4dd47c9a3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f9246fbb44ab0160963e790414d314845dc1b5bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1cfab16c_e414b1d7","updated":"2025-10-09 05:32:06.000000000","message":"recheck dependency merged","commit_id":"915dffabc19493e0116cd2bf79c8b4f4dd47c9a3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b5a6fae4acda0441eb301e8c9b8b99d1c01613bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"10adc171_b23ea0ba","updated":"2025-10-09 07:32:23.000000000","message":"recheck glance_store-src-ceph-tempest POST_FAILURE","commit_id":"915dffabc19493e0116cd2bf79c8b4f4dd47c9a3"}],"glance_store/_drivers/cinder/store.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e1956d511bd48d79ce5e65609b806c5e2f78a832","unresolved":true,"context_lines":[{"line_number":747,"context_line":"                should_disconnect \u003d True"},{"line_number":748,"context_line":"            else:"},{"line_number":749,"context_line":"                # Counting number of attachments on this host"},{"line_number":750,"context_line":"                conn_count \u003d 0"},{"line_number":751,"context_line":"                volume \u003d self.volume_api.get(client, volume_id)"},{"line_number":752,"context_line":"                attachments \u003d volume.attachments"},{"line_number":753,"context_line":"                # When connections are \u003c\u003d 1, we should disconnect"},{"line_number":754,"context_line":"                if len(attachments) \u003e 1:"},{"line_number":755,"context_line":"                    for attachment in attachments:"},{"line_number":756,"context_line":"                        if attachment[\u0027host_name\u0027] \u003d\u003d host:"},{"line_number":757,"context_line":"                            conn_count +\u003d 1"},{"line_number":758,"context_line":"                # If we have more than 1 attachment on the same host,"},{"line_number":759,"context_line":"                # we should not disconnect otherwise we can safely disconnect"},{"line_number":760,"context_line":"                if conn_count \u003c\u003d 1:"},{"line_number":761,"context_line":"                    should_disconnect \u003d True"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"            if should_disconnect:"},{"line_number":764,"context_line":"                if device:"}],"source_content_type":"text/x-python","patch_set":6,"id":"e05a4995_6e48760a","line":761,"range":{"start_line":750,"start_character":16,"end_line":761,"end_character":44},"updated":"2025-10-08 08:16:37.000000000","message":"I think we can simplify this like;\n\n```\n            attachment_count_on_host \u003d sum(\n                for att in attachments if att[\u0027host_name\u0027] \u003d\u003d host\n            )\n            if attachment_count_on_host \u003c\u003d 1:\n                should_disconnect \u003d True\n```","commit_id":"915dffabc19493e0116cd2bf79c8b4f4dd47c9a3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8de6951d78195ee0db2674b067f77bf1bec4ce44","unresolved":true,"context_lines":[{"line_number":747,"context_line":"                should_disconnect \u003d True"},{"line_number":748,"context_line":"            else:"},{"line_number":749,"context_line":"                # Counting number of attachments on this host"},{"line_number":750,"context_line":"                conn_count \u003d 0"},{"line_number":751,"context_line":"                volume \u003d self.volume_api.get(client, volume_id)"},{"line_number":752,"context_line":"                attachments \u003d volume.attachments"},{"line_number":753,"context_line":"                # When connections are \u003c\u003d 1, we should disconnect"},{"line_number":754,"context_line":"                if len(attachments) \u003e 1:"},{"line_number":755,"context_line":"                    for attachment in attachments:"},{"line_number":756,"context_line":"                        if attachment[\u0027host_name\u0027] \u003d\u003d host:"},{"line_number":757,"context_line":"                            conn_count +\u003d 1"},{"line_number":758,"context_line":"                # If we have more than 1 attachment on the same host,"},{"line_number":759,"context_line":"                # we should not disconnect otherwise we can safely disconnect"},{"line_number":760,"context_line":"                if conn_count \u003c\u003d 1:"},{"line_number":761,"context_line":"                    should_disconnect \u003d True"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"            if should_disconnect:"},{"line_number":764,"context_line":"                if device:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a0dfadb_1a1b4e93","line":761,"range":{"start_line":750,"start_character":16,"end_line":761,"end_character":44},"in_reply_to":"e05a4995_6e48760a","updated":"2025-10-08 13:52:57.000000000","message":"Thanks for the review, since the suggestion doesn\u0027t impact functionality of the change, I will address it if we need a new revision. (otherwise will have to test the workflow again 😞)","commit_id":"915dffabc19493e0116cd2bf79c8b4f4dd47c9a3"}]}