)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"d0df5253ec25851bc0f546ee822168969b159b64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"efa1b397_93bc9a04","updated":"2025-12-08 15:25:35.000000000","message":"Can you link to the docs about this feature?","commit_id":"be9bb9f97fc3cba8cf6f1928fdfb45a79d41937a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"45ce603fa18d1d261530c31613e7709791f25d18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0b9c9e49_5f49a159","updated":"2025-12-05 13:26:22.000000000","message":"Hi Max,\n\nThis is a valuable enhancement. I would recommend that you consider providing a brief specification or rationale [1] outlining the need for this change, as it can help others better understand the context. Typically, we prefer that features or enhancements be proposed through formal proposals rather than directly.\nThank you for your understanding.\n\n[1] https://github.com/openstack/glance-specs/blob/master/specs/spec-lite-template.rst","commit_id":"be9bb9f97fc3cba8cf6f1928fdfb45a79d41937a"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"dab402902772a928440c18256f80ceb45c4cc1c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3638570e_a8124990","in_reply_to":"0b9c9e49_5f49a159","updated":"2025-12-08 15:22:09.000000000","message":"Hi Abhishek,\n\nthx for the feedback.\nI have created a spec-lite for that topic which covers the glance-store and python-glanceclient implementation:\nhttps://review.opendev.org/c/openstack/glance-specs/+/970136\n\nI have added it to the 2026.1 spec list, which I believe is the correct process.","commit_id":"be9bb9f97fc3cba8cf6f1928fdfb45a79d41937a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0e23e103f95a002557a3b973d6a902c8f21ce426","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"23ada9c2_fa33fb4e","updated":"2026-11-10 18:12:24.000000000","message":"Thank you, most of the code looks good, one inline comment about behavioral change and rest are related to improvements.","commit_id":"f929c75762dc6d19a7386f773515608b9ad477c5"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"d4c1b495b8a50c99c79bc8096c18363c4c351712","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9fe68c8a_e05e7ea3","updated":"2026-11-12 15:42:05.000000000","message":"Looks good except for a small nitpick, so I\u0027m not holding this patch.","commit_id":"bdd7e3cc9b680020d05609625281180857766807"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c50349bdb7f40fa64b292bd4309ed93c18324557","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c3e1bd4a_b178f128","updated":"2026-11-12 09:38:27.000000000","message":"Minor nit if another patch is needed, also close all addressed review comments.","commit_id":"bdd7e3cc9b680020d05609625281180857766807"}],"glance_store/_drivers/s3.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"d0df5253ec25851bc0f546ee822168969b159b64","unresolved":true,"context_lines":[{"line_number":562,"context_line":"                end_byte \u003d offset + chunk_size - 1"},{"line_number":563,"context_line":"                return f\u0027bytes\u003d{offset}-{end_byte}\u0027"},{"line_number":564,"context_line":"            else:"},{"line_number":565,"context_line":"                return f\u0027bytes\u003d{offset}-\u0027"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        key \u003d s3_client.get_object("},{"line_number":568,"context_line":"            Bucket\u003dbucket, Key\u003dkey, Range\u003d_get_range_header(offset, chunk_size)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f2d75097_fb4fa98a","line":565,"range":{"start_line":565,"start_character":30,"end_line":565,"end_character":31},"updated":"2025-12-08 15:25:35.000000000","message":"So, I think here we would either keep this helper function but move it out of the get() method, or we\u0027d just keep the if/else without a surrounding function.","commit_id":"be9bb9f97fc3cba8cf6f1928fdfb45a79d41937a"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"286a21ffdd019b6a067ac70e44400f756bb4e979","unresolved":false,"context_lines":[{"line_number":562,"context_line":"                end_byte \u003d offset + chunk_size - 1"},{"line_number":563,"context_line":"                return f\u0027bytes\u003d{offset}-{end_byte}\u0027"},{"line_number":564,"context_line":"            else:"},{"line_number":565,"context_line":"                return f\u0027bytes\u003d{offset}-\u0027"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        key \u003d s3_client.get_object("},{"line_number":568,"context_line":"            Bucket\u003dbucket, Key\u003dkey, Range\u003d_get_range_header(offset, chunk_size)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a4772684_1af3c7da","line":565,"range":{"start_line":565,"start_character":30,"end_line":565,"end_character":31},"in_reply_to":"a87d00c6_a30a17e1","updated":"2026-11-12 09:56:54.000000000","message":"Marked as resolved.","commit_id":"be9bb9f97fc3cba8cf6f1928fdfb45a79d41937a"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"3ab94000fe7be98eebb3ad2068773e8775e79fcc","unresolved":true,"context_lines":[{"line_number":562,"context_line":"                end_byte \u003d offset + chunk_size - 1"},{"line_number":563,"context_line":"                return f\u0027bytes\u003d{offset}-{end_byte}\u0027"},{"line_number":564,"context_line":"            else:"},{"line_number":565,"context_line":"                return f\u0027bytes\u003d{offset}-\u0027"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        key \u003d s3_client.get_object("},{"line_number":568,"context_line":"            Bucket\u003dbucket, Key\u003dkey, Range\u003d_get_range_header(offset, chunk_size)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a87d00c6_a30a17e1","line":565,"range":{"start_line":565,"start_character":30,"end_line":565,"end_character":31},"in_reply_to":"f2d75097_fb4fa98a","updated":"2025-12-08 16:17:51.000000000","message":"Hi Cyril, I moved it to a dedicated method.","commit_id":"be9bb9f97fc3cba8cf6f1928fdfb45a79d41937a"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"729ce5d8daa7bc004014919d8711147eeb4fc43f","unresolved":true,"context_lines":[{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    @staticmethod"},{"line_number":542,"context_line":"    def _get_range_header(offset, chunk_size):"},{"line_number":543,"context_line":"        \"\"\"Create Range header for partial content requests."},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"        :param offset: Starting byte position"},{"line_number":546,"context_line":"        :param chunk_size: Number of bytes to read (None for read to end)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e8e118fd_8c2b708a","line":543,"range":{"start_line":543,"start_character":35,"end_line":543,"end_character":42},"updated":"2025-12-08 16:29:45.000000000","message":"Could we have a link to the documentation for this feature here? (and maybe also in the commit message)","commit_id":"3c2247a5fc909c3b2bb1f44fbffb8f0c2de491b7"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"286a21ffdd019b6a067ac70e44400f756bb4e979","unresolved":false,"context_lines":[{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    @staticmethod"},{"line_number":542,"context_line":"    def _get_range_header(offset, chunk_size):"},{"line_number":543,"context_line":"        \"\"\"Create Range header for partial content requests."},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"        :param offset: Starting byte position"},{"line_number":546,"context_line":"        :param chunk_size: Number of bytes to read (None for read to end)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ecace947_1ba51ddf","line":543,"range":{"start_line":543,"start_character":35,"end_line":543,"end_character":42},"in_reply_to":"9664d189_5eb5dc60","updated":"2026-11-12 09:56:54.000000000","message":"Marked as resolved.","commit_id":"3c2247a5fc909c3b2bb1f44fbffb8f0c2de491b7"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"d95506afd7987dcc9edb46b0842493d19b45bcb0","unresolved":true,"context_lines":[{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    @staticmethod"},{"line_number":542,"context_line":"    def _get_range_header(offset, chunk_size):"},{"line_number":543,"context_line":"        \"\"\"Create Range header for partial content requests."},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"        :param offset: Starting byte position"},{"line_number":546,"context_line":"        :param chunk_size: Number of bytes to read (None for read to end)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9664d189_5eb5dc60","line":543,"range":{"start_line":543,"start_character":35,"end_line":543,"end_character":42},"in_reply_to":"e8e118fd_8c2b708a","updated":"2025-12-09 10:07:04.000000000","message":"I added a link (https://www.rfc-editor.org/rfc/rfc9110.html#name-range-requests) to the method description and also to the commit msg","commit_id":"3c2247a5fc909c3b2bb1f44fbffb8f0c2de491b7"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0e23e103f95a002557a3b973d6a902c8f21ce426","unresolved":true,"context_lines":[{"line_number":391,"context_line":"    \"\"\"An implementation of the s3 adapter.\"\"\""},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    _CAPABILITIES \u003d (capabilities.BitMasks.RW_ACCESS |"},{"line_number":394,"context_line":"                     capabilities.BitMasks.READ_OFFSET |"},{"line_number":395,"context_line":"                     capabilities.BitMasks.READ_CHUNK)"},{"line_number":396,"context_line":"    OPTIONS \u003d _S3_OPTS"},{"line_number":397,"context_line":"    EXAMPLE_URL \u003d \"s3://\u003cACCESS_KEY\u003e:\u003cSECRET_KEY\u003e@\u003cS3_URL\u003e/\u003cBUCKET\u003e/\u003cOBJ\u003e\""},{"line_number":398,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fed2d15f_86b1f83c","line":395,"range":{"start_line":394,"start_character":21,"end_line":395,"end_character":53},"updated":"2026-11-10 18:12:24.000000000","message":"use READ_RANDOM instead of READ_OFFSET | READ_CHUNK.","commit_id":"6bf11d3f0fb64cfd4fc8dc93224bf419916ecfbb"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"286a21ffdd019b6a067ac70e44400f756bb4e979","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    \"\"\"An implementation of the s3 adapter.\"\"\""},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    _CAPABILITIES \u003d (capabilities.BitMasks.RW_ACCESS |"},{"line_number":394,"context_line":"                     capabilities.BitMasks.READ_OFFSET |"},{"line_number":395,"context_line":"                     capabilities.BitMasks.READ_CHUNK)"},{"line_number":396,"context_line":"    OPTIONS \u003d _S3_OPTS"},{"line_number":397,"context_line":"    EXAMPLE_URL \u003d \"s3://\u003cACCESS_KEY\u003e:\u003cSECRET_KEY\u003e@\u003cS3_URL\u003e/\u003cBUCKET\u003e/\u003cOBJ\u003e\""},{"line_number":398,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"78f92899_a58ac895","line":395,"range":{"start_line":394,"start_character":21,"end_line":395,"end_character":53},"in_reply_to":"fed2d15f_86b1f83c","updated":"2026-11-12 09:56:54.000000000","message":"Done","commit_id":"6bf11d3f0fb64cfd4fc8dc93224bf419916ecfbb"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0e23e103f95a002557a3b973d6a902c8f21ce426","unresolved":true,"context_lines":[{"line_number":625,"context_line":"        :returns: Range header string (e.g. \u0027bytes\u003d0-1023\u0027 or \u0027bytes\u003d1024-\u0027)"},{"line_number":626,"context_line":"                  or None if full read"},{"line_number":627,"context_line":"        \"\"\""},{"line_number":628,"context_line":"        if offset \u003d\u003d 0 and chunk_size is None:"},{"line_number":629,"context_line":"            return None"},{"line_number":630,"context_line":"        if chunk_size is not None:"},{"line_number":631,"context_line":"            return f\u0027bytes\u003d{offset}-{offset + chunk_size - 1}\u0027"},{"line_number":632,"context_line":"        return f\u0027bytes\u003d{offset}-\u0027"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"    @capabilities.check"},{"line_number":635,"context_line":"    def get(self, location, offset\u003d0, chunk_size\u003dNone, context\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5288fb5c_99012015","line":632,"range":{"start_line":628,"start_character":0,"end_line":632,"end_character":32},"updated":"2026-11-10 18:12:24.000000000","message":"Can be simplified like;\n\n```\nif chunk_size is None:\n    return None if offset \u003d\u003d 0 else f\u0027bytes\u003d{offset}-\u0027\n\nreturn f\u0027bytes\u003d{offset}-{offset + chunk_size - 1}\n```","commit_id":"f929c75762dc6d19a7386f773515608b9ad477c5"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"286a21ffdd019b6a067ac70e44400f756bb4e979","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        :returns: Range header string (e.g. \u0027bytes\u003d0-1023\u0027 or \u0027bytes\u003d1024-\u0027)"},{"line_number":626,"context_line":"                  or None if full read"},{"line_number":627,"context_line":"        \"\"\""},{"line_number":628,"context_line":"        if offset \u003d\u003d 0 and chunk_size is None:"},{"line_number":629,"context_line":"            return None"},{"line_number":630,"context_line":"        if chunk_size is not None:"},{"line_number":631,"context_line":"            return f\u0027bytes\u003d{offset}-{offset + chunk_size - 1}\u0027"},{"line_number":632,"context_line":"        return f\u0027bytes\u003d{offset}-\u0027"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"    @capabilities.check"},{"line_number":635,"context_line":"    def get(self, location, offset\u003d0, chunk_size\u003dNone, context\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ed56ada5_b42fbd62","line":632,"range":{"start_line":628,"start_character":0,"end_line":632,"end_character":32},"in_reply_to":"5288fb5c_99012015","updated":"2026-11-12 09:56:54.000000000","message":"Done","commit_id":"f929c75762dc6d19a7386f773515608b9ad477c5"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0e23e103f95a002557a3b973d6a902c8f21ce426","unresolved":true,"context_lines":[{"line_number":662,"context_line":"            status_code \u003d e.response.get(\u0027ResponseMetadata\u0027,"},{"line_number":663,"context_line":"                                         {}).get(\u0027HTTPStatusCode\u0027)"},{"line_number":664,"context_line":"            error_code \u003d e.response.get(\u0027Error\u0027, {}).get(\u0027Code\u0027)"},{"line_number":665,"context_line":"            if error_code \u003d\u003d \u0027InvalidRange\u0027 or status_code \u003d\u003d 416:"},{"line_number":666,"context_line":"                raise exceptions.Invalid("},{"line_number":667,"context_line":"                    _(\"The requested range is not satisfiable.\"))"},{"line_number":668,"context_line":"            raise"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        LOG.debug(\"Retrieved image object from S3 using s3_host\u003d%(s3_host)s, \""}],"source_content_type":"text/x-python","patch_set":4,"id":"24101f3e_658cda3f","line":667,"range":{"start_line":665,"start_character":0,"end_line":667,"end_character":65},"updated":"2026-11-10 18:12:24.000000000","message":"This should limit 416 handling to actual range requests. Otherwise, a backend 416 during a full-object GET would be translated to Invalid, changing existing behavior.\n```\nif range_header and (error_code \u003d\u003d \u0027InvalidRange\u0027 or status_code \u003d\u003d 416):\n    raise exceptions.Invalid(_(\"The requested range is not satisfiable.\"))\n```","commit_id":"f929c75762dc6d19a7386f773515608b9ad477c5"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"286a21ffdd019b6a067ac70e44400f756bb4e979","unresolved":false,"context_lines":[{"line_number":662,"context_line":"            status_code \u003d e.response.get(\u0027ResponseMetadata\u0027,"},{"line_number":663,"context_line":"                                         {}).get(\u0027HTTPStatusCode\u0027)"},{"line_number":664,"context_line":"            error_code \u003d e.response.get(\u0027Error\u0027, {}).get(\u0027Code\u0027)"},{"line_number":665,"context_line":"            if error_code \u003d\u003d \u0027InvalidRange\u0027 or status_code \u003d\u003d 416:"},{"line_number":666,"context_line":"                raise exceptions.Invalid("},{"line_number":667,"context_line":"                    _(\"The requested range is not satisfiable.\"))"},{"line_number":668,"context_line":"            raise"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        LOG.debug(\"Retrieved image object from S3 using s3_host\u003d%(s3_host)s, \""}],"source_content_type":"text/x-python","patch_set":4,"id":"a5bfeced_5a6b8467","line":667,"range":{"start_line":665,"start_character":0,"end_line":667,"end_character":65},"in_reply_to":"24101f3e_658cda3f","updated":"2026-11-12 09:56:54.000000000","message":"Done","commit_id":"f929c75762dc6d19a7386f773515608b9ad477c5"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0e23e103f95a002557a3b973d6a902c8f21ce426","unresolved":true,"context_lines":[{"line_number":665,"context_line":"            if error_code \u003d\u003d \u0027InvalidRange\u0027 or status_code \u003d\u003d 416:"},{"line_number":666,"context_line":"                raise exceptions.Invalid("},{"line_number":667,"context_line":"                    _(\"The requested range is not satisfiable.\"))"},{"line_number":668,"context_line":"            raise"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        LOG.debug(\"Retrieved image object from S3 using s3_host\u003d%(s3_host)s, \""},{"line_number":671,"context_line":"                  \"bucket\u003d%(bucket)s key\u003d%(key)s)\","}],"source_content_type":"text/x-python","patch_set":4,"id":"838c7ddf_575db87a","line":668,"updated":"2026-11-10 18:12:24.000000000","message":"Also add tests for both paths: a ranged request returning HTTP 416 should raise Invalid, while a full-object GET returning 416 should propagate the original Boto error unchanged. This proves the new translation is limited to ranged requests.","commit_id":"f929c75762dc6d19a7386f773515608b9ad477c5"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"286a21ffdd019b6a067ac70e44400f756bb4e979","unresolved":false,"context_lines":[{"line_number":665,"context_line":"            if error_code \u003d\u003d \u0027InvalidRange\u0027 or status_code \u003d\u003d 416:"},{"line_number":666,"context_line":"                raise exceptions.Invalid("},{"line_number":667,"context_line":"                    _(\"The requested range is not satisfiable.\"))"},{"line_number":668,"context_line":"            raise"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        LOG.debug(\"Retrieved image object from S3 using s3_host\u003d%(s3_host)s, \""},{"line_number":671,"context_line":"                  \"bucket\u003d%(bucket)s key\u003d%(key)s)\","}],"source_content_type":"text/x-python","patch_set":4,"id":"7067d02b_dbe8a2fb","line":668,"in_reply_to":"838c7ddf_575db87a","updated":"2026-11-12 09:56:54.000000000","message":"Done","commit_id":"f929c75762dc6d19a7386f773515608b9ad477c5"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"d4c1b495b8a50c99c79bc8096c18363c4c351712","unresolved":true,"context_lines":[{"line_number":626,"context_line":"                  or None if full read"},{"line_number":627,"context_line":"        \"\"\""},{"line_number":628,"context_line":"        if chunk_size is None:"},{"line_number":629,"context_line":"            return None if offset \u003d\u003d 0 else f\u0027bytes\u003d{offset}-\u0027"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"        return f\u0027bytes\u003d{offset}-{offset + chunk_size - 1}\u0027"},{"line_number":632,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1243a0aa_225618c4","line":629,"range":{"start_line":629,"start_character":12,"end_line":629,"end_character":18},"updated":"2026-11-12 15:42:05.000000000","message":"Ideally we could have run more checks on the inputs here: what if one of the parameters is a negative number, for instance? But in the end, the client will scream at us, so it feels ok and we could even have a follow up patch if necessary.","commit_id":"bdd7e3cc9b680020d05609625281180857766807"}],"glance_store/tests/unit/test_s3_store_base.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0e23e103f95a002557a3b973d6a902c8f21ce426","unresolved":true,"context_lines":[{"line_number":813,"context_line":"    def _test_partial_get(self):"},{"line_number":814,"context_line":"        \"\"\"Test a \"partial\" retrieval of an image in chunks.\"\"\""},{"line_number":815,"context_line":"        bucket, key \u003d \u0027glance\u0027, str(uuid.uuid4())"},{"line_number":816,"context_line":"        fixture_object \u003d {"},{"line_number":817,"context_line":"            \u0027Body\u0027: io.BytesIO(b\"*\" * 5),"},{"line_number":818,"context_line":"            \u0027ContentLength\u0027: 5"},{"line_number":819,"context_line":"        }"},{"line_number":820,"context_line":"        fake_s3_client \u003d botocore.session.get_session().create_client(\u0027s3\u0027)"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"        with stub.Stubber(fake_s3_client) as stubber:"}],"source_content_type":"text/x-python","patch_set":4,"id":"43849b6a_c55630fb","line":819,"range":{"start_line":816,"start_character":0,"end_line":819,"end_character":9},"updated":"2026-11-10 18:12:24.000000000","message":"Please add ContentRange and ResponseMetadata: {\u0027HTTPStatusCode\u0027: 206} for both bounded and offset-only reads.","commit_id":"f929c75762dc6d19a7386f773515608b9ad477c5"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"286a21ffdd019b6a067ac70e44400f756bb4e979","unresolved":false,"context_lines":[{"line_number":813,"context_line":"    def _test_partial_get(self):"},{"line_number":814,"context_line":"        \"\"\"Test a \"partial\" retrieval of an image in chunks.\"\"\""},{"line_number":815,"context_line":"        bucket, key \u003d \u0027glance\u0027, str(uuid.uuid4())"},{"line_number":816,"context_line":"        fixture_object \u003d {"},{"line_number":817,"context_line":"            \u0027Body\u0027: io.BytesIO(b\"*\" * 5),"},{"line_number":818,"context_line":"            \u0027ContentLength\u0027: 5"},{"line_number":819,"context_line":"        }"},{"line_number":820,"context_line":"        fake_s3_client \u003d botocore.session.get_session().create_client(\u0027s3\u0027)"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"        with stub.Stubber(fake_s3_client) as stubber:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dde00137_6332a864","line":819,"range":{"start_line":816,"start_character":0,"end_line":819,"end_character":9},"in_reply_to":"43849b6a_c55630fb","updated":"2026-11-12 09:56:54.000000000","message":"Done","commit_id":"f929c75762dc6d19a7386f773515608b9ad477c5"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0e23e103f95a002557a3b973d6a902c8f21ce426","unresolved":true,"context_lines":[{"line_number":859,"context_line":"                self.assertEqual(expected_data, data)"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"        # Test partial get with offset only (chunk_size\u003dNone)"},{"line_number":862,"context_line":"        fixture_offset_only \u003d {"},{"line_number":863,"context_line":"            \u0027Body\u0027: io.BytesIO(b\"*\" * 10),"},{"line_number":864,"context_line":"            \u0027ContentLength\u0027: 10"},{"line_number":865,"context_line":"        }"},{"line_number":866,"context_line":"        with stub.Stubber(fake_s3_client) as stubber:"},{"line_number":867,"context_line":"            stubber.add_response(method\u003d\u0027head_object\u0027,"},{"line_number":868,"context_line":"                                 service_response\u003d{},"}],"source_content_type":"text/x-python","patch_set":4,"id":"0cbb62bb_f2f2a376","line":865,"range":{"start_line":862,"start_character":0,"end_line":865,"end_character":9},"updated":"2026-11-10 18:12:24.000000000","message":"Please add ContentRange and ResponseMetadata: {\u0027HTTPStatusCode\u0027: 206} for both bounded and offset-only reads.","commit_id":"f929c75762dc6d19a7386f773515608b9ad477c5"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"286a21ffdd019b6a067ac70e44400f756bb4e979","unresolved":false,"context_lines":[{"line_number":859,"context_line":"                self.assertEqual(expected_data, data)"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"        # Test partial get with offset only (chunk_size\u003dNone)"},{"line_number":862,"context_line":"        fixture_offset_only \u003d {"},{"line_number":863,"context_line":"            \u0027Body\u0027: io.BytesIO(b\"*\" * 10),"},{"line_number":864,"context_line":"            \u0027ContentLength\u0027: 10"},{"line_number":865,"context_line":"        }"},{"line_number":866,"context_line":"        with stub.Stubber(fake_s3_client) as stubber:"},{"line_number":867,"context_line":"            stubber.add_response(method\u003d\u0027head_object\u0027,"},{"line_number":868,"context_line":"                                 service_response\u003d{},"}],"source_content_type":"text/x-python","patch_set":4,"id":"add9999f_826e89ff","line":865,"range":{"start_line":862,"start_character":0,"end_line":865,"end_character":9},"in_reply_to":"0cbb62bb_f2f2a376","updated":"2026-11-12 09:56:54.000000000","message":"Done","commit_id":"f929c75762dc6d19a7386f773515608b9ad477c5"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0e23e103f95a002557a3b973d6a902c8f21ce426","unresolved":true,"context_lines":[{"line_number":916,"context_line":"                                     \u0027Bucket\u0027: bucket,"},{"line_number":917,"context_line":"                                     \u0027Key\u0027: key"},{"line_number":918,"context_line":"                                 })"},{"line_number":919,"context_line":"            stubber.add_client_error("},{"line_number":920,"context_line":"                method\u003d\u0027get_object\u0027,"},{"line_number":921,"context_line":"                service_error_code\u003d\u0027InvalidRange\u0027,"},{"line_number":922,"context_line":"                service_message\u003d\u0027The requested range is not satisfiable\u0027,"},{"line_number":923,"context_line":"                http_status_code\u003d416,"},{"line_number":924,"context_line":"                expected_params\u003d{"},{"line_number":925,"context_line":"                    \u0027Bucket\u0027: bucket,"},{"line_number":926,"context_line":"                    \u0027Key\u0027: key,"},{"line_number":927,"context_line":"                    \u0027Range\u0027: \u0027bytes\u003d1000-1004\u0027"},{"line_number":928,"context_line":"                }"},{"line_number":929,"context_line":"            )"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"            with mock.patch.object(boto3.session.Session,"},{"line_number":932,"context_line":"                                   \"client\") as mock_client:"},{"line_number":933,"context_line":"                mock_client.return_value \u003d fake_s3_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ef90475_8f5c8a4d","line":930,"range":{"start_line":919,"start_character":12,"end_line":930,"end_character":0},"updated":"2026-11-10 18:12:24.000000000","message":"Please also test the HTTP 416 path without InvalidRange; this test only covers the error-code path.","commit_id":"f929c75762dc6d19a7386f773515608b9ad477c5"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"286a21ffdd019b6a067ac70e44400f756bb4e979","unresolved":false,"context_lines":[{"line_number":916,"context_line":"                                     \u0027Bucket\u0027: bucket,"},{"line_number":917,"context_line":"                                     \u0027Key\u0027: key"},{"line_number":918,"context_line":"                                 })"},{"line_number":919,"context_line":"            stubber.add_client_error("},{"line_number":920,"context_line":"                method\u003d\u0027get_object\u0027,"},{"line_number":921,"context_line":"                service_error_code\u003d\u0027InvalidRange\u0027,"},{"line_number":922,"context_line":"                service_message\u003d\u0027The requested range is not satisfiable\u0027,"},{"line_number":923,"context_line":"                http_status_code\u003d416,"},{"line_number":924,"context_line":"                expected_params\u003d{"},{"line_number":925,"context_line":"                    \u0027Bucket\u0027: bucket,"},{"line_number":926,"context_line":"                    \u0027Key\u0027: key,"},{"line_number":927,"context_line":"                    \u0027Range\u0027: \u0027bytes\u003d1000-1004\u0027"},{"line_number":928,"context_line":"                }"},{"line_number":929,"context_line":"            )"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"            with mock.patch.object(boto3.session.Session,"},{"line_number":932,"context_line":"                                   \"client\") as mock_client:"},{"line_number":933,"context_line":"                mock_client.return_value \u003d fake_s3_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"0a757fd5_b99f6cdc","line":930,"range":{"start_line":919,"start_character":12,"end_line":930,"end_character":0},"in_reply_to":"9ef90475_8f5c8a4d","updated":"2026-11-12 09:56:54.000000000","message":"Done","commit_id":"f929c75762dc6d19a7386f773515608b9ad477c5"}],"releasenotes/notes/feat-s3-add-range-capability-abe7a1e25a564be9.yaml":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"d0df5253ec25851bc0f546ee822168969b159b64","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This releases introduces the range request capability for the s3 store driver."},{"line_number":5,"context_line":"    This will allow users to download specific byte ranges of an image. It also can"},{"line_number":6,"context_line":"    improve overall download speeds significantly if a client uses multiple streams "},{"line_number":7,"context_line":"    in parralel for fetching an image. This can improve situations if the s3 backend"},{"line_number":8,"context_line":"    has limited singlestream performance."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a09f3e2_b333b501","line":6,"range":{"start_line":6,"start_character":76,"end_line":6,"end_character":83},"updated":"2025-12-08 15:25:35.000000000","message":"Please remove the trailing whitespace","commit_id":"be9bb9f97fc3cba8cf6f1928fdfb45a79d41937a"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"3ab94000fe7be98eebb3ad2068773e8775e79fcc","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This releases introduces the range request capability for the s3 store driver."},{"line_number":5,"context_line":"    This will allow users to download specific byte ranges of an image. It also can"},{"line_number":6,"context_line":"    improve overall download speeds significantly if a client uses multiple streams "},{"line_number":7,"context_line":"    in parralel for fetching an image. This can improve situations if the s3 backend"},{"line_number":8,"context_line":"    has limited singlestream performance."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4a56c7b0_3b3342e1","line":6,"range":{"start_line":6,"start_character":76,"end_line":6,"end_character":83},"in_reply_to":"7a09f3e2_b333b501","updated":"2025-12-08 16:17:51.000000000","message":"fixed","commit_id":"be9bb9f97fc3cba8cf6f1928fdfb45a79d41937a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0e23e103f95a002557a3b973d6a902c8f21ce426","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    S3 backend has limited single-stream performance. For more details,"},{"line_number":9,"context_line":"    see the unified spec at"},{"line_number":10,"context_line":"    https://review.opendev.org/c/openstack/glance-specs/+/1010854 ."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"af324dae_65b4f146","line":11,"updated":"2026-11-10 18:12:24.000000000","message":"I think better to mention here that ranged downloads bypass the image cache and do not serve from it.","commit_id":"f929c75762dc6d19a7386f773515608b9ad477c5"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"286a21ffdd019b6a067ac70e44400f756bb4e979","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    S3 backend has limited single-stream performance. For more details,"},{"line_number":9,"context_line":"    see the unified spec at"},{"line_number":10,"context_line":"    https://review.opendev.org/c/openstack/glance-specs/+/1010854 ."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c35167fe_f8e6949e","line":11,"in_reply_to":"af324dae_65b4f146","updated":"2026-11-12 09:56:54.000000000","message":"Done","commit_id":"f929c75762dc6d19a7386f773515608b9ad477c5"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c50349bdb7f40fa64b292bd4309ed93c18324557","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    S3 backend has limited single-stream performance. Note that ranged"},{"line_number":9,"context_line":"    downloads bypass the Glance image cache and will neither populate nor"},{"line_number":10,"context_line":"    be served from it. For more details, see the unified spec at"},{"line_number":11,"context_line":"    https://review.opendev.org/c/openstack/glance-specs/+/1010854 ."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6abe82a3_ea992536","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":65},"updated":"2026-11-12 09:38:27.000000000","message":"Replace this with https://specs.openstack.org/openstack/glance-specs/specs/2027.1/approved/glance/s3-multipart-download.html","commit_id":"bdd7e3cc9b680020d05609625281180857766807"},{"author":{"_account_id":35676,"name":"Max","email":"max.lamprecht@digits.schwarz","username":"lamprechtm"},"change_message_id":"286a21ffdd019b6a067ac70e44400f756bb4e979","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    S3 backend has limited single-stream performance. Note that ranged"},{"line_number":9,"context_line":"    downloads bypass the Glance image cache and will neither populate nor"},{"line_number":10,"context_line":"    be served from it. For more details, see the unified spec at"},{"line_number":11,"context_line":"    https://review.opendev.org/c/openstack/glance-specs/+/1010854 ."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6ad38d2f_b9af04db","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":65},"in_reply_to":"6abe82a3_ea992536","updated":"2026-11-12 09:56:54.000000000","message":"Acknowledged","commit_id":"bdd7e3cc9b680020d05609625281180857766807"}]}
