)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"7cb4d74f6076670453d0f5b802ee1f4dab644573","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f8fe0c99_9e656385","updated":"2026-02-04 13:51:33.000000000","message":"Only one issue with this","commit_id":"5660adc783fb3f484ed754306448538c603fd843"}],"glance_store/_drivers/swift/store.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"7cb4d74f6076670453d0f5b802ee1f4dab644573","unresolved":true,"context_lines":[{"line_number":593,"context_line":""},{"line_number":594,"context_line":"    def _load_credentials(self, ref_params, netloc):"},{"line_number":595,"context_line":"        \"\"\"Load and validate credentials from reference parameters.\"\"\""},{"line_number":596,"context_line":"        params \u003d ref_params[netloc]"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"        # Try application credentials first"},{"line_number":599,"context_line":"        app_cred_id \u003d params.get(\u0027application_credential_id\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6b85817b_30370152","line":596,"range":{"start_line":596,"start_character":28,"end_line":596,"end_character":34},"updated":"2026-02-04 13:51:33.000000000","message":"I don\u0027t think either ref_params nor netloc are used anywhere else in this method, so we could have a single parameter, and directly call _load_credentials(ref_params[netloc]).\n\nIt is a bit confusing to have two params, and also violates the principle of least privilege.","commit_id":"5660adc783fb3f484ed754306448538c603fd843"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9c38b49ab4881189269370823775ce0804168328","unresolved":false,"context_lines":[{"line_number":593,"context_line":""},{"line_number":594,"context_line":"    def _load_credentials(self, ref_params, netloc):"},{"line_number":595,"context_line":"        \"\"\"Load and validate credentials from reference parameters.\"\"\""},{"line_number":596,"context_line":"        params \u003d ref_params[netloc]"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"        # Try application credentials first"},{"line_number":599,"context_line":"        app_cred_id \u003d params.get(\u0027application_credential_id\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6015ed23_35a18c3a","line":596,"range":{"start_line":596,"start_character":28,"end_line":596,"end_character":34},"in_reply_to":"6b85817b_30370152","updated":"2026-02-04 14:18:40.000000000","message":"good catch","commit_id":"5660adc783fb3f484ed754306448538c603fd843"}]}