)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"fc8860804f83ad03a8dfd9a9ba892165e22f4152","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fbdddcb1_25157b78","updated":"2026-03-27 15:48:17.000000000","message":"According to my test, this does not solve an issue, when `swift_store_retry_get_count` is set to non-zero value.\n\nIt solves the problem though, when `swift_store_retry_get_count` is not present in the config at all.","commit_id":"51cb7dc30b117dc5487b31b2f930cd74fba276ff"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"642b3c15b788e61b765be0b51eb7040aec9e37d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"98e9c333_315550fe","updated":"2026-03-29 22:44:12.000000000","message":"Need backport in 2026.1","commit_id":"96208a114723380419da0740a41cb91493ee11f9"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"fe168831f07cada9f9eb7ad229f377e1d275ba3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4e992621_c3499f51","updated":"2026-04-01 16:01:37.000000000","message":"Two things:\n\n1) I think the casts to integer are not required, since \"None or 0\" is an integer\n2) I\u0027d like to understand what config files would cause these options to be None. If such config files exist, I\u0027d like to see an example in the commit log.","commit_id":"96208a114723380419da0740a41cb91493ee11f9"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"ee84174dfa717c9be2c58460fb05333730604ea1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b9261483_720aa456","updated":"2026-03-27 21:20:16.000000000","message":"this solves issue for me now, thanks!","commit_id":"96208a114723380419da0740a41cb91493ee11f9"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"bbfe2ae3eafed6ae58bb62f121d42f2211d68c9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"48bf30f4_247cdfde","updated":"2026-04-07 11:52:39.000000000","message":"On IRC, zigo confirmed patchset #2 worked.","commit_id":"f32b259befa85ad8a2ee5948341c8389e445ddd3"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"a5091d5a7ecbdef022a0b667462ef7728730f717","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9e6c7cad_2ee171ad","updated":"2026-04-02 15:11:22.000000000","message":"Thanks!","commit_id":"f32b259befa85ad8a2ee5948341c8389e445ddd3"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"fc840c1c9c4f72844fdbb6a2e901d16aa5390702","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cfcee53f_a3c15f7e","updated":"2026-04-07 20:33:25.000000000","message":"recheck (CI now fine)","commit_id":"f32b259befa85ad8a2ee5948341c8389e445ddd3"}],"glance_store/_drivers/swift/store.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"fe168831f07cada9f9eb7ad229f377e1d275ba3a","unresolved":true,"context_lines":[{"line_number":483,"context_line":"    retries \u003d 0"},{"line_number":484,"context_line":"    bytes_read \u003d 0"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    rcount \u003d int(store.store_conf.swift_store_retry_get_count or 0)"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    while retries \u003c\u003d rcount:"},{"line_number":489,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"f81466d7_a62bae22","line":486,"range":{"start_line":486,"start_character":17,"end_line":486,"end_character":61},"updated":"2026-04-01 16:01:37.000000000","message":"This is already an integer, I think we can saefely remove the cast. The tests still pass when I do.\n\n\nDo we actually need to use \"or 0\" here? We\u0027re basically enforcing the default value. Is there an actual config file that would lead to rcount being None?\n\n    [default_backends]\n    # swift_store_retry_get_count is not used here\n    \n    [swift1]\n    # swift_store_retry_get_count is not used here\n    \nThe above config would give us swift_store_retry_get_count equal to the default value (which is 0), right?","commit_id":"96208a114723380419da0740a41cb91493ee11f9"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"78b13b0966707ad36fb5ce17d399a927802994a8","unresolved":false,"context_lines":[{"line_number":483,"context_line":"    retries \u003d 0"},{"line_number":484,"context_line":"    bytes_read \u003d 0"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    rcount \u003d int(store.store_conf.swift_store_retry_get_count or 0)"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    while retries \u003c\u003d rcount:"},{"line_number":489,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"146f1904_b60231fe","line":486,"range":{"start_line":486,"start_character":17,"end_line":486,"end_character":61},"in_reply_to":"f81466d7_a62bae22","updated":"2026-04-02 06:08:07.000000000","message":"Good catch — updated as suggested.","commit_id":"96208a114723380419da0740a41cb91493ee11f9"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"fe168831f07cada9f9eb7ad229f377e1d275ba3a","unresolved":true,"context_lines":[{"line_number":883,"context_line":"            offset\u003d0, chunk_size\u003dNone, context\u003dNone):"},{"line_number":884,"context_line":"        location \u003d location.store_location"},{"line_number":885,"context_line":"        # initialize manager to receive valid connections"},{"line_number":886,"context_line":"        retry_get_count \u003d int(self.store_conf.swift_store_retry_get_count or 0)"},{"line_number":887,"context_line":"        allow_retry \u003d retry_get_count \u003e 0"},{"line_number":888,"context_line":"        with self.get_manager(location, context,"},{"line_number":889,"context_line":"                              allow_reauth\u003dallow_retry) as manager:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5b4ba4ea_6aab4cdd","line":886,"range":{"start_line":886,"start_character":8,"end_line":886,"end_character":23},"updated":"2026-04-01 16:01:37.000000000","message":"Ditto","commit_id":"96208a114723380419da0740a41cb91493ee11f9"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"78b13b0966707ad36fb5ce17d399a927802994a8","unresolved":false,"context_lines":[{"line_number":883,"context_line":"            offset\u003d0, chunk_size\u003dNone, context\u003dNone):"},{"line_number":884,"context_line":"        location \u003d location.store_location"},{"line_number":885,"context_line":"        # initialize manager to receive valid connections"},{"line_number":886,"context_line":"        retry_get_count \u003d int(self.store_conf.swift_store_retry_get_count or 0)"},{"line_number":887,"context_line":"        allow_retry \u003d retry_get_count \u003e 0"},{"line_number":888,"context_line":"        with self.get_manager(location, context,"},{"line_number":889,"context_line":"                              allow_reauth\u003dallow_retry) as manager:"}],"source_content_type":"text/x-python","patch_set":2,"id":"72f95c8f_9ea2fd98","line":886,"range":{"start_line":886,"start_character":8,"end_line":886,"end_character":23},"in_reply_to":"5b4ba4ea_6aab4cdd","updated":"2026-04-02 06:08:07.000000000","message":"Done","commit_id":"96208a114723380419da0740a41cb91493ee11f9"}]}
