)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"677b81dffa22f1d4b59c037b32161755346b3960","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"82d1f9fd_cb2edb54","updated":"2026-09-22 18:20:12.000000000","message":"This feels like a serious bug, so we probably want to fix it, but the driver is becoming less and less readable, so we will probably need to rewrite parts of it at some point :/ \n\nCould you add a release note?","commit_id":"6c981519875da9a4f05ac103a4303c42a4fbf406"},{"author":{"_account_id":37800,"name":"Sebastian Krott","display_name":"Sebastian Krott","email":"sebastian.krott@sap.com","username":"sebkro_sap"},"change_message_id":"87f914aa34b5062c94906d2d0030814c95c443c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"327f7a16_4f5fcd51","in_reply_to":"82d1f9fd_cb2edb54","updated":"2026-09-23 20:04:04.000000000","message":"Done.","commit_id":"6c981519875da9a4f05ac103a4303c42a4fbf406"}],"glance_store/_drivers/swift/store.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ae9903a0f05a2728d17fcf3f453788bb6f2f5fb5","unresolved":true,"context_lines":[{"line_number":1631,"context_line":"                self.conf, self.backend_group).swift_store_container"},{"line_number":1632,"context_line":"        else:"},{"line_number":1633,"context_line":"            self.container \u003d self.conf.glance_store.swift_store_container"},{"line_number":1634,"context_line":"        self.scheme \u003d None"},{"line_number":1635,"context_line":"        self.storage_url \u003d None"},{"line_number":1636,"context_line":"        self._storage_netloc \u003d None"},{"line_number":1637,"context_line":"        if self.backend_group:"},{"line_number":1638,"context_line":"            self._set_url_prefix()"},{"line_number":1639,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"558603dc_43907b81","line":1636,"range":{"start_line":1634,"start_character":8,"end_line":1636,"end_character":35},"updated":"2026-04-15 08:59:07.000000000","message":"I think you can initilize these before line 1629 and then call self._set_url_prefix() after line 1631 to avoid duplication of if condition","commit_id":"b5a09dd1b1368896c82f225de64250382ea4c22b"},{"author":{"_account_id":37800,"name":"Sebastian Krott","display_name":"Sebastian Krott","email":"sebastian.krott@sap.com","username":"sebkro_sap"},"change_message_id":"edba684f62123cac1017c6faa0dd3af415234d6b","unresolved":false,"context_lines":[{"line_number":1631,"context_line":"                self.conf, self.backend_group).swift_store_container"},{"line_number":1632,"context_line":"        else:"},{"line_number":1633,"context_line":"            self.container \u003d self.conf.glance_store.swift_store_container"},{"line_number":1634,"context_line":"        self.scheme \u003d None"},{"line_number":1635,"context_line":"        self.storage_url \u003d None"},{"line_number":1636,"context_line":"        self._storage_netloc \u003d None"},{"line_number":1637,"context_line":"        if self.backend_group:"},{"line_number":1638,"context_line":"            self._set_url_prefix()"},{"line_number":1639,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a1ea9b67_9036a2a6","line":1636,"range":{"start_line":1634,"start_character":8,"end_line":1636,"end_character":35},"in_reply_to":"558603dc_43907b81","updated":"2026-04-15 17:15:01.000000000","message":"Good point, done.","commit_id":"b5a09dd1b1368896c82f225de64250382ea4c22b"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"677b81dffa22f1d4b59c037b32161755346b3960","unresolved":true,"context_lines":[{"line_number":1746,"context_line":"        # Attempt to resolve self._storage_netloc and self.scheme if unset"},{"line_number":1747,"context_line":"        if not self._storage_netloc or not self.scheme:"},{"line_number":1748,"context_line":"            try:"},{"line_number":1749,"context_line":"                self._get_endpoint(context)"},{"line_number":1750,"context_line":"            except exceptions.BadStoreConfiguration:"},{"line_number":1751,"context_line":"                pass"},{"line_number":1752,"context_line":"        # Validate scheme"}],"source_content_type":"text/x-python","patch_set":2,"id":"1272a4d9_2768b7e6","line":1749,"range":{"start_line":1749,"start_character":34,"end_line":1749,"end_character":35},"updated":"2026-09-22 18:20:12.000000000","message":"So \"matches_uri\" may call _get_endpoint to set the value of self._storage_netloc and self.scheme. I would much rather that matches_uri did not change anything about the state of self. Is there anyway to call _get_endpoint from somewhere else?","commit_id":"6c981519875da9a4f05ac103a4303c42a4fbf406"},{"author":{"_account_id":37800,"name":"Sebastian Krott","display_name":"Sebastian Krott","email":"sebastian.krott@sap.com","username":"sebkro_sap"},"change_message_id":"87f914aa34b5062c94906d2d0030814c95c443c9","unresolved":true,"context_lines":[{"line_number":1746,"context_line":"        # Attempt to resolve self._storage_netloc and self.scheme if unset"},{"line_number":1747,"context_line":"        if not self._storage_netloc or not self.scheme:"},{"line_number":1748,"context_line":"            try:"},{"line_number":1749,"context_line":"                self._get_endpoint(context)"},{"line_number":1750,"context_line":"            except exceptions.BadStoreConfiguration:"},{"line_number":1751,"context_line":"                pass"},{"line_number":1752,"context_line":"        # Validate scheme"}],"source_content_type":"text/x-python","patch_set":2,"id":"89870c04_d711fb6c","line":1749,"range":{"start_line":1749,"start_character":34,"end_line":1749,"end_character":35},"in_reply_to":"1272a4d9_2768b7e6","updated":"2026-09-23 20:04:04.000000000","message":"The issue is that `matches_uri` needs `self.scheme` and `self._storage_netloc` for any meaningful comparison. So `_get_endpoint` would need to be called some point before.\n\nAfaics there is no simple way to accomplish this without larger changes. The most promising candidates seem `init_client` and `configure_add`. \n\nBut the problem with `init_client` is that it might not be called before `matches_uri`, so it does not help.\n\nAnd `configure_add` does not have a context parameter. So it will only help if `conf_endpoint` is defined, i.e. `swift_store_endpoint` is configured.\n\nI suppose the cleanest fix would be passing a proper service user context with `service_catalog` as a parameter to `configure_add` (or some separate store initialization function). But that feels a bit out of scope for this change.","commit_id":"6c981519875da9a4f05ac103a4303c42a4fbf406"}]}