)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"8a9181596939e03b28a33a0f742ff7714881593b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d6f6506c_c17f08bb","updated":"2026-06-18 16:03:52.000000000","message":"Some stylistic itch, otherwise looks good","commit_id":"5d34a9eb6628bed357f0bf32c6e2ebf595c8e2e4"}],"glance_store/_drivers/cinder/store.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"8a9181596939e03b28a33a0f742ff7714881593b","unresolved":true,"context_lines":[{"line_number":649,"context_line":"            self.store_conf.cinder_store_password,"},{"line_number":650,"context_line":"            self.store_conf.cinder_store_project_name"},{"line_number":651,"context_line":"        ]"},{"line_number":652,"context_line":"        all_auth_params_set \u003d all(auth_params)"},{"line_number":653,"context_line":"        endpoint_template_set \u003d self.store_conf.cinder_endpoint_template"},{"line_number":654,"context_line":"        catalog_info \u003d self.store_conf.cinder_catalog_info"},{"line_number":655,"context_line":"        catalog_info_default \u003d \u0027block-storage:cinder:publicURL\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"0696c1d0_79db1d91","line":652,"range":{"start_line":652,"start_character":8,"end_line":652,"end_character":27},"updated":"2026-06-18 16:03:52.000000000","message":"This is not reused so maybe we could use \"if not all(auth_params)\" at line 657.","commit_id":"5d34a9eb6628bed357f0bf32c6e2ebf595c8e2e4"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"8a9181596939e03b28a33a0f742ff7714881593b","unresolved":true,"context_lines":[{"line_number":652,"context_line":"        all_auth_params_set \u003d all(auth_params)"},{"line_number":653,"context_line":"        endpoint_template_set \u003d self.store_conf.cinder_endpoint_template"},{"line_number":654,"context_line":"        catalog_info \u003d self.store_conf.cinder_catalog_info"},{"line_number":655,"context_line":"        catalog_info_default \u003d \u0027block-storage:cinder:publicURL\u0027"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"        if not all_auth_params_set:"},{"line_number":658,"context_line":"            reason \u003d (_LW("}],"source_content_type":"text/x-python","patch_set":3,"id":"fb5b54c0_8854d464","line":655,"range":{"start_line":655,"start_character":8,"end_line":655,"end_character":28},"updated":"2026-06-18 16:03:52.000000000","message":"The above 3 variables are useless if all auth params are set, so only declare them inside the \"if\" block, after logging the warning.","commit_id":"5d34a9eb6628bed357f0bf32c6e2ebf595c8e2e4"}]}