)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"8a9181596939e03b28a33a0f742ff7714881593b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d6f6506c_c17f08bb","updated":"2026-06-18 16:03:52.000000000","message":"Some stylistic itch, otherwise looks good","commit_id":"5d34a9eb6628bed357f0bf32c6e2ebf595c8e2e4"}],"glance_store/_drivers/cinder/store.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"8a9181596939e03b28a33a0f742ff7714881593b","unresolved":true,"context_lines":[{"line_number":649,"context_line":"            self.store_conf.cinder_store_password,"},{"line_number":650,"context_line":"            self.store_conf.cinder_store_project_name"},{"line_number":651,"context_line":"        ]"},{"line_number":652,"context_line":"        all_auth_params_set \u003d all(auth_params)"},{"line_number":653,"context_line":"        endpoint_template_set \u003d self.store_conf.cinder_endpoint_template"},{"line_number":654,"context_line":"        catalog_info \u003d self.store_conf.cinder_catalog_info"},{"line_number":655,"context_line":"        catalog_info_default \u003d \u0027block-storage:cinder:publicURL\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"0696c1d0_79db1d91","line":652,"range":{"start_line":652,"start_character":8,"end_line":652,"end_character":27},"updated":"2026-06-18 16:03:52.000000000","message":"This is not reused so maybe we could use \"if not all(auth_params)\" at line 657.","commit_id":"5d34a9eb6628bed357f0bf32c6e2ebf595c8e2e4"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"8a9181596939e03b28a33a0f742ff7714881593b","unresolved":true,"context_lines":[{"line_number":652,"context_line":"        all_auth_params_set \u003d all(auth_params)"},{"line_number":653,"context_line":"        endpoint_template_set \u003d self.store_conf.cinder_endpoint_template"},{"line_number":654,"context_line":"        catalog_info \u003d self.store_conf.cinder_catalog_info"},{"line_number":655,"context_line":"        catalog_info_default \u003d \u0027block-storage:cinder:publicURL\u0027"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"        if not all_auth_params_set:"},{"line_number":658,"context_line":"            reason \u003d (_LW("}],"source_content_type":"text/x-python","patch_set":3,"id":"fb5b54c0_8854d464","line":655,"range":{"start_line":655,"start_character":8,"end_line":655,"end_character":28},"updated":"2026-06-18 16:03:52.000000000","message":"The above 3 variables are useless if all auth params are set, so only declare them inside the \"if\" block, after logging the warning.","commit_id":"5d34a9eb6628bed357f0bf32c6e2ebf595c8e2e4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d32edb5d724cfe8e4ce4ed5ed102b4c627214a6d","unresolved":true,"context_lines":[{"line_number":657,"context_line":"        if not all_auth_params_set:"},{"line_number":658,"context_line":"            reason \u003d (_LW("},{"line_number":659,"context_line":"                \"Image-Volume will be created in user\u0027s project and not in \""},{"line_number":660,"context_line":"                \"internal tenant since cinder_store_auth_address, \""},{"line_number":661,"context_line":"                \"cinder_store_user_name, cinder_store_password and \""},{"line_number":662,"context_line":"                \"cinder_store_project_name are not set.\"))"},{"line_number":663,"context_line":"            LOG.warning(reason)"}],"source_content_type":"text/x-python","patch_set":3,"id":"326e5594_a8bc9f85","line":660,"range":{"start_line":660,"start_character":26,"end_line":660,"end_character":32},"updated":"2026-09-10 16:46:18.000000000","message":"project","commit_id":"5d34a9eb6628bed357f0bf32c6e2ebf595c8e2e4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d32edb5d724cfe8e4ce4ed5ed102b4c627214a6d","unresolved":true,"context_lines":[{"line_number":664,"context_line":"            # If auth params and endpoint template are not set,"},{"line_number":665,"context_line":"            # check if catalog_info is properly configured"},{"line_number":666,"context_line":"            if (not endpoint_template_set and"},{"line_number":667,"context_line":"                    catalog_info \u003d\u003d catalog_info_default):"},{"line_number":668,"context_line":"                reason \u003d (_LW("},{"line_number":669,"context_line":"                    \"Check Cinder store configuration properly. To avoid 401 \""},{"line_number":670,"context_line":"                    \"and 500 errors, configure one of the following: \""}],"source_content_type":"text/x-python","patch_set":3,"id":"b7db5643_77404256","line":667,"range":{"start_line":667,"start_character":20,"end_line":667,"end_character":56},"updated":"2026-09-10 16:46:18.000000000","message":"I\u0027m unsure if logging a warning when the default value is used is a good practice. The default value is supposed to be sensible in popular deployments.","commit_id":"5d34a9eb6628bed357f0bf32c6e2ebf595c8e2e4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d32edb5d724cfe8e4ce4ed5ed102b4c627214a6d","unresolved":true,"context_lines":[{"line_number":675,"context_line":"                    \"3. cinder_catalog_info (currently set to default \""},{"line_number":676,"context_line":"                    \"value \u0027%s\u0027)\") % catalog_info_default)"},{"line_number":677,"context_line":"                LOG.warning(reason)"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"        cinder_volume_type \u003d self.store_conf.cinder_volume_type"},{"line_number":680,"context_line":"        if cinder_volume_type:"},{"line_number":681,"context_line":"            # NOTE: `cinder_volume_type` is configured, check"}],"source_content_type":"text/x-python","patch_set":3,"id":"4c1845da_0489d552","line":678,"updated":"2026-09-10 16:46:18.000000000","message":"I wonder if we should let the driver hard-fail here (by raising exceptions.BadStoreConfiguration ) , if we know the store may not work really ?\nOperators may not check warnings always.","commit_id":"5d34a9eb6628bed357f0bf32c6e2ebf595c8e2e4"}]}