)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1ba7d82e193b1c3ba5dfb0bd0297b5662a052908","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0358343d_2b6d7851","updated":"2026-05-26 08:22:25.000000000","message":"Looks good few nits inline and a change in releasenote must","commit_id":"36ce544661a6f39fae7e0de8c61fd2164808828a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4dd3353c368c59e8ce735bd516f7a236375177ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d359b434_b2627453","updated":"2026-05-29 06:44:42.000000000","message":"Looks good, thank you very much for descriptive commit message and inline notes!","commit_id":"22e0bb5f8c8dcc31fe28c773323c1a95f2a334f8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"811e3f105176c1e72bfe1e2415392062d8080731","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f5a84a5b_d886219a","updated":"2026-05-26 19:48:34.000000000","message":"Thanks Abhishek!","commit_id":"22e0bb5f8c8dcc31fe28c773323c1a95f2a334f8"}],"glance_store/_drivers/cinder/store.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1ba7d82e193b1c3ba5dfb0bd0297b5662a052908","unresolved":true,"context_lines":[{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        current \u003d self._next"},{"line_number":573,"context_line":"        try:"},{"line_number":574,"context_line":"            self._next \u003d next(self._iterator)"},{"line_number":575,"context_line":"        except StopIteration:"},{"line_number":576,"context_line":"            self._has_next \u003d False"},{"line_number":577,"context_line":"            self.close()"}],"source_content_type":"text/x-python","patch_set":1,"id":"994d294c_4e706566","line":574,"range":{"start_line":574,"start_character":0,"end_line":574,"end_character":2},"updated":"2026-05-26 08:22:25.000000000","message":"nit: if next raises anything other that StopIteration we never call close() and the volume can stay attached. I think better to catch Execption and close it","commit_id":"36ce544661a6f39fae7e0de8c61fd2164808828a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"811e3f105176c1e72bfe1e2415392062d8080731","unresolved":false,"context_lines":[{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        current \u003d self._next"},{"line_number":573,"context_line":"        try:"},{"line_number":574,"context_line":"            self._next \u003d next(self._iterator)"},{"line_number":575,"context_line":"        except StopIteration:"},{"line_number":576,"context_line":"            self._has_next \u003d False"},{"line_number":577,"context_line":"            self.close()"}],"source_content_type":"text/x-python","patch_set":1,"id":"4dadf1a2_d61926d2","line":574,"range":{"start_line":574,"start_character":0,"end_line":574,"end_character":2},"in_reply_to":"994d294c_4e706566","updated":"2026-05-26 19:48:34.000000000","message":"Done","commit_id":"36ce544661a6f39fae7e0de8c61fd2164808828a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1ba7d82e193b1c3ba5dfb0bd0297b5662a052908","unresolved":true,"context_lines":[{"line_number":1030,"context_line":"            iterator \u003d self._cinder_volume_data_iterator("},{"line_number":1031,"context_line":"                client, volume, size, offset\u003doffset,"},{"line_number":1032,"context_line":"                chunk_size\u003dself.READ_CHUNKSIZE, partial_length\u003dchunk_size)"},{"line_number":1033,"context_line":"            volumeIterator \u003d CinderVolumeIterator(iterator)"},{"line_number":1034,"context_line":"            return (volumeIterator, chunk_size or size)"},{"line_number":1035,"context_line":"        except cinder_exception.NotFound:"},{"line_number":1036,"context_line":"            reason \u003d _(\"Failed to get image size due to \""}],"source_content_type":"text/x-python","patch_set":1,"id":"c33954d2_0bd57a00","line":1033,"range":{"start_line":1033,"start_character":12,"end_line":1033,"end_character":26},"updated":"2026-05-26 08:22:25.000000000","message":"nit: should be volume_iterator as we don\u0027t follow this type of standard","commit_id":"36ce544661a6f39fae7e0de8c61fd2164808828a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"811e3f105176c1e72bfe1e2415392062d8080731","unresolved":false,"context_lines":[{"line_number":1030,"context_line":"            iterator \u003d self._cinder_volume_data_iterator("},{"line_number":1031,"context_line":"                client, volume, size, offset\u003doffset,"},{"line_number":1032,"context_line":"                chunk_size\u003dself.READ_CHUNKSIZE, partial_length\u003dchunk_size)"},{"line_number":1033,"context_line":"            volumeIterator \u003d CinderVolumeIterator(iterator)"},{"line_number":1034,"context_line":"            return (volumeIterator, chunk_size or size)"},{"line_number":1035,"context_line":"        except cinder_exception.NotFound:"},{"line_number":1036,"context_line":"            reason \u003d _(\"Failed to get image size due to \""}],"source_content_type":"text/x-python","patch_set":1,"id":"c823ba6d_430df96f","line":1033,"range":{"start_line":1033,"start_character":12,"end_line":1033,"end_character":26},"in_reply_to":"c33954d2_0bd57a00","updated":"2026-05-26 19:48:34.000000000","message":"Done","commit_id":"36ce544661a6f39fae7e0de8c61fd2164808828a"}],"releasenotes/notes/cinder-fix-iterator-close-f919665aa23cfb7d.yaml":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1ba7d82e193b1c3ba5dfb0bd0297b5662a052908","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #2154211 \u003chttps://bugs.launchpad.net/cinder/+bug/2154211\u003e`_:"},{"line_number":5,"context_line":"    Fixed issue with the volume iterator detaching the volume after the"},{"line_number":6,"context_line":"    get image call is finished causing the volume to be in transitional"},{"line_number":7,"context_line":"    state and deletion fails if attempted immediately."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2c075d01_3b148b3a","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":66},"updated":"2026-05-26 08:22:25.000000000","message":"the url should be https://bugs.launchpad.net/glance-store/+bug/2154211","commit_id":"36ce544661a6f39fae7e0de8c61fd2164808828a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"811e3f105176c1e72bfe1e2415392062d8080731","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #2154211 \u003chttps://bugs.launchpad.net/cinder/+bug/2154211\u003e`_:"},{"line_number":5,"context_line":"    Fixed issue with the volume iterator detaching the volume after the"},{"line_number":6,"context_line":"    get image call is finished causing the volume to be in transitional"},{"line_number":7,"context_line":"    state and deletion fails if attempted immediately."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e373c59a_4f0db848","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":66},"in_reply_to":"2c075d01_3b148b3a","updated":"2026-05-26 19:48:34.000000000","message":"Done","commit_id":"36ce544661a6f39fae7e0de8c61fd2164808828a"}]}