)]}'
{"id":"openstack%2Fglance_store~990003","triplet_id":"openstack%2Fglance_store~master~Id1f4d6aae4769a093bce159634557176b90925ac","project":"openstack/glance_store","branch":"master","attention_set":{},"removed_from_attention_set":{"9303":{"account":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"last_update":"2026-05-29 06:44:42.000000000","reason":"\u003cGERRIT_ACCOUNT_9303\u003e replied on the change","reason_account":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}},"27615":{"account":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"last_update":"2026-05-29 07:48:58.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Id1f4d6aae4769a093bce159634557176b90925ac","subject":"Cinder: Fix volume iterator logic","status":"MERGED","created":"2026-05-25 18:34:30.000000000","updated":"2026-05-29 07:50:15.000000000","submitted":"2026-05-29 07:48:58.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"990003","meta_rev_id":"11b59d3bb486b8f0bda9021314fa2c1ae60abb5e","_number":990003,"virtual_id_number":990003,"owner":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-05-29 07:48:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":2,"date":"2026-05-29 06:44:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":1,"date":"2026-05-29 06:44:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-25 20:31:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-05-26 08:22:25.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2026-05-26 12:16:43.000000000","updated_by":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"reviewer":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"state":"CC"}],"messages":[{"id":"bc06cd1134ae737c5482b205a626bb28f77599c6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2026-05-25 18:34:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"466c07e928a5fab826a3640bb0c4975c7f7712f5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-25 20:31:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/bd7be37551d54fd09fa6d435e70cbdd3\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/fea1dd19148b407390bddc72b373f688 : SUCCESS in 1h 51m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e09acb890feb406a9a08779601fa8623 : SUCCESS in 2m 15s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/6b6c7511ebeb447cbcd565c6ba5e4aed : SUCCESS in 4m 05s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/c651d4f981a249bda6859f8cb123e708 : SUCCESS in 4m 22s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/afc8830b28d649a8b6537a90329802b5 : SUCCESS in 5m 32s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/994fd3c0e45b46a8a6d9c32250fdc47f : SUCCESS in 2m 04s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/46e3abdacab746238c2b8a82506db0f4 : SUCCESS in 3m 39s\n- cross-glance-tox-functional https://zuul.opendev.org/t/openstack/build/8912bd4d489f4b3bac014c235f3aff3b : SUCCESS in 4m 51s","accounts_in_message":[],"_revision_number":1},{"id":"1ba7d82e193b1c3ba5dfb0bd0297b5662a052908","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2026-05-26 08:22:25.000000000","message":"Patch Set 1: Code-Review+1\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"70ad9789e099e4e59608cf3eed71ca52ebfb7c18","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2026-05-26 19:47:49.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n* Verified+1 (copy condition: \"NEVER\")\n","accounts_in_message":[],"_revision_number":2},{"id":"811e3f105176c1e72bfe1e2415392062d8080731","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2026-05-26 19:48:34.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"22a06f1add3fc949e07e12af77fab7ccde671e62","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-26 21:42:06.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/0ed80dcb76264f6d92cd05ccd6b816f1\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/d13d1f66ef1940c789c95c3e40263802 : SUCCESS in 1h 49m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2ab92d3770fe422791f115b58cad7161 : SUCCESS in 2m 11s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/5911f452ec414c418d0c7e2162955483 : SUCCESS in 4m 28s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/ae5a55227b5f4994a34685cf8309a38e : SUCCESS in 4m 01s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/c713e234dae64643af68f366f56b4700 : SUCCESS in 6m 31s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d63b437fdcdf4b98b223316ec0f5e74e : SUCCESS in 3m 22s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/8c8604cc00474f17a2736829267b78b8 : SUCCESS in 3m 47s\n- cross-glance-tox-functional https://zuul.opendev.org/t/openstack/build/d0333b1e3b5240479e19b79a9031ace0 : SUCCESS in 4m 49s","accounts_in_message":[],"_revision_number":2},{"id":"4dd3353c368c59e8ce735bd516f7a236375177ff","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2026-05-29 06:44:42.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7083eb3f4022e8d1885e56ee8ceb527d24c2aa53","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-29 06:45:05.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"55d06604b5d18da1abcff1cf9a5fa35a51af991e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-29 07:48:58.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/011c730ed69140d89d18bb345a57fe6b\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/0a07f03ecae54051ae09197489cfe2a4 : SUCCESS in 1h 03m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ce5a0868d8c4448dbb61539e5f54399a : SUCCESS in 3m 23s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/8506b115271c4166bd5a0a2aac37988a : SUCCESS in 2m 28s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/a3bcbfb8027644219491daec944a5642 : SUCCESS in 3m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ebed6a5acfc7436c81cbf2ea91208cf2 : SUCCESS in 3m 09s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/837da717f977464b852721d9405d4bbd : SUCCESS in 2m 20s","accounts_in_message":[],"_revision_number":2},{"id":"8d300470b276ae82cbd52764c31922c8d24f18d8","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-29 07:48:58.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"11b59d3bb486b8f0bda9021314fa2c1ae60abb5e","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-29 07:50:15.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ce8217b7dee745ea848b474e0038c2f3\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9d020bee75f24b3fabb724e20c21e68e : SUCCESS in 42s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ab35c7b77e6d40c59b08f56ffe24184f : SUCCESS in 56s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"22e0bb5f8c8dcc31fe28c773323c1a95f2a334f8","revisions":{"36ce544661a6f39fae7e0de8c61fd2164808828a":{"kind":"REWORK","_number":1,"created":"2026-05-25 18:34:30.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/03/990003/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance_store","ref":"refs/changes/03/990003/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance_store refs/changes/03/990003/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance_store refs/changes/03/990003/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance_store refs/changes/03/990003/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance_store refs/changes/03/990003/1"}}},"commit":{"parents":[{"commit":"5e561642d138edf9a30da8544b3d8b7dcab96b7f","subject":"Cinder: Improve attachment create workflow","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance_store/commit/5e561642d138edf9a30da8544b3d8b7dcab96b7f"}]}],"author":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2026-05-25 18:18:15.000000000","tz":0},"committer":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2026-05-25 18:18:15.000000000","tz":0},"subject":"Cinder: Fix volume iterator logic","message":"Cinder: Fix volume iterator logic\n\nWhen we download an image stored in an image-volume\nin Glance cinder store configuration, the disconnect\nand detach operations happen after the download is\nfinished.\nThis happens because the finally block triggering\nthe detachment workflow is executed after the last\nchunk is returned, therefore, leaving a small window\nwhere the volume is detaching but the image download\nis completed.\nIf a user tries to delete the image immediately\nafter the download, the operation fails with the\nfollowing error:\n\nERROR glance.common.wsgi cinderclient.exceptions.BadRequest:\nInvalid volume: Volume status is in-use. Volume status must\nbe available or error or error_restoring or error_extending\nor error_managing and must not be migrating, attached,\nbelong to a group, have snapshots, awaiting a transfer,\nor be disassociated from snapshots after volume transfer.\n(HTTP 400) (Request-ID: req-566d3542-679a-47ee-86c2-626ba6e4fe1c)\n\nThis patch fixes the issue by calling the detach workflow\n(finally block) before the last chunk is returned, hence,\nmaking sure that the image-volume is in acceptable state\nto be deleted before we mark the image download operation\nas completed.\n\nThe issue is also reproducible with the tempest test\ntempest.api.image.v2.test_images.BasicOperationsImagesTest.test_register_upload_get_image_file\n\nCloses-Bug: #2154211\n\nChange-Id: Id1f4d6aae4769a093bce159634557176b90925ac\nSigned-off-by: Rajat Dhasmana \u003crajatdhasmana@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance_store/commit/36ce544661a6f39fae7e0de8c61fd2164808828a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance_store/commit/36ce544661a6f39fae7e0de8c61fd2164808828a"}]},"branch":"refs/heads/master"},"22e0bb5f8c8dcc31fe28c773323c1a95f2a334f8":{"kind":"REWORK","_number":2,"created":"2026-05-26 19:47:49.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/03/990003/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance_store","ref":"refs/changes/03/990003/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance_store refs/changes/03/990003/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance_store refs/changes/03/990003/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance_store refs/changes/03/990003/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance_store refs/changes/03/990003/2"}}},"commit":{"parents":[{"commit":"5e561642d138edf9a30da8544b3d8b7dcab96b7f","subject":"Cinder: Improve attachment create workflow","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance_store/commit/5e561642d138edf9a30da8544b3d8b7dcab96b7f"}]}],"author":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2026-05-25 18:18:15.000000000","tz":0},"committer":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2026-05-26 19:44:55.000000000","tz":0},"subject":"Cinder: Fix volume iterator logic","message":"Cinder: Fix volume iterator logic\n\nWhen we download an image stored in an image-volume\nin Glance cinder store configuration, the disconnect\nand detach operations happen after the download is\nfinished.\nThis happens because the finally block triggering\nthe detachment workflow is executed after the last\nchunk is returned, therefore, leaving a small window\nwhere the volume is detaching but the image download\nis completed.\nIf a user tries to delete the image immediately\nafter the download, the operation fails with the\nfollowing error:\n\nERROR glance.common.wsgi cinderclient.exceptions.BadRequest:\nInvalid volume: Volume status is in-use. Volume status must\nbe available or error or error_restoring or error_extending\nor error_managing and must not be migrating, attached,\nbelong to a group, have snapshots, awaiting a transfer,\nor be disassociated from snapshots after volume transfer.\n(HTTP 400) (Request-ID: req-566d3542-679a-47ee-86c2-626ba6e4fe1c)\n\nThis patch fixes the issue by calling the detach workflow\n(finally block) before the last chunk is returned, hence,\nmaking sure that the image-volume is in acceptable state\nto be deleted before we mark the image download operation\nas completed.\n\nThe issue is also reproducible with the tempest test\ntempest.api.image.v2.test_images.BasicOperationsImagesTest.test_register_upload_get_image_file\n\nCloses-Bug: #2154211\n\nChange-Id: Id1f4d6aae4769a093bce159634557176b90925ac\nSigned-off-by: Rajat Dhasmana \u003crajatdhasmana@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance_store/commit/22e0bb5f8c8dcc31fe28c773323c1a95f2a334f8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance_store/commit/22e0bb5f8c8dcc31fe28c773323c1a95f2a334f8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}