)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"f05c38ea7a8b8ba2c662e9010107704289533986","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2d2cdc67_ed33b181","updated":"2026-11-03 16:25:59.000000000","message":"A few small things, I\u0027ll push as soon as they are fixed.","commit_id":"6382f9aac3d9ccc01b669080d2db7787e84f06aa"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2736bb0b57f9b96ee3005f7b50335700541e6503","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"26cbb1b0_adacadde","updated":"2026-11-03 15:39:43.000000000","message":"I haven\u0027t tested this locally, but I assume you have. Obviously better than it was with a broken import, so seems okay to me.\n\nWe could put something in a job that just runs this against a raw file (even like /etc/hosts or something we know will exist) and makes sure it doesn\u0027t crash. That would have at least caught us removing the import from underneath it.","commit_id":"6382f9aac3d9ccc01b669080d2db7787e84f06aa"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f43f488df268958e06c5d559dbb0e6b9168d7002","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"42c332f4_6f632cf3","updated":"2026-11-03 19:15:44.000000000","message":"Thank you for review Dan and Cyril, made changes as per suggestion.","commit_id":"6382f9aac3d9ccc01b669080d2db7787e84f06aa"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f43f488df268958e06c5d559dbb0e6b9168d7002","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"facbcfcc_28086a7c","in_reply_to":"26cbb1b0_adacadde","updated":"2026-11-03 19:15:44.000000000","message":"I have tested it locally. Added end to end smoke test to verify the tool.","commit_id":"6382f9aac3d9ccc01b669080d2db7787e84f06aa"}],"tools/test_format_inspector.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"f05c38ea7a8b8ba2c662e9010107704289533986","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def main():"},{"line_number":40,"context_line":"    formats \u003d sorted(format_inspector.ALL_FORMATS)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    parser \u003d argparse.ArgumentParser()"},{"line_number":43,"context_line":"    parser.add_argument(\u0027-d\u0027, \u0027--debug\u0027, action\u003d\u0027store_true\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"eff1c22f_08f14aeb","line":40,"range":{"start_line":40,"start_character":21,"end_line":40,"end_character":49},"updated":"2026-11-03 16:25:59.000000000","message":"So we now sort the formats here...","commit_id":"6382f9aac3d9ccc01b669080d2db7787e84f06aa"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f43f488df268958e06c5d559dbb0e6b9168d7002","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def main():"},{"line_number":40,"context_line":"    formats \u003d sorted(format_inspector.ALL_FORMATS)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    parser \u003d argparse.ArgumentParser()"},{"line_number":43,"context_line":"    parser.add_argument(\u0027-d\u0027, \u0027--debug\u0027, action\u003d\u0027store_true\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"becfa7f1_0f2025a9","line":40,"range":{"start_line":40,"start_character":21,"end_line":40,"end_character":49},"in_reply_to":"eff1c22f_08f14aeb","updated":"2026-11-03 19:15:44.000000000","message":"Acknowledged","commit_id":"6382f9aac3d9ccc01b669080d2db7787e84f06aa"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"f05c38ea7a8b8ba2c662e9010107704289533986","unresolved":true,"context_lines":[{"line_number":42,"context_line":"    parser \u003d argparse.ArgumentParser()"},{"line_number":43,"context_line":"    parser.add_argument(\u0027-d\u0027, \u0027--debug\u0027, action\u003d\u0027store_true\u0027)"},{"line_number":44,"context_line":"    parser.add_argument(\u0027-f\u0027, \u0027--format\u0027, default\u003d\u0027raw\u0027,"},{"line_number":45,"context_line":"                        help\u003d\u0027Format (%s)\u0027 % \u0027,\u0027.join(sorted(formats)))"},{"line_number":46,"context_line":"    parser.add_argument(\u0027-b\u0027, \u0027--block-size\u0027, default\u003d65536, type\u003dint,"},{"line_number":47,"context_line":"                        help\u003d\u0027Block read size\u0027)"},{"line_number":48,"context_line":"    parser.add_argument(\u0027--context-limit\u0027, default\u003d(1 * 1024), type\u003dint,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6ccc220c_0eac93e6","line":45,"range":{"start_line":45,"start_character":61,"end_line":45,"end_character":68},"updated":"2026-11-03 16:25:59.000000000","message":"...and we sort them again here. I don\u0027t think the variable is used anywhere else. Let\u0027s only sort them once.","commit_id":"6382f9aac3d9ccc01b669080d2db7787e84f06aa"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f43f488df268958e06c5d559dbb0e6b9168d7002","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    parser \u003d argparse.ArgumentParser()"},{"line_number":43,"context_line":"    parser.add_argument(\u0027-d\u0027, \u0027--debug\u0027, action\u003d\u0027store_true\u0027)"},{"line_number":44,"context_line":"    parser.add_argument(\u0027-f\u0027, \u0027--format\u0027, default\u003d\u0027raw\u0027,"},{"line_number":45,"context_line":"                        help\u003d\u0027Format (%s)\u0027 % \u0027,\u0027.join(sorted(formats)))"},{"line_number":46,"context_line":"    parser.add_argument(\u0027-b\u0027, \u0027--block-size\u0027, default\u003d65536, type\u003dint,"},{"line_number":47,"context_line":"                        help\u003d\u0027Block read size\u0027)"},{"line_number":48,"context_line":"    parser.add_argument(\u0027--context-limit\u0027, default\u003d(1 * 1024), type\u003dint,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e1347825_c4862146","line":45,"range":{"start_line":45,"start_character":61,"end_line":45,"end_character":68},"in_reply_to":"6ccc220c_0eac93e6","updated":"2026-11-03 19:15:44.000000000","message":"Acknowledged","commit_id":"6382f9aac3d9ccc01b669080d2db7787e84f06aa"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"f05c38ea7a8b8ba2c662e9010107704289533986","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        while True:"},{"line_number":73,"context_line":"            chunk \u003d stream.read(args.block_size)"},{"line_number":74,"context_line":"            # This could stream to an output destination or stdin for testing"},{"line_number":75,"context_line":"            # sys.stdout.write(chunk)"},{"line_number":76,"context_line":"            if not chunk:"},{"line_number":77,"context_line":"                break"},{"line_number":78,"context_line":"            count +\u003d len(chunk)"}],"source_content_type":"text/x-python","patch_set":1,"id":"131168ab_83070497","line":75,"range":{"start_line":75,"start_character":14,"end_line":75,"end_character":30},"updated":"2026-11-03 16:25:59.000000000","message":"Maybe let\u0027s use this opportunity to remove this commented line and the associated comment.","commit_id":"6382f9aac3d9ccc01b669080d2db7787e84f06aa"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f43f488df268958e06c5d559dbb0e6b9168d7002","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        while True:"},{"line_number":73,"context_line":"            chunk \u003d stream.read(args.block_size)"},{"line_number":74,"context_line":"            # This could stream to an output destination or stdin for testing"},{"line_number":75,"context_line":"            # sys.stdout.write(chunk)"},{"line_number":76,"context_line":"            if not chunk:"},{"line_number":77,"context_line":"                break"},{"line_number":78,"context_line":"            count +\u003d len(chunk)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a4e958b4_f71ae6c8","line":75,"range":{"start_line":75,"start_character":14,"end_line":75,"end_character":30},"in_reply_to":"131168ab_83070497","updated":"2026-11-03 19:15:44.000000000","message":"Acknowledged","commit_id":"6382f9aac3d9ccc01b669080d2db7787e84f06aa"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"f05c38ea7a8b8ba2c662e9010107704289533986","unresolved":true,"context_lines":[{"line_number":77,"context_line":"                break"},{"line_number":78,"context_line":"            count +\u003d len(chunk)"},{"line_number":79,"context_line":"            if args.format \u003d\u003d \u0027raw\u0027 or found_size:"},{"line_number":80,"context_line":"                continue"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            try:"},{"line_number":83,"context_line":"                detected_format \u003d stream.format"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf1d0812_40f341b5","line":80,"range":{"start_line":80,"start_character":16,"end_line":80,"end_character":24},"updated":"2026-11-03 16:25:59.000000000","message":"So I think that the above 2 lines could be moved at the top of the loop so save one useless call to stream.read().","commit_id":"6382f9aac3d9ccc01b669080d2db7787e84f06aa"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f43f488df268958e06c5d559dbb0e6b9168d7002","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                break"},{"line_number":78,"context_line":"            count +\u003d len(chunk)"},{"line_number":79,"context_line":"            if args.format \u003d\u003d \u0027raw\u0027 or found_size:"},{"line_number":80,"context_line":"                continue"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            try:"},{"line_number":83,"context_line":"                detected_format \u003d stream.format"}],"source_content_type":"text/x-python","patch_set":1,"id":"14285027_6442b972","line":80,"range":{"start_line":80,"start_character":16,"end_line":80,"end_character":24},"in_reply_to":"bf1d0812_40f341b5","updated":"2026-11-03 19:15:44.000000000","message":"Acknowledged","commit_id":"6382f9aac3d9ccc01b669080d2db7787e84f06aa"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b389b1dd219742a73b55ddc9bcf532162d408c6b","unresolved":true,"context_lines":[{"line_number":42,"context_line":"    parser \u003d argparse.ArgumentParser()"},{"line_number":43,"context_line":"    parser.add_argument(\u0027-d\u0027, \u0027--debug\u0027, action\u003d\u0027store_true\u0027)"},{"line_number":44,"context_line":"    parser.add_argument(\u0027-f\u0027, \u0027--format\u0027, default\u003d\u0027raw\u0027,"},{"line_number":45,"context_line":"                        help\u003d\u0027Format (%s)\u0027 % \u0027,\u0027.join(formats))"},{"line_number":46,"context_line":"    parser.add_argument(\u0027-b\u0027, \u0027--block-size\u0027, default\u003d65536, type\u003dint,"},{"line_number":47,"context_line":"                        help\u003d\u0027Block read size\u0027)"},{"line_number":48,"context_line":"    parser.add_argument(\u0027--context-limit\u0027, default\u003d(1 * 1024), type\u003dint,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e3f09040_35b0dce8","line":45,"updated":"2026-11-05 14:30:15.000000000","message":"I\u0027m not sure these are sufficiently sorted here, but I guess \"kinda sorted\" is enough.....\n\n\n\n/s","commit_id":"7dcd4439ae93f98fdd9e0ce2a618f71659775913"}]}