)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4ae3ab62e2a3e5a089cc8a548d3d06a5c860c633","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f0883423_65cce87f","line":20,"updated":"2026-11-16 10:57:35.000000000","message":"Please add Depends-On glance_store patch","commit_id":"7a84d9337955ba8f6fd8a1dcf71ed2184522da55"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e527657ee54b62fdb393b30acfd1badb253d8cdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b460045_8da13436","updated":"2026-11-16 14:29:35.000000000","message":"I have verified below scenarios in my local envrionment with this and glance_store patch and it is working as expected.\n\n- Store discovery: rgw (s3 store) reports temp_url_enabled\u003dtrue.\n- Image upload to rgw: HTTP 204.\n- Temporary URL generation: HTTP 200.\n- Immediate direct RGW download: HTTP 200.\n- SHA-256 checksum match.\n- Temporary URL response caching: Cache-Control: no-store.\n- Glance cache bypass: cache remains unchanged; image is not cached.\n- Expired URL: HTTP 403.\n- Missing Keystone token: HTTP 401.\n- Invalid store ID: HTTP 400.\n- Queued/non-active image: HTTP 409.\n- Temporary URLs disabled: HTTP 409.\n- Image cleanup: HTTP 204.","commit_id":"7a84d9337955ba8f6fd8a1dcf71ed2184522da55"}],"glance/api/v2/images.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4ae3ab62e2a3e5a089cc8a548d3d06a5c860c633","unresolved":true,"context_lines":[{"line_number":837,"context_line":"        except exception.NotAuthenticated as e:"},{"line_number":838,"context_line":"            raise webob.exc.HTTPUnauthorized(explanation\u003de.msg)"},{"line_number":839,"context_line":"        except exception.NotFound:"},{"line_number":840,"context_line":"            msg \u003d (_(\"Failed to find image %(image_id)s\") %"},{"line_number":841,"context_line":"                   {\u0027image_id\u0027: image_id})"},{"line_number":842,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        # A temporary URL gives the image data to whoever holds it, so the"}],"source_content_type":"text/x-python","patch_set":1,"id":"3463f75f_373c5d7e","line":841,"range":{"start_line":840,"start_character":0,"end_line":841,"end_character":42},"updated":"2026-11-16 10:57:35.000000000","message":"why not use message from NotFound exception?","commit_id":"7a84d9337955ba8f6fd8a1dcf71ed2184522da55"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"8e449e9f07635a68a0c26f373c78469c0c76f35c","unresolved":false,"context_lines":[{"line_number":837,"context_line":"        except exception.NotAuthenticated as e:"},{"line_number":838,"context_line":"            raise webob.exc.HTTPUnauthorized(explanation\u003de.msg)"},{"line_number":839,"context_line":"        except exception.NotFound:"},{"line_number":840,"context_line":"            msg \u003d (_(\"Failed to find image %(image_id)s\") %"},{"line_number":841,"context_line":"                   {\u0027image_id\u0027: image_id})"},{"line_number":842,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        # A temporary URL gives the image data to whoever holds it, so the"}],"source_content_type":"text/x-python","patch_set":1,"id":"c9e508ae_ba4223c5","line":841,"range":{"start_line":840,"start_character":0,"end_line":841,"end_character":42},"in_reply_to":"3463f75f_373c5d7e","updated":"2026-11-16 11:55:52.000000000","message":"Acknowledged","commit_id":"7a84d9337955ba8f6fd8a1dcf71ed2184522da55"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4ae3ab62e2a3e5a089cc8a548d3d06a5c860c633","unresolved":true,"context_lines":[{"line_number":845,"context_line":"        # caller must also be allowed to download the image from this store."},{"line_number":846,"context_line":"        api_pol \u003d api_policy.ImageAPIPolicy(req.context, image, self.policy)"},{"line_number":847,"context_line":"        try:"},{"line_number":848,"context_line":"            api_pol.download_from_store()"},{"line_number":849,"context_line":"            api_pol.generate_temp_url()"},{"line_number":850,"context_line":"        except exception.NotFound as e:"},{"line_number":851,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.msg)"},{"line_number":852,"context_line":"        except exception.Forbidden as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"f4b25981_47000e33","line":849,"range":{"start_line":848,"start_character":0,"end_line":849,"end_character":39},"updated":"2026-11-16 10:57:35.000000000","message":"Nova sends both user and service tokens. Normal download checks download_image for the user token. Should we check the same policy here also?","commit_id":"7a84d9337955ba8f6fd8a1dcf71ed2184522da55"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"98da0abfce127c52fdc9063dfa7684964f17f6ed","unresolved":false,"context_lines":[{"line_number":845,"context_line":"        # caller must also be allowed to download the image from this store."},{"line_number":846,"context_line":"        api_pol \u003d api_policy.ImageAPIPolicy(req.context, image, self.policy)"},{"line_number":847,"context_line":"        try:"},{"line_number":848,"context_line":"            api_pol.download_from_store()"},{"line_number":849,"context_line":"            api_pol.generate_temp_url()"},{"line_number":850,"context_line":"        except exception.NotFound as e:"},{"line_number":851,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.msg)"},{"line_number":852,"context_line":"        except exception.Forbidden as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"16beceba_0899b3bc","line":849,"range":{"start_line":848,"start_character":0,"end_line":849,"end_character":39},"in_reply_to":"8c957957_33696447","updated":"2026-11-16 12:15:11.000000000","message":"Acknowledged","commit_id":"7a84d9337955ba8f6fd8a1dcf71ed2184522da55"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"8e449e9f07635a68a0c26f373c78469c0c76f35c","unresolved":true,"context_lines":[{"line_number":845,"context_line":"        # caller must also be allowed to download the image from this store."},{"line_number":846,"context_line":"        api_pol \u003d api_policy.ImageAPIPolicy(req.context, image, self.policy)"},{"line_number":847,"context_line":"        try:"},{"line_number":848,"context_line":"            api_pol.download_from_store()"},{"line_number":849,"context_line":"            api_pol.generate_temp_url()"},{"line_number":850,"context_line":"        except exception.NotFound as e:"},{"line_number":851,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.msg)"},{"line_number":852,"context_line":"        except exception.Forbidden as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"8c957957_33696447","line":849,"range":{"start_line":848,"start_character":0,"end_line":849,"end_character":39},"in_reply_to":"f4b25981_47000e33","updated":"2026-11-16 11:55:52.000000000","message":"I was thinking about it and then decided that it was not raised in spec review, so I only included download_from_store as it\u0027s already running the same check as download_image when configured as default, but in non-default config it will come handy","commit_id":"7a84d9337955ba8f6fd8a1dcf71ed2184522da55"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4ae3ab62e2a3e5a089cc8a548d3d06a5c860c633","unresolved":true,"context_lines":[{"line_number":851,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.msg)"},{"line_number":852,"context_line":"        except exception.Forbidden as e:"},{"line_number":853,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003de.msg)"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"        if image.status !\u003d \u0027active\u0027:"},{"line_number":856,"context_line":"            msg \u003d _(\"Temporary URLs are only given for \u0027active\u0027 images.\")"},{"line_number":857,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"        try:"},{"line_number":860,"context_line":"            temp_url, expires_at \u003d image.get_temp_url(store_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"8207caed_5d3bba28","line":857,"range":{"start_line":854,"start_character":0,"end_line":857,"end_character":57},"updated":"2026-11-16 10:57:35.000000000","message":"Better to move this before policy invocation","commit_id":"7a84d9337955ba8f6fd8a1dcf71ed2184522da55"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"98da0abfce127c52fdc9063dfa7684964f17f6ed","unresolved":true,"context_lines":[{"line_number":851,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.msg)"},{"line_number":852,"context_line":"        except exception.Forbidden as e:"},{"line_number":853,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003de.msg)"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"        if image.status !\u003d \u0027active\u0027:"},{"line_number":856,"context_line":"            msg \u003d _(\"Temporary URLs are only given for \u0027active\u0027 images.\")"},{"line_number":857,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"        try:"},{"line_number":860,"context_line":"            temp_url, expires_at \u003d image.get_temp_url(store_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3b082203_6839499a","line":857,"range":{"start_line":854,"start_character":0,"end_line":857,"end_character":57},"in_reply_to":"172eab0f_94bbb1fe","updated":"2026-11-16 12:15:11.000000000","message":"IMO it should be moved after line 836, but I am open for suggestions or other rviewers opinion","commit_id":"7a84d9337955ba8f6fd8a1dcf71ed2184522da55"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"b371f37709699519c53a9c55dca8239a0af845c5","unresolved":true,"context_lines":[{"line_number":851,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.msg)"},{"line_number":852,"context_line":"        except exception.Forbidden as e:"},{"line_number":853,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003de.msg)"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"        if image.status !\u003d \u0027active\u0027:"},{"line_number":856,"context_line":"            msg \u003d _(\"Temporary URLs are only given for \u0027active\u0027 images.\")"},{"line_number":857,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"        try:"},{"line_number":860,"context_line":"            temp_url, expires_at \u003d image.get_temp_url(store_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f55a3968_b3b5aa45","line":857,"range":{"start_line":854,"start_character":0,"end_line":857,"end_character":57},"in_reply_to":"3b082203_6839499a","updated":"2026-11-17 13:03:32.000000000","message":"there\u0027s an interesting edge-case when this is above policy checks. if tenant A adds a member(tenant B) to an image, and someone has custom policies that would deny get_image/download_image to non-owner-project(effectively killing image members functionality altogether), then tenant B is capable of infering image status as non-active from responses, since image_repo.get() will grab image object for a member because db/utils:is_image_visible is unaware of policies","commit_id":"7a84d9337955ba8f6fd8a1dcf71ed2184522da55"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"8e449e9f07635a68a0c26f373c78469c0c76f35c","unresolved":true,"context_lines":[{"line_number":851,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.msg)"},{"line_number":852,"context_line":"        except exception.Forbidden as e:"},{"line_number":853,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003de.msg)"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"        if image.status !\u003d \u0027active\u0027:"},{"line_number":856,"context_line":"            msg \u003d _(\"Temporary URLs are only given for \u0027active\u0027 images.\")"},{"line_number":857,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"        try:"},{"line_number":860,"context_line":"            temp_url, expires_at \u003d image.get_temp_url(store_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"172eab0f_94bbb1fe","line":857,"range":{"start_line":854,"start_character":0,"end_line":857,"end_character":57},"in_reply_to":"8207caed_5d3bba28","updated":"2026-11-16 11:55:52.000000000","message":"it would need to be placed between download and generate checks then, mixing different checks. I\u0027m not sure I like it","commit_id":"7a84d9337955ba8f6fd8a1dcf71ed2184522da55"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4fb9e3c0490cc067c3a417ec69db01f52d277b69","unresolved":false,"context_lines":[{"line_number":851,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.msg)"},{"line_number":852,"context_line":"        except exception.Forbidden as e:"},{"line_number":853,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003de.msg)"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"        if image.status !\u003d \u0027active\u0027:"},{"line_number":856,"context_line":"            msg \u003d _(\"Temporary URLs are only given for \u0027active\u0027 images.\")"},{"line_number":857,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"        try:"},{"line_number":860,"context_line":"            temp_url, expires_at \u003d image.get_temp_url(store_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d5830254_572e7d65","line":857,"range":{"start_line":854,"start_character":0,"end_line":857,"end_character":57},"in_reply_to":"f55a3968_b3b5aa45","updated":"2026-11-17 14:26:43.000000000","message":"Acknowledged","commit_id":"7a84d9337955ba8f6fd8a1dcf71ed2184522da55"}]}
