)]}'
{"etc/metadefs/compute-trust.json":[{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"8db53ec4910d43229660f51e7ee0cacc575479a3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"\t\"namespace\" : \"OS::Compute::Trust\","},{"line_number":3,"context_line":"\t\"display_name\" : \"Trusted Compute Pools with Intel(r) TXT\","},{"line_number":4,"context_line":"\t\"description\" : \"Trusted compute pools with Intel® Trusted Execution Technology (Intel® TXT) support IT compliance by protecting virtualized data centers’ private, public, and hybrid clouds against attacks toward hypervisor and BIOS, firmware, and other pre-launch software components.\","},{"line_number":5,"context_line":"\t\"visibility\" : \"public\","}],"source_content_type":"application/json","patch_set":7,"id":"baada198_5d3b52c7","line":2,"updated":"2014-08-04 13:35:58.000000000","message":"please, format it to 4 space- indent","commit_id":"68afd47aa9328d92c1f8c8a3198299897afe0ea4"}],"etc/metadefs/compute-watchdog.json":[{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"8db53ec4910d43229660f51e7ee0cacc575479a3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"   \"description\":\"Compute drivers may enable watchdog behavior over instances.  See: http://docs.openstack.org/admin-guide-cloud/content/customize-flavors.html\","},{"line_number":5,"context_line":"   \"visibility\":\"public\","},{"line_number":6,"context_line":"   \"protected\":true,"},{"line_number":7,"context_line":"   \"resource_types\" : ["},{"line_number":8,"context_line":"      {"},{"line_number":9,"context_line":"         \"name\" : \"OS::Glance::Image\""},{"line_number":10,"context_line":"      },"}],"source_content_type":"application/json","patch_set":7,"id":"baada198_1df2ba04","line":7,"updated":"2014-08-04 13:35:58.000000000","message":"\"resource_types\": {","commit_id":"68afd47aa9328d92c1f8c8a3198299897afe0ea4"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"8db53ec4910d43229660f51e7ee0cacc575479a3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"         \"name\" : \"OS::Nova::Flavor\""},{"line_number":17,"context_line":"      }"},{"line_number":18,"context_line":"   ],"},{"line_number":19,"context_line":"   \"properties\":{"},{"line_number":20,"context_line":"      \"hw_watchdog_action\":{"},{"line_number":21,"context_line":"         \"title\":\"Watchdog Action\","},{"line_number":22,"context_line":"         \"description\":\"For the libvirt driver, you can enable and set the behavior of a virtual hardware watchdog device for each flavor. Watchdog devices keep an eye on the guest server, and carry out the configured action, if the server hangs. The watchdog uses the i6300esb device (emulating a PCI Intel 6300ESB). If hw_watchdog_action is not specified, the watchdog is disabled. Watchdog behavior set using a specific image\u0027s properties will override behavior set using flavors.\","}],"source_content_type":"application/json","patch_set":7,"id":"baada198_3d95be87","line":19,"updated":"2014-08-04 13:35:58.000000000","message":"formatting- should be \"properties\": {","commit_id":"68afd47aa9328d92c1f8c8a3198299897afe0ea4"}],"glance/cmd/manage.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"aebf14b725f959f4537b7179952f18633fc5b748","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def load_metadefs(self):"},{"line_number":184,"context_line":"        self.command_object.load_metadefs(CONF.command.path)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def unload_metadefs(self):"},{"line_number":187,"context_line":"        self.command_object.unload_metadefs()"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"baada198_f7e23ed3","line":185,"updated":"2014-08-06 00:28:23.000000000","message":"The output of this command on success if very ugly.  I produces sqlalchemy output.  Please make more friendly.","commit_id":"d4f88f4f4fff0ae136d6019993c723266f5150c0"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"aebf14b725f959f4537b7179952f18633fc5b748","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def unload_metadefs(self):"},{"line_number":187,"context_line":"        self.command_object.unload_metadefs()"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def export_metadefs(self):"},{"line_number":190,"context_line":"        self.command_object.export_metadefs(CONF.command.path)"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"baada198_17e892b2","line":188,"updated":"2014-08-06 00:28:23.000000000","message":"The output of this command on success if very ugly.  I produces sqlalchemy output.  Please make more friendly.","commit_id":"d4f88f4f4fff0ae136d6019993c723266f5150c0"}],"glance/db/sqlalchemy/metadata.py":[{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"8db53ec4910d43229660f51e7ee0cacc575479a3","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":"import os"},{"line_number":22,"context_line":"from os.path import isfile"},{"line_number":23,"context_line":"from os.path import join"},{"line_number":24,"context_line":"import sqlalchemy"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_1ddc7a44","line":22,"updated":"2014-08-04 13:35:58.000000000","message":"import order, should be import stdlib -\u003e import 3rd party -\u003e import local -\u003e from ... import ..","commit_id":"68afd47aa9328d92c1f8c8a3198299897afe0ea4"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"4d71a3599ec5ed8ede96fcfc2f9c067f6fafe2a3","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":"import os"},{"line_number":22,"context_line":"from os.path import isfile"},{"line_number":23,"context_line":"from os.path import join"},{"line_number":24,"context_line":"import sqlalchemy"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_d8069084","line":22,"in_reply_to":"baada198_1ddc7a44","updated":"2014-08-04 13:56:15.000000000","message":"http://docs.openstack.org/developer/hacking/\n\nOnly \u0027import sqlalchemy\u0027 is in the wrong place.","commit_id":"68afd47aa9328d92c1f8c8a3198299897afe0ea4"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"1192cce50b1ad17f05fe065de528759120acc5dd","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":"import os"},{"line_number":22,"context_line":"from os.path import isfile"},{"line_number":23,"context_line":"from os.path import join"},{"line_number":24,"context_line":"import sqlalchemy"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_13b38909","line":22,"in_reply_to":"baada198_d8069084","updated":"2014-08-04 14:07:12.000000000","message":"ok, agreed, still sqlalchemy import should be fixed","commit_id":"68afd47aa9328d92c1f8c8a3198299897afe0ea4"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"8db53ec4910d43229660f51e7ee0cacc575479a3","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        }"},{"line_number":124,"context_line":"        _insert_data_to_db(metadef_namespaces_table, values)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        if \u0027resource_types\u0027 in metadata:"},{"line_number":127,"context_line":"            for resource_type in metadata[\u0027resource_types\u0027]:"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_bd62ae13","line":126,"updated":"2014-08-04 13:35:58.000000000","message":"for resource_type in metadata.get(\u0027resource_types\u0027, []) \n\nOne less indent","commit_id":"68afd47aa9328d92c1f8c8a3198299897afe0ea4"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"bfb358a141038f0be76f1ac8882d820f25bcdcf6","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            json_file.close()"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        except Exception as e:"},{"line_number":291,"context_line":"            LOG.debug(utils.exception_to_str(e))"},{"line_number":292,"context_line":"        LOG.info(_LI(\"Namespace %s saved in %s\"),"},{"line_number":293,"context_line":"                 namespace_file_name, file_name)"},{"line_number":294,"context_line":""}],"source_content_type":"text/x-python","patch_set":50,"id":"1abeadc6_dc2a788f","line":291,"updated":"2014-08-27 09:35:51.000000000","message":"I think this would deserve:\nLOG.exception()\nSpecifically when we log the successful operation in INFO level.","commit_id":"e92d89fb9123772c7cb7263d8f413cc18f4c45bc"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"e6306dba575e18d2b505b62c6dd6288376e88d38","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                                                    start\u003d1):"},{"line_number":132,"context_line":"        try:"},{"line_number":133,"context_line":"            file \u003d join(metadata_path, json_schema_file)"},{"line_number":134,"context_line":"            json_metadata \u003d open(file)"},{"line_number":135,"context_line":"            metadata \u003d json.load(json_metadata)"},{"line_number":136,"context_line":"            json_metadata.close()"},{"line_number":137,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":55,"id":"fa98f980_494142a8","line":134,"updated":"2014-09-03 04:24:10.000000000","message":"with..as for open() is safer here","commit_id":"1c242032fbb26fed3a82691abb030583b4f8940b"}]}