)]}'
{"glance/api/v1/images.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"f79a1eeff1ba4c7d9a83d746ba4b6834bc9bdcf6","unresolved":false,"context_lines":[{"line_number":914,"context_line":"                response, image_meta, expected_size, image_iter, self.notifier)"},{"line_number":915,"context_line":"        # Using app_iter blanks content-length, so we set it here..."},{"line_number":916,"context_line":"        response.headers[\u0027Content-Length\u0027] \u003d image_meta[\u0027size\u0027]"},{"line_number":917,"context_line":"        response.headers[\u0027Content-Type\u0027] \u003d \u0027application/octet-stream\u0027"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"        self._inject_image_meta_headers(response, image_meta)"},{"line_number":920,"context_line":"        self._inject_location_header(response, image_meta)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FmyM%3D","side":"PARENT","line":917,"updated":"2012-08-28 01:19:23.000000000","message":"Why don\u0027t we care about these headers being utf-8-encoded?","commit_id":"9c4c8102735dc246d3e2daade4d48a723c45e402"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"90729fcbca543936777c002551f425ac0175a38b","unresolved":false,"context_lines":[{"line_number":914,"context_line":"                response, image_meta, expected_size, image_iter, self.notifier)"},{"line_number":915,"context_line":"        # Using app_iter blanks content-length, so we set it here..."},{"line_number":916,"context_line":"        response.headers[\u0027Content-Length\u0027] \u003d image_meta[\u0027size\u0027]"},{"line_number":917,"context_line":"        response.headers[\u0027Content-Type\u0027] \u003d \u0027application/octet-stream\u0027"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"        self._inject_image_meta_headers(response, image_meta)"},{"line_number":920,"context_line":"        self._inject_location_header(response, image_meta)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FmEs%3D","side":"PARENT","line":917,"in_reply_to":"AAAALH%2F%2Fmqc%3D","updated":"2012-08-28 21:32:46.000000000","message":"Ok, cool. Thanks for the info.","commit_id":"9c4c8102735dc246d3e2daade4d48a723c45e402"},{"author":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"change_message_id":"5e1f0a85d40ffd4496437d325a64f908a354c364","unresolved":false,"context_lines":[{"line_number":914,"context_line":"                response, image_meta, expected_size, image_iter, self.notifier)"},{"line_number":915,"context_line":"        # Using app_iter blanks content-length, so we set it here..."},{"line_number":916,"context_line":"        response.headers[\u0027Content-Length\u0027] \u003d image_meta[\u0027size\u0027]"},{"line_number":917,"context_line":"        response.headers[\u0027Content-Type\u0027] \u003d \u0027application/octet-stream\u0027"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"        self._inject_image_meta_headers(response, image_meta)"},{"line_number":920,"context_line":"        self._inject_location_header(response, image_meta)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2Fmqc%3D","side":"PARENT","line":917,"in_reply_to":"AAAALH%2F%2FmyM%3D","updated":"2012-08-28 06:04:46.000000000","message":"For Content-Length: image_meta[\u0027size\u0027] represents an integer. The comment a few lines before claims the type is str, but in my tests, it was int, and calling .encode() on an int just doesn\u0027t work. Just using str() is enough to convert it to ASCII (which is valid UTF-8, since it\u0027s just numbers), whatever the type of this object is.\n\nFor Content-Type: this is a str object, not a unicode object. As such, it\u0027s already encoded, and it turns out this hard-coded string is valid UTF-8 (since it\u0027s pure ASCII).","commit_id":"9c4c8102735dc246d3e2daade4d48a723c45e402"}]}