)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"0e4201cf7d94b1941ae36acf7f05be4bcea1b19c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"time, eg:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"$ time nc localhost 9292"},{"line_number":14,"context_line":"real    1m0.063s"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Setting \u0027client_socket_timeout \u003d 0\u0027 means do not timeout."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"dac4157f_7b77a43a","line":14,"updated":"2015-04-21 16:47:46.000000000","message":"Based on the default perhaps it is better to use 15m_.__s here? (Since the default timeout is actually 15 minutes)","commit_id":"3627ff8a1cea12ed9d1cd853c64f80b4a69f4426"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"bae00ef70ecd45a520ad86447bddb3834f2d86c1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"$ time nc localhost 9292"},{"line_number":14,"context_line":"real    1m0.063s"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Setting \u0027client_socket_timeout \u003d 0\u0027 means do not timeout."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I9e7edcbf25ece61dc16b8cd5a8bef5ed9a14e3d6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"fa32b979_ee611606","line":16,"updated":"2015-06-18 14:46:29.000000000","message":"Add DocImpact flag here, please","commit_id":"3627ff8a1cea12ed9d1cd853c64f80b4a69f4426"}],"doc/source/configuring.rst":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"0e4201cf7d94b1941ae36acf7f05be4bcea1b19c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"* ``client_socket_timeout\u003dSECONDS``"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Timeout for client connections\u0027 socket operations.  If an incoming"},{"line_number":179,"context_line":"connection is idle for this period it will be closed.  A value of `0`"},{"line_number":180,"context_line":"means wait forever."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Optional. Default: ``900``"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dac4157f_4faa0dd6","line":179,"updated":"2015-04-21 16:47:46.000000000","message":"So, I recognize that the option is described as \u003dSECONDS but the tcp_keepidle option also explicitly says \"in seconds\" in the description. Perhaps something like\n\n   If an incoming connection is idle for this number of seconds, it will be closed.","commit_id":"3627ff8a1cea12ed9d1cd853c64f80b4a69f4426"}],"etc/glance-api.conf":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"0e4201cf7d94b1941ae36acf7f05be4bcea1b19c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# Timeout (in seconds) for client connections\u0027 socket operations. If an incoming"},{"line_number":35,"context_line":"# connection is idle for this period it will be closed.  A value of \"0\""},{"line_number":36,"context_line":"# means wait forever."},{"line_number":37,"context_line":"#client_socket_timeout \u003d 900"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# API to use for accessing data. Default value points to sqlalchemy"},{"line_number":40,"context_line":"# package, it is also possible to use: glance.db.registry.api"}],"source_content_type":"text/plain","patch_set":11,"id":"dac4157f_2fdeb96d","line":37,"updated":"2015-04-21 16:47:46.000000000","message":"Is there a reason for choosing 15 minutes (900 seconds) instead of something lower? I\u0027m hoping this comes from experience with a deployment using this value.","commit_id":"3627ff8a1cea12ed9d1cd853c64f80b4a69f4426"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"18b57e025315b029613dc9ee56ff14fe487be417","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# Timeout (in seconds) for client connections\u0027 socket operations. If an incoming"},{"line_number":35,"context_line":"# connection is idle for this period it will be closed.  A value of \"0\""},{"line_number":36,"context_line":"# means wait forever."},{"line_number":37,"context_line":"#client_socket_timeout \u003d 900"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# API to use for accessing data. Default value points to sqlalchemy"},{"line_number":40,"context_line":"# package, it is also possible to use: glance.db.registry.api"}],"source_content_type":"text/plain","patch_set":11,"id":"dac4157f_4e72dc4a","line":37,"in_reply_to":"dac4157f_2fdeb96d","updated":"2015-04-21 17:08:36.000000000","message":"Thanks for your review Ian.\n\n\u003e Is there a reason for choosing 15 minutes (900 seconds) instead of something lower?\n\nSo, the truth is I don\u0027t have experience deploying with this value. \n\nI wanted to pick something which strayed on the side of giving requests enough time that you can be pretty confident they\u0027re not going to complete, but which would eventually clean up stray sockets after a long time. I\u0027m definitely open to other suggestions for a default value.\n\nThis default merged in the equivalent cinder patch in juno: https://review.openstack.org/#/c/119365 and doesn\u0027t seem to have caused any issues (although their I/O pattern is very different).","commit_id":"3627ff8a1cea12ed9d1cd853c64f80b4a69f4426"}],"glance/tests/functional/test_wsgi.py":[{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"406a655d23c4a3875d7b07b6df9ce93c718fffc1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            start_response(\u0027200 OK\u0027, [(\u0027Content-Type\u0027, \u0027text/plain\u0027)])"},{"line_number":38,"context_line":"            return [greetings]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        CONF.workers \u003d 0"},{"line_number":41,"context_line":"        server \u003d wsgi.Server()"},{"line_number":42,"context_line":"        server.client_socket_timeout \u003d 0.1"},{"line_number":43,"context_line":"        server.start(hello_world, 0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_22230cbe","line":40,"updated":"2014-10-16 10:50:39.000000000","message":"Doesn\u0027t this cause a race condition if a subsequent test relies on CONF.workers being the default value?","commit_id":"10e60405cc4f0c412f72e473c3cc8a1ebfdf4fa4"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"48c93f12c980f7a18d8d17a65b0e8dda30393b16","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            start_response(\u0027200 OK\u0027, [(\u0027Content-Type\u0027, \u0027text/plain\u0027)])"},{"line_number":38,"context_line":"            return [greetings]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        CONF.workers \u003d 0"},{"line_number":41,"context_line":"        server \u003d wsgi.Server()"},{"line_number":42,"context_line":"        server.client_socket_timeout \u003d 0.1"},{"line_number":43,"context_line":"        server.start(hello_world, 0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_bdad5d86","line":40,"in_reply_to":"baa201ad_22230cbe","updated":"2014-10-16 11:28:49.000000000","message":"I think you\u0027re right that if another of these wsgi style tests are added that setting CONF.workers in this test will leak which isn\u0027t a good thing, so I\u0027ll change it.\n\nI think that what this test class is intended to test means that workers will be 0 for any future test.. so probaly the best thing is to just set to 0 in the class\u0027s init.\n\nDoes that make sense?","commit_id":"10e60405cc4f0c412f72e473c3cc8a1ebfdf4fa4"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"a3705b46f91d11f6b0f481f10d98ab5dcea579c2","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"CONF \u003d cfg.CONF"},{"line_number":28,"context_line":"# By design these are not multi-process tests"},{"line_number":29,"context_line":"CONF.workers \u003d 0"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class TestWSGIServer(testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_23930e5c","line":29,"updated":"2014-10-16 12:45:30.000000000","message":"Doesn\u0027t this still suffer from the same problem? As far as I know, the state of CONF is globally shared with the other tests being run, so CONF.workers \u003d 0 in all further test modules after this module is imported.","commit_id":"9db13cce85e35bf4cd3890be5d19821c4bde4f45"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"37a5f5ed4e2e517b71b4c9bc8dc93da836d5c73e","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"CONF \u003d cfg.CONF"},{"line_number":28,"context_line":"# By design these are not multi-process tests"},{"line_number":29,"context_line":"CONF.workers \u003d 0"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class TestWSGIServer(testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_5571a50a","line":29,"in_reply_to":"baa201ad_23930e5c","updated":"2014-10-16 13:08:24.000000000","message":"Heh, you are 100% correct.\n\nI should be able to just do what I did for the equivalent cinder patch: https://review.openstack.org/#/c/119365/6/cinder/tests/test_wsgi.py\n(Not sure why I changed it here.)\n\n\u0027set_default\u0027 doesn\u0027t seem to pollute other tests.","commit_id":"9db13cce85e35bf4cd3890be5d19821c4bde4f45"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"942f6357a767cd0ca142e85a028d6723f474ef36","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        sock2 \u003d socket.socket()"},{"line_number":57,"context_line":"        sock2.connect((\"127.0.0.1\", port))"},{"line_number":58,"context_line":"        time.sleep(0.2)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        fd \u003d sock2.makefile(\u0027rw\u0027)"},{"line_number":61,"context_line":"        fd.write(b\u0027GET / HTTP/1.1\\r\\nHost: localhost\\r\\n\\r\\n\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_539b71c8","line":58,"updated":"2015-03-19 23:57:48.000000000","message":"0.1 may be enough (opinion).","commit_id":"cc9a8c84af77a4c0adcce0eb16a6ff802d8be711"}]}