)]}'
{"glance/db/__init__.py":[{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"c88407476718b42a1767165a30365702a55aceb1","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        img[\"properties\"] \u003d {}"},{"line_number":151,"context_line":"        for prop in image.extra_properties.modified:"},{"line_number":152,"context_line":"            img[\"properties\"][prop] \u003d image.extra_properties[prop]"},{"line_number":153,"context_line":"        return img, image.extra_properties.deleted"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def add(self, image):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_d4ba4e09","line":152,"updated":"2014-09-24 13:06:11.000000000","message":"Why refactor this part? In my opinion, the previous way of writing this was more explicit and clear.","commit_id":"a8604a80f4a8b3194851c126db2309b6440f837f"},{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"9daa51b8505dc39c3f7552559d0836d08aa0ac23","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        img[\"properties\"] \u003d {}"},{"line_number":151,"context_line":"        for prop in image.extra_properties.modified:"},{"line_number":152,"context_line":"            img[\"properties\"][prop] \u003d image.extra_properties[prop]"},{"line_number":153,"context_line":"        return img, image.extra_properties.deleted"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def add(self, image):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_d4ffaea8","line":152,"in_reply_to":"da9df570_d4ba4e09","updated":"2014-09-24 13:09:44.000000000","message":"Previous way included all the properties and fields, even if they were not modified. This one returns only the modified ones (and additionally the deleted extra_properties), so the DB layer may created better update queries.","commit_id":"a8604a80f4a8b3194851c126db2309b6440f837f"},{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"d33fc1fbc16dcd6aaf29eaba19d649770edd5b99","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        img[\"properties\"] \u003d {}"},{"line_number":151,"context_line":"        for prop in image.extra_properties.modified:"},{"line_number":152,"context_line":"            img[\"properties\"][prop] \u003d image.extra_properties[prop]"},{"line_number":153,"context_line":"        return img, image.extra_properties.deleted"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def add(self, image):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_4ae69716","line":152,"in_reply_to":"da9df570_d4ffaea8","updated":"2014-09-25 10:55:34.000000000","message":"(After giving this a second thought): probably you are right and we may leave this serialization as it was, but rather remove the un-modified properties from the update query in image_update logic)","commit_id":"a8604a80f4a8b3194851c126db2309b6440f837f"}]}