)]}'
{"glance/api/v2/image_data.py":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"9bc0a90233289ef32695c88c2395ac9733a037ea","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                                           utils.exception_to_str(e))"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        except glance_store.StoreAddDisabled:"},{"line_number":102,"context_line":"            msg \u003d _(\"Error in store configuration. Adding images to store \""},{"line_number":103,"context_line":"                    \"is disabled.\")"},{"line_number":104,"context_line":"            LOG.error(msg)"},{"line_number":105,"context_line":"            self._restore(image_repo, image)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_9daeef96","line":102,"updated":"2014-09-26 07:22:10.000000000","message":"(nit): pls use this string as the msg for v1 change, they are different.","commit_id":"dfc6baa546797f42284f2598291bfcb0a94bd45d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e9e998ce65bc56b0cbf7ad1c21a3825039041d5b","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                                           utils.exception_to_str(e))"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        except glance_store.StoreAddDisabled:"},{"line_number":102,"context_line":"            msg \u003d _(\"Error in store configuration. Adding images to store \""},{"line_number":103,"context_line":"                    \"is disabled.\")"},{"line_number":104,"context_line":"            LOG.error(msg)"},{"line_number":105,"context_line":"            self._restore(image_repo, image)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_2c722f11","line":102,"in_reply_to":"da9df570_9daeef96","updated":"2014-09-26 11:08:11.000000000","message":"Done","commit_id":"dfc6baa546797f42284f2598291bfcb0a94bd45d"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"ca9ea4db286e15e17dee575d8b2c72b07ba6e217","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        except glance_store.StoreAddDisabled:"},{"line_number":102,"context_line":"            msg \u003d _(\"Error in store configuration. Adding images to store \""},{"line_number":103,"context_line":"                    \"is disabled.\")"},{"line_number":104,"context_line":"            LOG.error(msg)"},{"line_number":105,"context_line":"            self._restore(image_repo, image)"},{"line_number":106,"context_line":"            raise webob.exc.HTTPGone(explanation\u003dmsg, request\u003dreq,"},{"line_number":107,"context_line":"                                     content_type\u003d\u0027text/plain\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_0318de1c","line":104,"updated":"2014-09-26 08:47:16.000000000","message":"Also please be consistent with the Logging. I think the LOG.exception() is the right way to go here as well.","commit_id":"dfc6baa546797f42284f2598291bfcb0a94bd45d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e9e998ce65bc56b0cbf7ad1c21a3825039041d5b","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        except glance_store.StoreAddDisabled:"},{"line_number":102,"context_line":"            msg \u003d _(\"Error in store configuration. Adding images to store \""},{"line_number":103,"context_line":"                    \"is disabled.\")"},{"line_number":104,"context_line":"            LOG.error(msg)"},{"line_number":105,"context_line":"            self._restore(image_repo, image)"},{"line_number":106,"context_line":"            raise webob.exc.HTTPGone(explanation\u003dmsg, request\u003dreq,"},{"line_number":107,"context_line":"                                     content_type\u003d\u0027text/plain\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_4c62133f","line":104,"in_reply_to":"da9df570_0318de1c","updated":"2014-09-26 11:08:11.000000000","message":"Done","commit_id":"dfc6baa546797f42284f2598291bfcb0a94bd45d"}],"glance/tests/unit/v1/test_api.py":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"9bc0a90233289ef32695c88c2395ac9733a037ea","unresolved":false,"context_lines":[{"line_number":1536,"context_line":"            req.headers[\u0027Content-Type\u0027] \u003d \u0027application/octet-stream\u0027"},{"line_number":1537,"context_line":"            req.body \u003d \"chunk00000remainder\""},{"line_number":1538,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":1539,"context_line":"            self.assertEqual(res.status_int, 410)"},{"line_number":1540,"context_line":""},{"line_number":1541,"context_line":"    def _get_image_status(self, image_id):"},{"line_number":1542,"context_line":"        req \u003d webob.Request.blank(\"/images/%s\" % image_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_3d8a631b","line":1539,"updated":"2014-09-26 07:22:10.000000000","message":"self.assertEqual(410, res.status_int)","commit_id":"dfc6baa546797f42284f2598291bfcb0a94bd45d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e9e998ce65bc56b0cbf7ad1c21a3825039041d5b","unresolved":false,"context_lines":[{"line_number":1536,"context_line":"            req.headers[\u0027Content-Type\u0027] \u003d \u0027application/octet-stream\u0027"},{"line_number":1537,"context_line":"            req.body \u003d \"chunk00000remainder\""},{"line_number":1538,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":1539,"context_line":"            self.assertEqual(res.status_int, 410)"},{"line_number":1540,"context_line":""},{"line_number":1541,"context_line":"    def _get_image_status(self, image_id):"},{"line_number":1542,"context_line":"        req \u003d webob.Request.blank(\"/images/%s\" % image_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_6c67d74d","line":1539,"in_reply_to":"da9df570_3d8a631b","updated":"2014-09-26 11:08:11.000000000","message":"Done","commit_id":"dfc6baa546797f42284f2598291bfcb0a94bd45d"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"9bc0a90233289ef32695c88c2395ac9733a037ea","unresolved":false,"context_lines":[{"line_number":1537,"context_line":"            req.body \u003d \"chunk00000remainder\""},{"line_number":1538,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":1539,"context_line":"            self.assertEqual(res.status_int, 410)"},{"line_number":1540,"context_line":""},{"line_number":1541,"context_line":"    def _get_image_status(self, image_id):"},{"line_number":1542,"context_line":"        req \u003d webob.Request.blank(\"/images/%s\" % image_id)"},{"line_number":1543,"context_line":"        req.method \u003d \u0027HEAD\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_9d850f09","line":1540,"updated":"2014-09-26 07:22:10.000000000","message":"And I prefer to check image status under \u0027killed\u0027 now as well.","commit_id":"dfc6baa546797f42284f2598291bfcb0a94bd45d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e9e998ce65bc56b0cbf7ad1c21a3825039041d5b","unresolved":false,"context_lines":[{"line_number":1537,"context_line":"            req.body \u003d \"chunk00000remainder\""},{"line_number":1538,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":1539,"context_line":"            self.assertEqual(res.status_int, 410)"},{"line_number":1540,"context_line":""},{"line_number":1541,"context_line":"    def _get_image_status(self, image_id):"},{"line_number":1542,"context_line":"        req \u003d webob.Request.blank(\"/images/%s\" % image_id)"},{"line_number":1543,"context_line":"        req.method \u003d \u0027HEAD\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_ac5d3f7b","line":1540,"in_reply_to":"da9df570_9d850f09","updated":"2014-09-26 11:08:11.000000000","message":"Done","commit_id":"dfc6baa546797f42284f2598291bfcb0a94bd45d"}],"glance/tests/unit/v1/test_upload_utils.py":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"9bc0a90233289ef32695c88c2395ac9733a037ea","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        \"\"\"Test StoreDisabled exception is raised while uploading data\"\"\""},{"line_number":200,"context_line":"        self._test_upload_data_to_store_exception_with_notify("},{"line_number":201,"context_line":"            glance_store.StoreAddDisabled,"},{"line_number":202,"context_line":"            webob.exc.HTTPGone)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def test_upload_data_to_store_duplicate(self):"},{"line_number":205,"context_line":"        \"\"\"See note in glance.api.v1.upload_utils on why we don\u0027t want image to"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_5d964740","line":202,"updated":"2014-09-26 07:22:10.000000000","message":", image_killed\u003dTrue)","commit_id":"dfc6baa546797f42284f2598291bfcb0a94bd45d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e9e998ce65bc56b0cbf7ad1c21a3825039041d5b","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        \"\"\"Test StoreDisabled exception is raised while uploading data\"\"\""},{"line_number":200,"context_line":"        self._test_upload_data_to_store_exception_with_notify("},{"line_number":201,"context_line":"            glance_store.StoreAddDisabled,"},{"line_number":202,"context_line":"            webob.exc.HTTPGone)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def test_upload_data_to_store_duplicate(self):"},{"line_number":205,"context_line":"        \"\"\"See note in glance.api.v1.upload_utils on why we don\u0027t want image to"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_ec52e765","line":202,"in_reply_to":"da9df570_5d964740","updated":"2014-09-26 11:08:11.000000000","message":"Done","commit_id":"dfc6baa546797f42284f2598291bfcb0a94bd45d"}]}