)]}'
{"glance/api/v1/images.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"0d2c52f959e6d4a6ca03742e308d961d66a9d508","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        else:"},{"line_number":605,"context_line":"            location \u003d image_meta.get(\u0027location\u0027)"},{"line_number":606,"context_line":"            if location:"},{"line_number":607,"context_line":"                image_meta \u003d self._activate(req, image_id, location)"},{"line_number":608,"context_line":"        return image_meta"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"    def _validate_image_for_upload(self, req, id, values):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FffY%3D","line":607,"updated":"2012-09-06 15:38:00.000000000","message":"In this branch, the lack of a pre-upload validation when the image is identified via an external (non-copy) location, means that we could create an active image without container or disk format being set.\n\n(Previously not possible IIUC)","commit_id":"688d374fb3d67bd828e08fb7380000140607d8d6"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"6409713c3ed90a87900520e3f87622575706893c","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        else:"},{"line_number":605,"context_line":"            location \u003d image_meta.get(\u0027location\u0027)"},{"line_number":606,"context_line":"            if location:"},{"line_number":607,"context_line":"                image_meta \u003d self._activate(req, image_id, location)"},{"line_number":608,"context_line":"        return image_meta"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"    def _validate_image_for_upload(self, req, id, values):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FfeM%3D","line":607,"in_reply_to":"AAAALH%2F%2FffY%3D","updated":"2012-09-06 15:51:14.000000000","message":"Your absolutely right, I had that thought at some point and completely forgot. On it","commit_id":"688d374fb3d67bd828e08fb7380000140607d8d6"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"0d2c52f959e6d4a6ca03742e308d961d66a9d508","unresolved":false,"context_lines":[{"line_number":698,"context_line":"        if is_public:"},{"line_number":699,"context_line":"            self._enforce(req, \u0027publicize_image\u0027)"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        image_meta \u003d validate_image_meta(req, image_meta)"},{"line_number":702,"context_line":"        orig_image_meta \u003d self.get_image_meta_or_404(req, id)"},{"line_number":703,"context_line":"        orig_status \u003d orig_image_meta[\u0027status\u0027]"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fffo%3D","line":701,"updated":"2012-09-06 15:38:00.000000000","message":"Wouldn\u0027t the validation have already occurred in the deserializer in the update case?","commit_id":"688d374fb3d67bd828e08fb7380000140607d8d6"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"6409713c3ed90a87900520e3f87622575706893c","unresolved":false,"context_lines":[{"line_number":698,"context_line":"        if is_public:"},{"line_number":699,"context_line":"            self._enforce(req, \u0027publicize_image\u0027)"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        image_meta \u003d validate_image_meta(req, image_meta)"},{"line_number":702,"context_line":"        orig_image_meta \u003d self.get_image_meta_or_404(req, id)"},{"line_number":703,"context_line":"        orig_status \u003d orig_image_meta[\u0027status\u0027]"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Ffd8%3D","line":701,"in_reply_to":"AAAALH%2F%2Fffo%3D","updated":"2012-09-06 15:51:14.000000000","message":"Yes, forgot to delete it when refactoring.","commit_id":"688d374fb3d67bd828e08fb7380000140607d8d6"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"09585ec79feb851b888035fd29e8cad2d146d996","unresolved":false,"context_lines":[{"line_number":608,"context_line":"                image_meta \u003d self._activate(req, image_id, location)"},{"line_number":609,"context_line":"        return image_meta"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"    def _validate_image_for_upload(self, req, id, values):"},{"line_number":612,"context_line":"        \"\"\"Ensures that all required image metadata values are valid.\"\"\""},{"line_number":613,"context_line":"        image \u003d self.get_image_meta_or_404(req, id)"},{"line_number":614,"context_line":"        if not \u0027disk_format\u0027 in values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fem0%3D","line":611,"updated":"2012-09-07 14:30:18.000000000","message":"For clarity, would it make sense to rename this method to drop the upload connotation, now that its also called in the external location case? (which doesn\u0027t involve an actual upload)","commit_id":"d31a34a420bf0882570fbf9626a5a981665222a4"}],"glance/tests/unit/test_clients.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"0d2c52f959e6d4a6ca03742e308d961d66a9d508","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"        data \u003d self.client.get_image(new_image[\u0027id\u0027])"},{"line_number":1075,"context_line":"        self.assertEquals(name, data[\u0027name\u0027])"},{"line_number":1076,"context_line":""},{"line_number":1077,"context_line":"    def test_add_image_with_excessively_long_name(self):"},{"line_number":1078,"context_line":"        \"\"\"Tests adding image with excessively long name\"\"\""},{"line_number":1079,"context_line":"        name \u003d \u0027x\u0027 * 256"},{"line_number":1080,"context_line":"        fixture \u003d {\u0027name\u0027: name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FffE%3D","side":"PARENT","line":1077,"updated":"2012-09-06 15:38:00.000000000","message":"Have we lost the long name test coverage?","commit_id":"3d4e962dac2a307f3f6f9c98fc85fe51a55f4367"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"6409713c3ed90a87900520e3f87622575706893c","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"        data \u003d self.client.get_image(new_image[\u0027id\u0027])"},{"line_number":1075,"context_line":"        self.assertEquals(name, data[\u0027name\u0027])"},{"line_number":1076,"context_line":""},{"line_number":1077,"context_line":"    def test_add_image_with_excessively_long_name(self):"},{"line_number":1078,"context_line":"        \"\"\"Tests adding image with excessively long name\"\"\""},{"line_number":1079,"context_line":"        name \u003d \u0027x\u0027 * 256"},{"line_number":1080,"context_line":"        fixture \u003d {\u0027name\u0027: name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Ffd4%3D","side":"PARENT","line":1077,"in_reply_to":"AAAALH%2F%2FffE%3D","updated":"2012-09-06 15:51:14.000000000","message":"I added a test in test_api, the validation is no longer in the registry layer so we can\u0027t have the test here.","commit_id":"3d4e962dac2a307f3f6f9c98fc85fe51a55f4367"}]}