)]}'
{"glance/common/wsgi.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"0d4b71d226be25fe771e7ebbe581cf030cfd5bd2","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                self.run_child()"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def create_pool(self):"},{"line_number":208,"context_line":"        eventlet.patcher.monkey_patch(all\u003dFalse, socket\u003dTrue)"},{"line_number":209,"context_line":"        return eventlet.GreenPool(size\u003dself.threads)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def wait_on_children(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FWf0%3D","line":208,"updated":"2012-09-19 11:59:26.000000000","message":"This is unrelated to your patch, but I wonder if there is a good reason not to use all\u003dTrue here.  It could potentially avoid problems in the future.","commit_id":"8f42dacecd713970c31d59a81fe1f9056e28196c"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"9bbecaceeef1695d0801d8c4eb8e504435c10ecc","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                self.run_child()"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def create_pool(self):"},{"line_number":208,"context_line":"        eventlet.patcher.monkey_patch(all\u003dFalse, socket\u003dTrue)"},{"line_number":209,"context_line":"        return eventlet.GreenPool(size\u003dself.threads)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def wait_on_children(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FWTg%3D","line":208,"in_reply_to":"AAAALH%2F%2FWTo%3D","updated":"2012-09-19 17:14:11.000000000","message":"Bah, you\u0027re right. I was thinking we were calling create_pool per request. Silly me.","commit_id":"8f42dacecd713970c31d59a81fe1f9056e28196c"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"e51b23971fadfbfe45a5cdacd45cbeeeb1ccfd14","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                self.run_child()"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def create_pool(self):"},{"line_number":208,"context_line":"        eventlet.patcher.monkey_patch(all\u003dFalse, socket\u003dTrue)"},{"line_number":209,"context_line":"        return eventlet.GreenPool(size\u003dself.threads)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def wait_on_children(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FWTo%3D","line":208,"in_reply_to":"AAAALH%2F%2FWUQ%3D","updated":"2012-09-19 17:09:36.000000000","message":"My reading of the code is that we only call create_pool once per process actually servicing requests, and never in the parent process when workers \u003e 0.\n\nSince its not needed in the latter case, seems logical to avoid it.","commit_id":"8f42dacecd713970c31d59a81fe1f9056e28196c"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"faa6a340d73d7991fc44a7ab39c1fa8ae497ce7c","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                self.run_child()"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def create_pool(self):"},{"line_number":208,"context_line":"        eventlet.patcher.monkey_patch(all\u003dFalse, socket\u003dTrue)"},{"line_number":209,"context_line":"        return eventlet.GreenPool(size\u003dself.threads)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def wait_on_children(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FWUQ%3D","line":208,"in_reply_to":"AAAALH%2F%2FWe8%3D","updated":"2012-09-19 16:51:45.000000000","message":"We don\u0027t need to monkey_patch every time you call create_pool, its typically already called by the time we get here IIRC. Can you check on that? At a minimum, we could just monkey_patch at the top of this file.","commit_id":"8f42dacecd713970c31d59a81fe1f9056e28196c"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"ab3f00caeccaa0aeee567092f5809f219d20fe7a","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                self.run_child()"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def create_pool(self):"},{"line_number":208,"context_line":"        eventlet.patcher.monkey_patch(all\u003dFalse, socket\u003dTrue)"},{"line_number":209,"context_line":"        return eventlet.GreenPool(size\u003dself.threads)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def wait_on_children(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FWfE%3D","line":208,"in_reply_to":"AAAALH%2F%2FWf0%3D","updated":"2012-09-19 12:24:02.000000000","message":"Yep, that occurred to me too.\n\nBut applying the principle of least change given the lateness in the release cycle, I opted to be conservative and just leave the monkey-patch scoping as-was.","commit_id":"8f42dacecd713970c31d59a81fe1f9056e28196c"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"6f4b345275284874b107e3da8a0006cb21f56315","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                self.run_child()"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def create_pool(self):"},{"line_number":208,"context_line":"        eventlet.patcher.monkey_patch(all\u003dFalse, socket\u003dTrue)"},{"line_number":209,"context_line":"        return eventlet.GreenPool(size\u003dself.threads)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def wait_on_children(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FWe8%3D","line":208,"in_reply_to":"AAAALH%2F%2FWfE%3D","updated":"2012-09-19 12:28:23.000000000","message":"Makes sense!","commit_id":"8f42dacecd713970c31d59a81fe1f9056e28196c"}]}