)]}'
{"glance/tests/functional/__init__.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"18c56b10f524c92ed7a1c45e936779d8734d66b8","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        self.key_file \u003d \"\""},{"line_number":201,"context_line":"        self.cert_file \u003d \"\""},{"line_number":202,"context_line":"        self.metadata_encryption_key \u003d \"012345678901234567890123456789ab\""},{"line_number":203,"context_line":"        self.image_dir \u003d os.path.join(self.test_dir, \"images\")"},{"line_number":204,"context_line":"        self.pid_file \u003d pid_file or os.path.join(self.test_dir,"},{"line_number":205,"context_line":"                                                 \"api.pid\")"},{"line_number":206,"context_line":"        self.scrubber_datadir \u003d os.path.join(self.test_dir,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FNQk%3D","line":203,"updated":"2012-10-04 21:55:35.000000000","message":"please don\u0027t make this change here. doesn\u0027t seem to change concerned logic.","commit_id":"c95b5612a83288654eda3ec2d0601bdf58904d7b"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"18c56b10f524c92ed7a1c45e936779d8734d66b8","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        self.sql_connection \u003d os.environ.get(\u0027GLANCE_TEST_SQL_CONNECTION\u0027,"},{"line_number":366,"context_line":"                                             default_sql_connection)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        self.pid_file \u003d os.path.join(self.test_dir, \"registry.pid\")"},{"line_number":369,"context_line":"        self.log_file \u003d os.path.join(self.test_dir, \"registry.log\")"},{"line_number":370,"context_line":"        self.owner_is_tenant \u003d True"},{"line_number":371,"context_line":"        self.server_control_options \u003d \u0027--capture-output\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FNQg%3D","line":368,"updated":"2012-10-04 21:55:35.000000000","message":"same as above","commit_id":"c95b5612a83288654eda3ec2d0601bdf58904d7b"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"2ec1dafaff801ed583935d5d212cc759175bd4a0","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                                             \"scrubber\")"},{"line_number":421,"context_line":"        self.pid_file \u003d os.path.join(self.test_dir, \"scrubber.pid\")"},{"line_number":422,"context_line":"        self.log_file \u003d os.path.join(self.test_dir, \"scrubber.log\")"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        self.swift_store_auth_address \u003d kwargs.get(\"swift_store_auth_address\")"},{"line_number":425,"context_line":"        self.swift_store_user \u003d kwargs.get(\"swift_store_user\")"},{"line_number":426,"context_line":"        self.swift_store_key \u003d kwargs.get(\"swift_store_key\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FLIc%3D","line":423,"updated":"2012-10-09 12:04:41.000000000","message":"do we need blank line here?","commit_id":"2b4dc32e218864a63ecc48ad25de0f7eb16dbd2e"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"2ec1dafaff801ed583935d5d212cc759175bd4a0","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        self.swift_store_container \u003d kwargs.get(\"swift_store_container\")"},{"line_number":428,"context_line":"        self.swift_store_auth_version \u003d (kwargs.get(\"swift_store_auth_version\")"},{"line_number":429,"context_line":"                                         or \"2\")"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"        self.conf_base \u003d \"\"\"[DEFAULT]"},{"line_number":432,"context_line":"verbose \u003d %(verbose)s"},{"line_number":433,"context_line":"debug \u003d %(debug)s"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FLIY%3D","line":430,"updated":"2012-10-09 12:04:41.000000000","message":"ditto","commit_id":"2b4dc32e218864a63ecc48ad25de0f7eb16dbd2e"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"68bacd4e406aaa5eece924577e28e2388b6a1268","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        self.s3_store_bucket_url_format \u003d \"\""},{"line_number":212,"context_line":"        self.swift_store_auth_version \u003d (kwargs.get(\"swift_store_auth_version\")"},{"line_number":213,"context_line":"                                         or \"2\")"},{"line_number":214,"context_line":"        self.swift_store_auth_address \u003d kwargs.get(\"swift_store_auth_address\")"},{"line_number":215,"context_line":"        self.swift_store_user \u003d kwargs.get(\"swift_store_user\")"},{"line_number":216,"context_line":"        self.swift_store_key \u003d kwargs.get(\"swift_store_key\")"},{"line_number":217,"context_line":"        self.swift_store_container \u003d kwargs.get(\"swift_store_container\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALn%2F%2F%2B7g%3D","line":214,"updated":"2012-10-23 14:59:27.000000000","message":"Same concerns as below","commit_id":"c52ff0213932634b6edf60654a931aa14ba2fdbe"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"68bacd4e406aaa5eece924577e28e2388b6a1268","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                                             \"scrubber\")"},{"line_number":421,"context_line":"        self.pid_file \u003d os.path.join(self.test_dir, \"scrubber.pid\")"},{"line_number":422,"context_line":"        self.log_file \u003d os.path.join(self.test_dir, \"scrubber.log\")"},{"line_number":423,"context_line":"        self.swift_store_auth_address \u003d kwargs.get(\"swift_store_auth_address\")"},{"line_number":424,"context_line":"        self.swift_store_user \u003d kwargs.get(\"swift_store_user\")"},{"line_number":425,"context_line":"        self.swift_store_key \u003d kwargs.get(\"swift_store_key\")"},{"line_number":426,"context_line":"        self.swift_store_container \u003d kwargs.get(\"swift_store_container\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALn%2F%2F%2B7o%3D","line":423,"updated":"2012-10-23 14:59:27.000000000","message":"Should each of these be set to \"\" by default instead of None? My concern is if they aren\u0027t set then the config value would be \"None\". It may not really matter","commit_id":"c52ff0213932634b6edf60654a931aa14ba2fdbe"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"68bacd4e406aaa5eece924577e28e2388b6a1268","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        self.swift_store_user \u003d kwargs.get(\"swift_store_user\")"},{"line_number":425,"context_line":"        self.swift_store_key \u003d kwargs.get(\"swift_store_key\")"},{"line_number":426,"context_line":"        self.swift_store_container \u003d kwargs.get(\"swift_store_container\")"},{"line_number":427,"context_line":"        self.swift_store_auth_version \u003d (kwargs.get(\"swift_store_auth_version\")"},{"line_number":428,"context_line":"                                         or \"2\")"},{"line_number":429,"context_line":"        self.conf_base \u003d \"\"\"[DEFAULT]"},{"line_number":430,"context_line":"verbose \u003d %(verbose)s"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALn%2F%2F%2B8I%3D","line":427,"updated":"2012-10-23 14:59:27.000000000","message":"this could be kwargs.get(\"swift_store_auth_version\", \"2\")","commit_id":"c52ff0213932634b6edf60654a931aa14ba2fdbe"}],"glance/tests/functional/test_scrubber.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"18c56b10f524c92ed7a1c45e936779d8734d66b8","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from glance.tests import functional"},{"line_number":27,"context_line":"from glance.tests.utils import execute"},{"line_number":28,"context_line":"from glance.tests.functional.store.test_swift import read_config"},{"line_number":29,"context_line":"from glance.tests.functional.store.test_swift import parse_config"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"TEST_IMAGE_DATA \u003d \u0027*\u0027 * 5 * 1024"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FNPQ%3D","line":28,"updated":"2012-10-04 21:55:35.000000000","message":"this should go before the from glance.tests.utils import execute\n\ni think the correct order would be:-\n\nfrom glance.tests import functional\nfrom glance.tests.functional.store.test_swift import parse_config\nfrom glance.tests.functional.store.test_swift import read_config\nfrom glance.tests.utils import execute","commit_id":"c95b5612a83288654eda3ec2d0601bdf58904d7b"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"18c56b10f524c92ed7a1c45e936779d8734d66b8","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            response, content \u003d http.request(path, \u0027HEAD\u0027)"},{"line_number":84,"context_line":"            if (response[\u0027x-image-meta-status\u0027] \u003d\u003d \u0027deleted\u0027 and"},{"line_number":85,"context_line":"                    response[\u0027x-image-meta-deleted\u0027] \u003d\u003d \u0027True\u0027):"},{"line_number":86,"context_line":"                break"},{"line_number":87,"context_line":"            else:"},{"line_number":88,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FNPM%3D","line":85,"updated":"2012-10-04 21:55:35.000000000","message":"please dont make these whitespaces and backslashes changes here. I would encourage to have a separate bug for glance related stuff and fix these","commit_id":"c95b5612a83288654eda3ec2d0601bdf58904d7b"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"18c56b10f524c92ed7a1c45e936779d8734d66b8","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            time.sleep(5)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"            response, content \u003d http.request(path, \u0027HEAD\u0027)"},{"line_number":145,"context_line":"            if (response[\u0027x-image-meta-status\u0027] \u003d\u003d \u0027deleted\u0027 and"},{"line_number":146,"context_line":"                    response[\u0027x-image-meta-deleted\u0027] \u003d\u003d \u0027True\u0027):"},{"line_number":147,"context_line":"                break"},{"line_number":148,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FNPI%3D","line":145,"updated":"2012-10-04 21:55:35.000000000","message":"same as above","commit_id":"c95b5612a83288654eda3ec2d0601bdf58904d7b"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"2ec1dafaff801ed583935d5d212cc759175bd4a0","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            \u0027x-image-meta-disk_format\u0027: \u0027raw\u0027,"},{"line_number":177,"context_line":"            \u0027x-image-meta-container_format\u0027: \u0027ovf\u0027,"},{"line_number":178,"context_line":"            \u0027content-type\u0027: \u0027application/octet-stream\u0027,"},{"line_number":179,"context_line":"        }"},{"line_number":180,"context_line":"        path \u003d \"http://%s:%d/v1/images\" % (\"127.0.0.1\", self.api_port)"},{"line_number":181,"context_line":"        http \u003d httplib2.Http()"},{"line_number":182,"context_line":"        response, content \u003d http.request(path, \u0027POST\u0027, body\u003d\u0027XXX\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FLIQ%3D","line":179,"updated":"2012-10-09 12:04:41.000000000","message":"can you add a comment here mentioning what these requests are about?","commit_id":"2b4dc32e218864a63ecc48ad25de0f7eb16dbd2e"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"2ec1dafaff801ed583935d5d212cc759175bd4a0","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        image \u003d json.loads(content)[\u0027image\u0027]"},{"line_number":186,"context_line":"        self.assertEqual(\u0027active\u0027, image[\u0027status\u0027])"},{"line_number":187,"context_line":"        image_id \u003d image[\u0027id\u0027]"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        path \u003d \"http://%s:%d/v1/images/%s\" % (\"127.0.0.1\", self.api_port,"},{"line_number":190,"context_line":"                                              image_id)"},{"line_number":191,"context_line":"        http \u003d httplib2.Http()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FLIM%3D","line":188,"updated":"2012-10-09 12:04:41.000000000","message":"ditto","commit_id":"2b4dc32e218864a63ecc48ad25de0f7eb16dbd2e"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"2ec1dafaff801ed583935d5d212cc759175bd4a0","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        #                deleted, bail immediatly."},{"line_number":212,"context_line":"        for _ in xrange(3):"},{"line_number":213,"context_line":"            time.sleep(5)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"            response, content \u003d http.request(path, \u0027HEAD\u0027)"},{"line_number":216,"context_line":"            if (response[\u0027x-image-meta-status\u0027] \u003d\u003d \u0027deleted\u0027 and"},{"line_number":217,"context_line":"                    response[\u0027x-image-meta-deleted\u0027] \u003d\u003d \u0027True\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FLIU%3D","line":214,"updated":"2012-10-09 12:04:41.000000000","message":"is this blank line necessary?","commit_id":"2b4dc32e218864a63ecc48ad25de0f7eb16dbd2e"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"f86760f9b9da3c16c65254d69c49e9c23164e342","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import time"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import httplib2"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import nose.plugins.skip"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from glance.tests import functional"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALH%2F%2FHpE%3D","line":23,"updated":"2012-10-15 17:21:27.000000000","message":"You don\u0027t need this newline.","commit_id":"5b317c01447ffcb593236316e859f912910d644c"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"f86760f9b9da3c16c65254d69c49e9c23164e342","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import httplib2"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import nose.plugins.skip"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from glance.tests import functional"},{"line_number":27,"context_line":"from glance.tests.functional.store.test_swift import parse_config"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALH%2F%2FHpA%3D","line":24,"updated":"2012-10-15 17:21:27.000000000","message":"I notice this import isn\u0027t used directly. Is it just needed for nose.SkipTest to work properly?","commit_id":"5b317c01447ffcb593236316e859f912910d644c"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"4a5f51382a07527aaf90d3dcc6f0db123a344e89","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2011 OpenStack, LLC"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAALH%2F%2FHbA%3D","line":2,"updated":"2012-10-16 15:27:28.000000000","message":"can we change this to 2012 now?","commit_id":"10dff3d81e6d31d5829c174f09180cfbbb0d29cc"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"e3cb671fef500a2ac389d19367473b495fff9b8e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2011 OpenStack, LLC"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAALn%2F%2F%2Fus%3D","line":2,"in_reply_to":"AAAALH%2F%2FHW4%3D","updated":"2012-10-22 15:58:42.000000000","message":"Hi Nikil,\n\nRather than changing \"2011\" to \"2012\", should we instead change it to \"2011-2012\"? (As far as I can tell that seems to be what\u0027s typically done in this situation.)","commit_id":"10dff3d81e6d31d5829c174f09180cfbbb0d29cc"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"c074ecfca695a495da9aa2654a6b7f07ee28da1d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2011 OpenStack, LLC"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAALH%2F%2FHW4%3D","line":2,"in_reply_to":"AAAALH%2F%2FHa0%3D","updated":"2012-10-16 18:36:23.000000000","message":"Well, I guess unlike pep8, to me its relevant and necessary here; as a new logic and considerable change in the test file is being pushed in. Unless there are some process guidelines to handle such IP changes, we should be okay.","commit_id":"10dff3d81e6d31d5829c174f09180cfbbb0d29cc"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"a21ee30060c3d011a04b0ef60e09ac4914aa5772","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2011 OpenStack, LLC"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAALH%2F%2FHa0%3D","line":2,"in_reply_to":"AAAALH%2F%2FHbA%3D","updated":"2012-10-16 15:29:15.000000000","message":"I can if you like, but much like the earlier rejected pep8 changes, it\u0027s not really pertinent to this patchset?","commit_id":"10dff3d81e6d31d5829c174f09180cfbbb0d29cc"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"d672d89b0559956f52720e9e73f380de05f08b0c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2011 OpenStack, LLC"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAALn%2F%2F%2Ft0%3D","line":2,"in_reply_to":"AAAALn%2F%2F%2Fus%3D","updated":"2012-10-22 16:08:43.000000000","message":"Yep, that\u0027s preferable.","commit_id":"10dff3d81e6d31d5829c174f09180cfbbb0d29cc"}]}