)]}'
{"glance/common/cfg.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"da68ce45f216af1197ff6db82da1d8981448ca8d","unresolved":false,"context_lines":[{"line_number":1120,"context_line":"                help\u003d\u0027Use syslog for logging.\u0027),"},{"line_number":1121,"context_line":"        StrOpt(\u0027log-facility\u0027,"},{"line_number":1122,"context_line":"               default\u003d\u0027LOG_USER\u0027,"},{"line_number":1123,"context_line":"               help\u003d\u0027syslog facility to receive log lines\u0027)"},{"line_number":1124,"context_line":"        ]"},{"line_number":1125,"context_line":""},{"line_number":1126,"context_line":"    def __init__(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAADH%2F%2F%2FVY%3D","line":1123,"updated":"2011-12-30 20:04:12.000000000","message":"Can we set the above option name to syslog-log-facility to ensure it is obvious we are only referring to syslog functionality here?","commit_id":"72a5eab66f9f04c4b942ccccc09de20e7ad5817a"}],"glance/common/config.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"66c2304e03d09cc51263717846b6a5df994651b1","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    if use_syslog:"},{"line_number":169,"context_line":"        facility \u003d getattr(logging.handlers.SysLogHandler,"},{"line_number":170,"context_line":"                           get_option(conf, \u0027log_facility\u0027, type\u003d\u0027string\u0027,"},{"line_number":171,"context_line":"                                      default\u003d\u0027LOG_USER\u0027))"},{"line_number":172,"context_line":"        handler \u003d logging.handlers.SysLogHandler(address\u003d\u0027/dev/log\u0027,"},{"line_number":173,"context_line":"                                                 facility\u003dfacility)"},{"line_number":174,"context_line":"    elif logfile:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACX%2F%2F3o8%3D","line":171,"updated":"2011-11-08 16:11:28.000000000","message":"Absolutely for this change, just thinking the default here should match the default in one of the config files?","commit_id":"8e60c32b1fd39ae3b944f31ee09bf9b6c1b0bcc8"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"f9b5b33aa8e13670c5a45c14f01d0e55dc70c891","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    if use_syslog:"},{"line_number":169,"context_line":"        facility \u003d getattr(logging.handlers.SysLogHandler,"},{"line_number":170,"context_line":"                           get_option(conf, \u0027log_facility\u0027, type\u003d\u0027string\u0027,"},{"line_number":171,"context_line":"                                      default\u003d\u0027LOG_USER\u0027))"},{"line_number":172,"context_line":"        handler \u003d logging.handlers.SysLogHandler(address\u003d\u0027/dev/log\u0027,"},{"line_number":173,"context_line":"                                                 facility\u003dfacility)"},{"line_number":174,"context_line":"    elif logfile:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACX%2F%2F3oI%3D","line":171,"in_reply_to":"AAAACX%2F%2F3o8%3D","updated":"2011-11-08 16:33:56.000000000","message":"Hi Brian. I have left the log_facility commented out in the config files, which means it defaults to LOG_USER, ie:\n\n# log_faciltiy \u003d LOG_LOCAL0\n\nJust to clarify ... is that ok ... or you\u0027d prefer one of the following?\n\n# log_facility \u003d LOG_USER \n\nor\n\nlog_facility \u003d LOG_USER","commit_id":"8e60c32b1fd39ae3b944f31ee09bf9b6c1b0bcc8"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"9c27f91ca2bc72433b7fcef092afd9a4545af231","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    if use_syslog:"},{"line_number":169,"context_line":"        facility \u003d getattr(logging.handlers.SysLogHandler,"},{"line_number":170,"context_line":"                           get_option(conf, \u0027log_facility\u0027, type\u003d\u0027string\u0027,"},{"line_number":171,"context_line":"                                      default\u003d\u0027LOG_USER\u0027))"},{"line_number":172,"context_line":"        handler \u003d logging.handlers.SysLogHandler(address\u003d\u0027/dev/log\u0027,"},{"line_number":173,"context_line":"                                                 facility\u003dfacility)"},{"line_number":174,"context_line":"    elif logfile:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACX%2F%2F3nc%3D","line":171,"in_reply_to":"AAAACX%2F%2F3oI%3D","updated":"2011-11-08 16:40:37.000000000","message":"I would prefer to see LOG_USER commented out in the config files. And can you add the same lines to glance-cache.conf and glance-scrubber.conf?","commit_id":"8e60c32b1fd39ae3b944f31ee09bf9b6c1b0bcc8"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"da68ce45f216af1197ff6db82da1d8981448ca8d","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    if conf.use_syslog:"},{"line_number":79,"context_line":"        facility \u003d getattr(logging.handlers.SysLogHandler,"},{"line_number":80,"context_line":"                           conf.log_facility)"},{"line_number":81,"context_line":"        handler \u003d logging.handlers.SysLogHandler(address\u003d\u0027/dev/log\u0027,"},{"line_number":82,"context_line":"                                                 facility\u003dfacility)"},{"line_number":83,"context_line":"    elif conf.log_file:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAADH%2F%2F%2FVc%3D","line":80,"updated":"2011-12-30 20:04:12.000000000","message":"Can we add a try: except AttributeError: around the above to trap for typos in the log_facility config value?","commit_id":"72a5eab66f9f04c4b942ccccc09de20e7ad5817a"}]}