)]}'
{"glance/api/v1/images.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"107456ead8fd453f56c4c2c3e01fc32cfc8b5e1a","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                return source"},{"line_number":426,"context_line":"            else:"},{"line_number":427,"context_line":"                msg \u003d _(\"External source are not supported: \u0027%s\u0027\") % source"},{"line_number":428,"context_line":"                LOG.debug(msg)"},{"line_number":429,"context_line":"                raise HTTPBadRequest(explanation\u003dmsg,"},{"line_number":430,"context_line":"                                     request\u003dreq,"},{"line_number":431,"context_line":"                                     content_type\u003d\"text/plain\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_407a8588","line":428,"updated":"2014-12-17 09:40:24.000000000","message":"NIT: we should not log translated messages on DEBUG (will propose PS to correct this)","commit_id":"4afdb017aa1ccef01482f117cb8d0736a6da38ed"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"cef024a7f5bf5b63246cb5ef3c26ea2822882581","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                return source"},{"line_number":426,"context_line":"            else:"},{"line_number":427,"context_line":"                msg \u003d _(\"External source are not supported: \u0027%s\u0027\") % source"},{"line_number":428,"context_line":"                LOG.debug(msg)"},{"line_number":429,"context_line":"                raise HTTPBadRequest(explanation\u003dmsg,"},{"line_number":430,"context_line":"                                     request\u003dreq,"},{"line_number":431,"context_line":"                                     content_type\u003d\"text/plain\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_cb380e40","line":428,"in_reply_to":"3a961159_407a8588","updated":"2014-12-17 13:12:09.000000000","message":"Under my plan, I\u0027m using https://review.openstack.org/#/c/141722/ change cover this kind of issue.","commit_id":"4afdb017aa1ccef01482f117cb8d0736a6da38ed"}],"glance/location.py":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"f40d1d329b954cdb88b041f1d0b4f6f81e8ffc72","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        is_ok \u003d (store_utils.validate_external_location(uri) and"},{"line_number":83,"context_line":"                 store_api.get_size_from_backend(uri, context\u003dcontext) \u003e 0)"},{"line_number":84,"context_line":"    except (store.UnknownScheme, store.NotFound):"},{"line_number":85,"context_line":"        is_ok \u003d False"},{"line_number":86,"context_line":"    if not is_ok:"},{"line_number":87,"context_line":"        reason \u003d _(\u0027Invalid location\u0027)"},{"line_number":88,"context_line":"        raise exception.BadStoreUri(message\u003dreason)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_b387de11","line":85,"updated":"2014-12-16 14:46:25.000000000","message":"Minor: store_utils.validate_external_location(uri) will return a HTTPBadRequest so doesn\u0027t need to be part of the is_ok logic?\nI think it works, but just having\nstore_utils.validate_external_location(uri) before the try block might be simpler? Just a style thing really.","commit_id":"4afdb017aa1ccef01482f117cb8d0736a6da38ed"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"a7aa878c03c8bf508f2766b1a79e3817ba212bb7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        is_ok \u003d (store_utils.validate_external_location(uri) and"},{"line_number":83,"context_line":"                 store_api.get_size_from_backend(uri, context\u003dcontext) \u003e 0)"},{"line_number":84,"context_line":"    except (store.UnknownScheme, store.NotFound):"},{"line_number":85,"context_line":"        is_ok \u003d False"},{"line_number":86,"context_line":"    if not is_ok:"},{"line_number":87,"context_line":"        reason \u003d _(\u0027Invalid location\u0027)"},{"line_number":88,"context_line":"        raise exception.BadStoreUri(message\u003dreason)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_8561b4d5","line":85,"in_reply_to":"3a961159_6af49787","updated":"2014-12-16 17:03:35.000000000","message":"Yes, I was confusing _validate_source with validate_external_location - thanks.","commit_id":"4afdb017aa1ccef01482f117cb8d0736a6da38ed"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"89c5fca1061850d0046936018256efbd4bc06e66","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        is_ok \u003d (store_utils.validate_external_location(uri) and"},{"line_number":83,"context_line":"                 store_api.get_size_from_backend(uri, context\u003dcontext) \u003e 0)"},{"line_number":84,"context_line":"    except (store.UnknownScheme, store.NotFound):"},{"line_number":85,"context_line":"        is_ok \u003d False"},{"line_number":86,"context_line":"    if not is_ok:"},{"line_number":87,"context_line":"        reason \u003d _(\u0027Invalid location\u0027)"},{"line_number":88,"context_line":"        raise exception.BadStoreUri(message\u003dreason)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_6af49787","line":85,"in_reply_to":"3a961159_b387de11","updated":"2014-12-16 16:48:37.000000000","message":"Minor but valid if validate_external_location() raise HTTPBadRequest, however validate_external_location() return boolean/False value instead of raising exception directly...","commit_id":"4afdb017aa1ccef01482f117cb8d0736a6da38ed"}]}