)]}'
{"glance/context.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"7f0184323763e5dcca17f15c8f99d6425eeda19e","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __init__(self, roles\u003dNone,"},{"line_number":30,"context_line":"                 owner_is_tenant\u003dTrue, service_catalog\u003dNone,"},{"line_number":31,"context_line":"                 policy_enforcer\u003dNone, **kwargs):"},{"line_number":32,"context_line":"        super(RequestContext, self).__init__(**kwargs)"},{"line_number":33,"context_line":"        self.roles \u003d roles or []"},{"line_number":34,"context_line":"        self.owner_is_tenant \u003d owner_is_tenant"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_d058838c","line":31,"updated":"2015-01-14 12:31:53.000000000","message":"Is there a reason to change these from set parameters to **kwargs?","commit_id":"396e224da1800a1b116f9a144602ac885bf7f0f7"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"8db11dab53e1c4a0d0a5968a98ce3d247cccf46f","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __init__(self, roles\u003dNone,"},{"line_number":30,"context_line":"                 owner_is_tenant\u003dTrue, service_catalog\u003dNone,"},{"line_number":31,"context_line":"                 policy_enforcer\u003dNone, **kwargs):"},{"line_number":32,"context_line":"        super(RequestContext, self).__init__(**kwargs)"},{"line_number":33,"context_line":"        self.roles \u003d roles or []"},{"line_number":34,"context_line":"        self.owner_is_tenant \u003d owner_is_tenant"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_95e4bfa8","line":31,"in_reply_to":"3a961159_229bd373","updated":"2015-01-17 00:02:34.000000000","message":"It\u0027s not entirely clear that the end goal is to remove it entirely from glance. Just to remove the common pieces. I\u0027m not sure ever service has a policy_enforcer, owner_is_tenant, or anything like that. (Although I suspect any one that has a policy_enforcer will also have roles.)\n\nThe reason I didn\u0027t -1 the patchset is because as the list of kwargs that request context handles gets longer, this will quickly become inaccurate. All I\u0027m asking for is a link to the docs. So when I\u0027m spelunking in the future I don\u0027t have to try to figure out if there even are any docs and then figure out if what I want is even documented (and yes I\u0027ve run into this problem with oslo libs).","commit_id":"396e224da1800a1b116f9a144602ac885bf7f0f7"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"575e9866e9806da49aa8983ecfb018c8cef72cea","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __init__(self, roles\u003dNone,"},{"line_number":30,"context_line":"                 owner_is_tenant\u003dTrue, service_catalog\u003dNone,"},{"line_number":31,"context_line":"                 policy_enforcer\u003dNone, **kwargs):"},{"line_number":32,"context_line":"        super(RequestContext, self).__init__(**kwargs)"},{"line_number":33,"context_line":"        self.roles \u003d roles or []"},{"line_number":34,"context_line":"        self.owner_is_tenant \u003d owner_is_tenant"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_8faad9d1","line":31,"in_reply_to":"3a961159_95e4bfa8","updated":"2015-01-19 10:09:09.000000000","message":"Yes the plan is to remove context from Glance and other projects and replace it by a common lib.\nThe doc is available with pydoc or online http://docs.openstack.org/developer/oslo.context/ like any other Python or OpenStack module.","commit_id":"396e224da1800a1b116f9a144602ac885bf7f0f7"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"55c71adb3b1dcd2bcee0bea0b11e36bd17826639","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __init__(self, roles\u003dNone,"},{"line_number":30,"context_line":"                 owner_is_tenant\u003dTrue, service_catalog\u003dNone,"},{"line_number":31,"context_line":"                 policy_enforcer\u003dNone, **kwargs):"},{"line_number":32,"context_line":"        super(RequestContext, self).__init__(**kwargs)"},{"line_number":33,"context_line":"        self.roles \u003d roles or []"},{"line_number":34,"context_line":"        self.owner_is_tenant \u003d owner_is_tenant"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_229bd373","line":31,"in_reply_to":"3a961159_bf6c3c08","updated":"2015-01-16 22:58:37.000000000","message":"The ultimate aim is to entirely remove the glance specific RequestContext object, right? When that is done, oslo_context.RequestContext will explicitly list the accepted kwargs and be a single source of truth. Maybe it would be better to list the kwargs twice, but I don\u0027t think it\u0027s something to block this patch over.","commit_id":"396e224da1800a1b116f9a144602ac885bf7f0f7"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"79d3b6666d20cfa917f088205db312b83c8fa8a6","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __init__(self, roles\u003dNone,"},{"line_number":30,"context_line":"                 owner_is_tenant\u003dTrue, service_catalog\u003dNone,"},{"line_number":31,"context_line":"                 policy_enforcer\u003dNone, **kwargs):"},{"line_number":32,"context_line":"        super(RequestContext, self).__init__(**kwargs)"},{"line_number":33,"context_line":"        self.roles \u003d roles or []"},{"line_number":34,"context_line":"        self.owner_is_tenant \u003d owner_is_tenant"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_e6b149e1","line":31,"in_reply_to":"3a961159_d058838c","updated":"2015-01-14 13:21:15.000000000","message":"That\u0027s used to avoid repeating and manually maintaining the list of kwargs accepted by oslo.context.RequestContext.","commit_id":"396e224da1800a1b116f9a144602ac885bf7f0f7"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"09530b7cd55a131122968926ece3d0f1096e5ff7","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __init__(self, roles\u003dNone,"},{"line_number":30,"context_line":"                 owner_is_tenant\u003dTrue, service_catalog\u003dNone,"},{"line_number":31,"context_line":"                 policy_enforcer\u003dNone, **kwargs):"},{"line_number":32,"context_line":"        super(RequestContext, self).__init__(**kwargs)"},{"line_number":33,"context_line":"        self.roles \u003d roles or []"},{"line_number":34,"context_line":"        self.owner_is_tenant \u003d owner_is_tenant"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_ede701a9","line":31,"in_reply_to":"3a961159_e6b149e1","updated":"2015-01-16 21:41:38.000000000","message":"+1 on avoiding duplication of oslo.context.RequestContext args.","commit_id":"396e224da1800a1b116f9a144602ac885bf7f0f7"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"0e8dcb7183bae5a1689c6953352a7bb41d648e34","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __init__(self, roles\u003dNone,"},{"line_number":30,"context_line":"                 owner_is_tenant\u003dTrue, service_catalog\u003dNone,"},{"line_number":31,"context_line":"                 policy_enforcer\u003dNone, **kwargs):"},{"line_number":32,"context_line":"        super(RequestContext, self).__init__(**kwargs)"},{"line_number":33,"context_line":"        self.roles \u003d roles or []"},{"line_number":34,"context_line":"        self.owner_is_tenant \u003d owner_is_tenant"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_bb1cd6c2","line":31,"in_reply_to":"3a961159_e6b149e1","updated":"2015-02-03 15:56:06.000000000","message":"I see,\n\nAnd this is one reason why I really hate moving to oslo.something time to time. It just kills the readability of the code for preference of laziness.","commit_id":"396e224da1800a1b116f9a144602ac885bf7f0f7"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"7a3e5730a00def5c4ca7aa29d3cfd3f3e5ec1a99","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __init__(self, roles\u003dNone,"},{"line_number":30,"context_line":"                 owner_is_tenant\u003dTrue, service_catalog\u003dNone,"},{"line_number":31,"context_line":"                 policy_enforcer\u003dNone, **kwargs):"},{"line_number":32,"context_line":"        super(RequestContext, self).__init__(**kwargs)"},{"line_number":33,"context_line":"        self.roles \u003d roles or []"},{"line_number":34,"context_line":"        self.owner_is_tenant \u003d owner_is_tenant"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_bf6c3c08","line":31,"in_reply_to":"3a961159_ede701a9","updated":"2015-01-16 22:29:23.000000000","message":"So personally, I hate having to jump around between projects to figure out what\u0027s passed in and handled by other libraries (e.g., oslo.context). Does it have any documentation at all that can be linked here for future developers looking to see what kwargs are allowed?","commit_id":"396e224da1800a1b116f9a144602ac885bf7f0f7"}]}