)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"81f4eee4b31864f53e232cfae16639e7f336ed71","unresolved":false,"context_lines":[{"line_number":20,"context_line":"This commit also adds a hacking rule."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1]http://legacy.python.org/dev/peps/pep-0274/"},{"line_number":23,"context_line":"[2]http://goo.gl/X5o1oz"},{"line_number":24,"context_line":"[3]http://paste.openstack.org/show/154798/"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I0ba408f9c616dcdb09618f6256db76b9facc0c1d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da86d52c_ec3b4dc6","line":23,"updated":"2015-02-13 17:23:15.000000000","message":"I know Mike asked for you to use a shortened link here but this is absolutely unacceptable. If you\u0027re both insistent on following the 72 character limit, break the URL at 72 characters. It makes little sense to rely on any url shortening service when those links will rot, regardless of who runs the service.","commit_id":"c46f5aaeb58908f51d7ac552a81acd45fc840b95"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"0880c8318d0de11a76b743aee621270a4bce960a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"This commit also adds a hacking rule."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1]http://legacy.python.org/dev/peps/pep-0274/"},{"line_number":23,"context_line":"[2]http://goo.gl/X5o1oz"},{"line_number":24,"context_line":"[3]http://paste.openstack.org/show/154798/"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I0ba408f9c616dcdb09618f6256db76b9facc0c1d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da86d52c_a0bdd9d9","line":23,"in_reply_to":"da86d52c_ec3b4dc6","updated":"2015-02-13 18:05:32.000000000","message":"I mentioned this in reply to Mike in the last patchset, but you can\u0027t -1 comments! Commit messages are not a good place for link shorteners.","commit_id":"c46f5aaeb58908f51d7ac552a81acd45fc840b95"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a27cb207a28dae26d94033bff8c8b429e577de3b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Leverage dict comprehension in PEP-0274"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PEP-0274 introduced dict comprehensions to replace dict constructor"},{"line_number":10,"context_line":"with a sequence of key-pairs[1], these are twobenefits:"},{"line_number":11,"context_line":"  First, it makes the code look neater."},{"line_number":12,"context_line":"  Second, it gains a micro-optimization."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba7be1f8_c1319a0c","line":10,"updated":"2015-03-02 15:31:45.000000000","message":"Nit: Do you mean \u0027there are two benefits\u0027?","commit_id":"924b24f28b6c2dad9abc342bbcf4936329bf2ca5"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a27cb207a28dae26d94033bff8c8b429e577de3b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PEP-0274 introduced dict comprehensions to replace dict constructor"},{"line_number":10,"context_line":"with a sequence of key-pairs[1], these are twobenefits:"},{"line_number":11,"context_line":"  First, it makes the code look neater."},{"line_number":12,"context_line":"  Second, it gains a micro-optimization."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Glance dropped python 2.6 support in Kilo, we can leverage this now."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba7be1f8_e4022c08","line":11,"updated":"2015-03-02 15:31:45.000000000","message":"Nit: \u0027makes the code more readable\u0027 maybe?","commit_id":"924b24f28b6c2dad9abc342bbcf4936329bf2ca5"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"a27cb207a28dae26d94033bff8c8b429e577de3b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"PEP-0274 introduced dict comprehensions to replace dict constructor"},{"line_number":10,"context_line":"with a sequence of key-pairs[1], these are twobenefits:"},{"line_number":11,"context_line":"  First, it makes the code look neater."},{"line_number":12,"context_line":"  Second, it gains a micro-optimization."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Glance dropped python 2.6 support in Kilo, we can leverage this now."},{"line_number":15,"context_line":"Note: This commit doesn\u0027t handle dict constructor with kwargs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba7be1f8_c44d2874","line":12,"updated":"2015-03-02 15:31:45.000000000","message":"Nit: Do you mind mentioning this a performance optimization?","commit_id":"924b24f28b6c2dad9abc342bbcf4936329bf2ca5"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d1db0e392b3512f9bee9914ec6f722689d953b0c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Leverage dict comprehension in PEP-0274"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PEP-0274 introduced dict comprehensions to replace dict constructor"},{"line_number":10,"context_line":"with a sequence of key-pairs[1], these are twobenefits:"},{"line_number":11,"context_line":"- First, it makes the code look neater."},{"line_number":12,"context_line":"- Second, it gains a micro-optimization."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9aa53dc9_e6d06a21","line":10,"updated":"2015-04-10 06:42:38.000000000","message":"twobenefits \u003e\u003e two benefits","commit_id":"26da6e7d4461a7c7632320ab310746297f13e65c"}],"HACKING.rst":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d1db0e392b3512f9bee9914ec6f722689d953b0c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"- [G325] Validate that LOG.critical messages use _LC."},{"line_number":24,"context_line":"- [G326] Validate that LOG.warning messages use _LW."},{"line_number":25,"context_line":"- [G327] Prevent use of deprecated contextlib.nested"},{"line_number":26,"context_line":"- [G327] Must use a dict comprehension instead of a dict constructor with a sequence of key-value pairs"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9aa53dc9_a6c6e265","line":26,"updated":"2015-04-10 06:42:38.000000000","message":"IMO, number should be different here.","commit_id":"26da6e7d4461a7c7632320ab310746297f13e65c"}],"glance/hacking/checks.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"3ba6ecdb8a3ebdd5719dcf4910a7999775af02ec","unresolved":false,"context_lines":[{"line_number":143,"context_line":"def dict_constructor_with_list_copy(logical_line):"},{"line_number":144,"context_line":"    msg \u003d (\"G327: Must use a dict comprehension instead of a dict constructor\""},{"line_number":145,"context_line":"           \" with a sequence of key-value pairs.\""},{"line_number":146,"context_line":"           )"},{"line_number":147,"context_line":"    if dict_constructor_with_list_copy_re.match(logical_line):"},{"line_number":148,"context_line":"        yield (0, msg)"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_e923b1ba","line":146,"updated":"2015-02-04 17:23:57.000000000","message":"Nit: Do we need the \u0027)\u0027 to be on a new line here?","commit_id":"585974674404276a37e2dd8993886d84c4365804"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"9c71e15e2fe568e3ba989e9e6ce7c7a65b36b298","unresolved":false,"context_lines":[{"line_number":143,"context_line":"def dict_constructor_with_list_copy(logical_line):"},{"line_number":144,"context_line":"    msg \u003d (\"G327: Must use a dict comprehension instead of a dict constructor\""},{"line_number":145,"context_line":"           \" with a sequence of key-value pairs.\""},{"line_number":146,"context_line":"           )"},{"line_number":147,"context_line":"    if dict_constructor_with_list_copy_re.match(logical_line):"},{"line_number":148,"context_line":"        yield (0, msg)"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_916a45eb","line":146,"in_reply_to":"da86d52c_e923b1ba","updated":"2015-02-12 01:37:45.000000000","message":"will update  in next patch :)","commit_id":"585974674404276a37e2dd8993886d84c4365804"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"0880c8318d0de11a76b743aee621270a4bce960a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        yield (0, msg)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"def dict_constructor_with_list_copy(logical_line):"},{"line_number":144,"context_line":"    msg \u003d (\"G327: Must use a dict comprehension instead of a dict constructor\""},{"line_number":145,"context_line":"           \" with a sequence of key-value pairs.\")"},{"line_number":146,"context_line":"    if dict_constructor_with_list_copy_re.match(logical_line):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_40fa5d44","line":143,"updated":"2015-02-13 18:05:32.000000000","message":"I\u0027m not sure we should enforce this with hacking.","commit_id":"c46f5aaeb58908f51d7ac552a81acd45fc840b95"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d1db0e392b3512f9bee9914ec6f722689d953b0c","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"def dict_constructor_with_list_copy(logical_line):"},{"line_number":153,"context_line":"    msg \u003d (\"G327: Must use a dict comprehension instead of a dict constructor \""},{"line_number":154,"context_line":"           \"with a sequence of key-value pairs.\")"},{"line_number":155,"context_line":"    if dict_constructor_with_list_copy_re.match(logical_line):"},{"line_number":156,"context_line":"        yield (0, msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aa53dc9_e6974a46","line":153,"updated":"2015-04-10 06:42:38.000000000","message":"G327 \u003e\u003e G328 ??","commit_id":"26da6e7d4461a7c7632320ab310746297f13e65c"}]}