)]}'
{"bin/glance-control":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"3aaf247b6dcc98545da9ab762f069b6367519cb5","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"def do_check_status(pid_file, server):"},{"line_number":202,"context_line":"    if os.path.exists(pid_file):"},{"line_number":203,"context_line":"        print \"%s running\" % server"},{"line_number":204,"context_line":"    else:"},{"line_number":205,"context_line":"        print \"No %s running\" % server"},{"line_number":206,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAALH%2F%2FIG0%3D","line":203,"updated":"2012-10-13 02:15:14.000000000","message":"Let\u0027s print the pid of the server as well.","commit_id":"f13166cef59425f47619ea4cadc2bca9ca4c3376"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"3aaf247b6dcc98545da9ab762f069b6367519cb5","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        print \"%s running\" % server"},{"line_number":204,"context_line":"    else:"},{"line_number":205,"context_line":"        print \"No %s running\" % server"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"def get_pid_file(pid, pid_file):"},{"line_number":208,"context_line":"    pid_file \u003d (os.path.abspath(pid_file) if pid_file else"},{"line_number":209,"context_line":"                \u0027/var/run/glance/%s.pid\u0027 % server)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAALH%2F%2FIGw%3D","line":206,"updated":"2012-10-13 02:15:14.000000000","message":"You need another newline here. The pep8 style guide requires two blank lines between each module-level function.","commit_id":"f13166cef59425f47619ea4cadc2bca9ca4c3376"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"916b56e43af1c7391fda4fa6127661a16501e4ba","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"def do_check_status(pid_file, server):"},{"line_number":202,"context_line":"    if os.path.exists(pid_file):"},{"line_number":203,"context_line":"        print \"%s running: %s\" % (server, pid_file)"},{"line_number":204,"context_line":"    else:"},{"line_number":205,"context_line":"        print \"No %s running: %s\" % (server, pid_file)"},{"line_number":206,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAALn%2F%2F9nI%3D","line":203,"updated":"2012-10-24 17:31:18.000000000","message":"I see that you changed this to try to print the pid of the server process. However, the code here prints the pid file path. I think what you want to do is to print the contents of the pid_file path.\n\n if os.path.exists(pid_file):\n     pid \u003d open(pid_file).read().strip()\n     print \"%s running: %s\" % (server, pid)\n\nDoes that make sense?","commit_id":"7059050eb6d8b8c9fc469245d6e907f39d61678e"}]}
