)]}'
{"doc/source/configuring.rst":[{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"eecd088ab43ea2c2f879c77d77ce66fc9503a567","unresolved":false,"context_lines":[{"line_number":186,"context_line":"* ``disable_path\u003dPATH``"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"When the healthcheck middleware is in the pipeline it will respond 200 OK"},{"line_number":189,"context_line":"to requests to /healthcheck. If disable_path is set and exists the response"},{"line_number":190,"context_line":"will be 503 DISABLED BY FILE instead."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Optional."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_8b78db2d","line":189,"updated":"2015-01-20 15:53:34.000000000","message":"Nit: clarify that a file needs to exist at that location, not the fact disable_path exists.\n\n    If disable_path is set and a file exists at that location, the response","commit_id":"964c7fd588e786b37c1f9599aa368fd7b9df43ce"}],"glance/api/middleware/healthcheck.py":[{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"eecd088ab43ea2c2f879c77d77ce66fc9503a567","unresolved":false,"context_lines":[{"line_number":28,"context_line":"_LI \u003d i18n._LI"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class HealthCheckMiddleware(wsgi.Middleware):"},{"line_number":32,"context_line":"    \"\"\"Healthcheck middleware used for monitoring."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    If the path is /healthcheck, it will respond 200 with \"OK\" as the body."}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_abbd9705","line":31,"updated":"2015-01-20 15:53:34.000000000","message":"Could you add a comment to the docstring that this has been lifted from swift/common/middleware/healthcheck.py in the swift repo. This would help identify duplicated common code between the services at a later date.","commit_id":"964c7fd588e786b37c1f9599aa368fd7b9df43ce"},{"author":{"_account_id":7487,"name":"hzrandd","email":"82433422@qq.com","username":"hzrandd"},"change_message_id":"1427eda7f336964a527790b71c95bba69111c3de","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                    return webob.response.Response(request\u003dreq, body\u003d\"OK\","},{"line_number":60,"context_line":"                                                   content_type\u003d\"text/plain\")"},{"line_number":61,"context_line":"        except UnicodeError:"},{"line_number":62,"context_line":"            # definitely, this is not /healthcheck"},{"line_number":63,"context_line":"            pass"},{"line_number":64,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_aaa03191","line":62,"updated":"2015-01-22 02:13:17.000000000","message":"Returned the reason attribute of UnicodeError here? A string describing the specific codec error.","commit_id":"353455a1d478af739ba9f570e11d93522d7fc4f4"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a942acb5afb6f21a1b62594ee595d79e8b6202fe","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                    return webob.response.Response(request\u003dreq, body\u003d\"OK\","},{"line_number":60,"context_line":"                                                   content_type\u003d\"text/plain\")"},{"line_number":61,"context_line":"        except UnicodeError:"},{"line_number":62,"context_line":"            # definitely, this is not /healthcheck"},{"line_number":63,"context_line":"            pass"},{"line_number":64,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a930d6b_896e1500","line":62,"in_reply_to":"1a930d6b_aaa03191","updated":"2015-01-22 12:27:07.000000000","message":"Sorry I didn\u0027t quite get you. So if our path check above does return unicode error, we bluntly make decision this not being healthcheck request and pass it on the pipeline by returning None. We definitely do not want to intercept the request at that point by returning anything else. If that\u0027s what you were thinking?","commit_id":"353455a1d478af739ba9f570e11d93522d7fc4f4"}]}