)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"3caaaf8a48e2e23434f567173da356a6e4156e84","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     hzrandd \u003c82433422@qq.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-01-28 17:33:08 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Just set those schemes configurable."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reference-Bug: #1408663"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa81d914_c6b6538a","line":7,"updated":"2015-01-28 14:53:27.000000000","message":"This needs a better short description and both SecurityImpact and DocImpact on separate lines, e.g.,\n\n    Allow users to configure blacklist of URI schemes\n\n    SecurityImpact\n    DocImpact\n    Related-Bug: 1408663\n\nA long description would be nice, including rationale and a description of the change in-depth. Please add that before the SecurityImpact line and after the short description line and make sure the lines do not exceed 72 characters","commit_id":"82789275cafad5ae880a90f5e37017828e0d15da"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"2091c1e883d86db91141e3f6651bc1a5759709bf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"It will help to shortcircuit the checks at Glance\u0027s level,"},{"line_number":10,"context_line":"but themselves should check this and have security related options."},{"line_number":11,"context_line":"At the same time, it is easy to allows users to download and delete file which"},{"line_number":12,"context_line":"they want go."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related-Bug: 1408663"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa81d914_9abc5dde","line":12,"updated":"2015-01-29 23:24:28.000000000","message":"Again, you need to add the following lines before your Related-bug line\n\n    SecurityImpact\n    DocImpact","commit_id":"a68bf5edff2c2c324771fc2a5a6bea2768a363e9"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"b3a59fecf7b0124d4de9f10c9c483d2117c75314","unresolved":false,"context_lines":[{"line_number":15,"context_line":"different users to do what they want. some users want to add a new URI scheme"},{"line_number":16,"context_line":"allowed by the glance_store after all."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: 1408663"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I417e096ef94c5d62d0a7bed64ce685cf5a09939f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa81d914_6fc6016a","line":18,"updated":"2015-01-30 04:10:48.000000000","message":"You need to add \n\n    SecurityImpact\n    DoctImpact\n\nBefore this line","commit_id":"3788292a9425d963ca8965e783219f1bc8869d97"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"338c33160d10fdac1ae7b3ca99ee964548d7725f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"different users to do what they want. some users want to add a new URI scheme"},{"line_number":16,"context_line":"allowed by the glance_store after all."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: 1408663"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I417e096ef94c5d62d0a7bed64ce685cf5a09939f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa81d914_3d399541","line":18,"in_reply_to":"fa81d914_0e901d49","updated":"2015-01-30 15:12:04.000000000","message":"You literally need to edit your commit message to copy and paste those two lines before the line that starts with \"Related-Bug\". That\u0027s it.","commit_id":"3788292a9425d963ca8965e783219f1bc8869d97"},{"author":{"_account_id":7487,"name":"hzrandd","email":"82433422@qq.com","username":"hzrandd"},"change_message_id":"b07a63a6d8feff9950a33afe6f91842e060e9af4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"different users to do what they want. some users want to add a new URI scheme"},{"line_number":16,"context_line":"allowed by the glance_store after all."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: 1408663"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I417e096ef94c5d62d0a7bed64ce685cf5a09939f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa81d914_8eafad29","line":18,"in_reply_to":"fa81d914_6fc6016a","updated":"2015-01-30 11:17:14.000000000","message":"Hello, I had reviewed your feedback.  I think the security and convenience are always hostile.  Perhaps  the  security is more importent. so , should i abandon this patch ?","commit_id":"3788292a9425d963ca8965e783219f1bc8869d97"},{"author":{"_account_id":7487,"name":"hzrandd","email":"82433422@qq.com","username":"hzrandd"},"change_message_id":"b2439d1dd10e537ddb45a725bea71ae10c1fdc15","unresolved":false,"context_lines":[{"line_number":15,"context_line":"different users to do what they want. some users want to add a new URI scheme"},{"line_number":16,"context_line":"allowed by the glance_store after all."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: 1408663"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I417e096ef94c5d62d0a7bed64ce685cf5a09939f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa81d914_0e901d49","line":18,"in_reply_to":"fa81d914_6fc6016a","updated":"2015-01-30 10:50:11.000000000","message":"Hello, lan Cordasco. I was a small mouse now , I do not quite understand what you mean. Could you please give me some more information? thanks a lot.","commit_id":"3788292a9425d963ca8965e783219f1bc8869d97"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"338c33160d10fdac1ae7b3ca99ee964548d7725f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"different users to do what they want. some users want to add a new URI scheme"},{"line_number":16,"context_line":"allowed by the glance_store after all."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related-Bug: 1408663"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I417e096ef94c5d62d0a7bed64ce685cf5a09939f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa81d914_3d87d5d8","line":18,"in_reply_to":"fa81d914_8eafad29","updated":"2015-01-30 15:12:04.000000000","message":"Keeping in mind that these schemes were not allowed in v1 of the API and that they were unintentionally allowed in v2, I\u0027m not sure the configuration is necessary. I don\u0027t know whether you should abandon this patch yet. It seems worthy of debate but I\u0027m wary of it\u0027s inclusion.","commit_id":"3788292a9425d963ca8965e783219f1bc8869d97"}],"glance/common/store_utils.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"163aa484520e0393b61e8a6cbd7d83b2c5d91998","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                       \u0027making requests to the registry.\u0027)),"},{"line_number":36,"context_line":"    cfg.ListOpt(\u0027restricted_uri_schemas\u0027,"},{"line_number":37,"context_line":"                default\u003d[\u0027file\u0027, \u0027filesystem\u0027, \u0027swift+config\u0027],"},{"line_number":38,"context_line":"                help\u003d_(\u0027set the restricted uri schemas here.\u0027)),"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_7afc653f","line":38,"updated":"2015-01-28 12:28:17.000000000","message":"Could you extend this help text a bit more? For example, mention that these schemas won\u0027t be allowed to be used as remote locations.","commit_id":"82789275cafad5ae880a90f5e37017828e0d15da"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"3caaaf8a48e2e23434f567173da356a6e4156e84","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                       \u0027making requests to the registry.\u0027)),"},{"line_number":36,"context_line":"    cfg.ListOpt(\u0027restricted_uri_schemas\u0027,"},{"line_number":37,"context_line":"                default\u003d[\u0027file\u0027, \u0027filesystem\u0027, \u0027swift+config\u0027],"},{"line_number":38,"context_line":"                help\u003d_(\u0027set the restricted uri schemas here.\u0027)),"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_26748fce","line":38,"in_reply_to":"fa81d914_7afc653f","updated":"2015-01-28 14:53:27.000000000","message":"+1","commit_id":"82789275cafad5ae880a90f5e37017828e0d15da"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"2091c1e883d86db91141e3f6651bc1a5759709bf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                       \u0027making requests to the registry.\u0027)),"},{"line_number":36,"context_line":"    cfg.ListOpt(\u0027restricted_uri_schemas\u0027,"},{"line_number":37,"context_line":"                default\u003d[\u0027file\u0027, \u0027filesystem\u0027, \u0027swift+config\u0027],"},{"line_number":38,"context_line":"                help\u003d_(\u0027set the restricted uri schemas here.\u0027)),"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_1ad06d1e","line":38,"updated":"2015-01-29 23:24:28.000000000","message":"You still need to extend the help text here significantly.","commit_id":"a68bf5edff2c2c324771fc2a5a6bea2768a363e9"}]}