)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"ee6802aac7476ede142f192ae46c3043595ed674","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add detail description image_cache_max_size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The description of \u0027image_cache_max_size\u0027 was ambiguous. There was not the"},{"line_number":10,"context_line":"certainty that the \u0027image_cache_max_size\u0027 parameter was about the sum of all"},{"line_number":11,"context_line":"the images or just one image. Hence added detail description of image_cache_max_size."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ide8e087db544aeea1990bac92c97cb9ca9f0b522"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da86d52c_2fcb3b54","line":10,"updated":"2015-02-03 17:01:46.000000000","message":"Please wrap commit message bodies at 72 characters and limit title lines to 50. I think you only need to address the 72 character width here.","commit_id":"91365d05853bc77471aeac2dea2f9c9f3285ab30"},{"author":{"_account_id":13525,"name":"Yusuke Ide","email":"idzzyzzbi@gmail.com","username":"idzzy"},"change_message_id":"c90b7bcff2eb234eb6ca80c32d65024fcc607854","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add detail description image_cache_max_size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The description of \u0027image_cache_max_size\u0027 was ambiguous. There was not the"},{"line_number":10,"context_line":"certainty that the \u0027image_cache_max_size\u0027 parameter was about the sum of all"},{"line_number":11,"context_line":"the images or just one image. Hence added detail description of image_cache_max_size."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ide8e087db544aeea1990bac92c97cb9ca9f0b522"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da86d52c_1cc933ac","line":10,"in_reply_to":"da86d52c_2fcb3b54","updated":"2015-02-04 12:13:54.000000000","message":"Sure, Thanks the comment. I updated message bodies within 72 characters.","commit_id":"91365d05853bc77471aeac2dea2f9c9f3285ab30"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ffe667b5e1b50a2124a1f2b85a135a0d66a15fc2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The description of \u0027image_cache_max_size\u0027 was ambiguous. There was not"},{"line_number":10,"context_line":"the certainty that the \u0027image_cache_max_size\u0027 parameter was about the"},{"line_number":11,"context_line":"aggregate size of the cache or a per image limit."},{"line_number":12,"context_line":"The \u0027image_cache_max_size\u0027 is an upper limit beyond which pruner"},{"line_number":13,"context_line":"starts cleaning the images cache."},{"line_number":14,"context_line":"Hence added detail description of \u0027image_cache_max_size\u0027 in document"},{"line_number":15,"context_line":"and configuration file."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da86d52c_b28466b2","line":12,"updated":"2015-02-06 18:30:46.000000000","message":"same","commit_id":"f8fe4d3d7e5b5d4997ccc68c7caba15f1e6ed5b8"}],"doc/source/cache.rst":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ed504dd056409dfcff37334b86b4700484ddc7cb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The image cache has a configurable maximum size (the ``image_cache_max_size``"},{"line_number":41,"context_line":"configuration file option). the ``image_cache_max_size`` is the whole size of"},{"line_number":42,"context_line":"the cache (sum of all image sizes). However, when images are successfully returned"},{"line_number":43,"context_line":"from a call to ``GET /images/\u003cIMAGE_ID\u003e``, the image cache automatically"},{"line_number":44,"context_line":"writes the image file to its cache, regardless of whether the resulting"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da86d52c_ef9f6cb2","line":41,"updated":"2015-02-03 14:44:42.000000000","message":"Minor nit: \u0027The\u0027 instead of \u0027the\u0027 to start the sentence.","commit_id":"91365d05853bc77471aeac2dea2f9c9f3285ab30"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"ee6802aac7476ede142f192ae46c3043595ed674","unresolved":false,"context_lines":[{"line_number":38,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The image cache has a configurable maximum size (the ``image_cache_max_size``"},{"line_number":41,"context_line":"configuration file option). the ``image_cache_max_size`` is the whole size of"},{"line_number":42,"context_line":"the cache (sum of all image sizes). However, when images are successfully returned"},{"line_number":43,"context_line":"from a call to ``GET /images/\u003cIMAGE_ID\u003e``, the image cache automatically"},{"line_number":44,"context_line":"writes the image file to its cache, regardless of whether the resulting"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da86d52c_2f96db4c","line":41,"in_reply_to":"da86d52c_ef9f6cb2","updated":"2015-02-03 17:01:46.000000000","message":"+1","commit_id":"91365d05853bc77471aeac2dea2f9c9f3285ab30"},{"author":{"_account_id":13525,"name":"Yusuke Ide","email":"idzzyzzbi@gmail.com","username":"idzzy"},"change_message_id":"c90b7bcff2eb234eb6ca80c32d65024fcc607854","unresolved":false,"context_lines":[{"line_number":38,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The image cache has a configurable maximum size (the ``image_cache_max_size``"},{"line_number":41,"context_line":"configuration file option). the ``image_cache_max_size`` is the whole size of"},{"line_number":42,"context_line":"the cache (sum of all image sizes). However, when images are successfully returned"},{"line_number":43,"context_line":"from a call to ``GET /images/\u003cIMAGE_ID\u003e``, the image cache automatically"},{"line_number":44,"context_line":"writes the image file to its cache, regardless of whether the resulting"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da86d52c_2143306d","line":41,"in_reply_to":"da86d52c_ef9f6cb2","updated":"2015-02-04 12:13:54.000000000","message":"Sure, Thanks the comment. I updated it.","commit_id":"91365d05853bc77471aeac2dea2f9c9f3285ab30"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"c99f8b6011c7e82b1f896246a72381c1d17ba095","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The image cache has a configurable maximum size (the ``image_cache_max_size``"},{"line_number":41,"context_line":"configuration file option). The ``image_cache_max_size`` is the whole size of"},{"line_number":42,"context_line":"the cache (sum of all image sizes). However, when images are successfully returned"},{"line_number":43,"context_line":"from a call to ``GET /images/\u003cIMAGE_ID\u003e``, the image cache automatically"},{"line_number":44,"context_line":"writes the image file to its cache, regardless of whether the resulting"},{"line_number":45,"context_line":"write would make the image cache\u0027s size exceed the value of"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_1544a0b5","line":42,"updated":"2015-02-04 16:28:58.000000000","message":"I\u0027m wondering if we should have \u0027(sum of all image sizes)\u0027 here at all. If we read the rest of the paragraph, it explains how the cache can go over the specified \n\"image_cache_max_size\" if one doesn\u0027t run the pruner. So, really \"image_cache_max_size\" and the sum of all image sizes in cache are two different things. Am I making any sense here?\n\nAlso, I think all we should say in the description for \"image_cache_max_size\" is that it\u0027s just an indicative upper limit for aggregate image cache.","commit_id":"b3078d4583bc46f35e316631a92f8db69b55eaa5"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"6ac75fdd1bf8d3f2f89a5bbeb482088d81634852","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The image cache has a configurable maximum size (the ``image_cache_max_size``"},{"line_number":41,"context_line":"configuration file option). The ``image_cache_max_size`` is the whole size of"},{"line_number":42,"context_line":"the cache (sum of all image sizes). However, when images are successfully returned"},{"line_number":43,"context_line":"from a call to ``GET /images/\u003cIMAGE_ID\u003e``, the image cache automatically"},{"line_number":44,"context_line":"writes the image file to its cache, regardless of whether the resulting"},{"line_number":45,"context_line":"write would make the image cache\u0027s size exceed the value of"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da86d52c_17d57b1b","line":42,"in_reply_to":"da86d52c_1544a0b5","updated":"2015-02-04 19:32:54.000000000","message":"I agree with Hemanth. I do not think that there is still need some explanation.","commit_id":"b3078d4583bc46f35e316631a92f8db69b55eaa5"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ffe667b5e1b50a2124a1f2b85a135a0d66a15fc2","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The image cache has a configurable maximum size (the ``image_cache_max_size``"},{"line_number":41,"context_line":"configuration file option). The ``image_cache_max_size`` is an upper limit"},{"line_number":42,"context_line":"beyond which pruner starts cleaning the images cache. However, when images"},{"line_number":43,"context_line":"are successfully returned from a call to ``GET /images/\u003cIMAGE_ID\u003e``,"},{"line_number":44,"context_line":"the image cache automatically writes the image file to its cache, regardless"},{"line_number":45,"context_line":"of whether the resulting write would make the image cache\u0027s size exceed the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da86d52c_b2fd463e","line":42,"updated":"2015-02-06 18:30:46.000000000","message":"How about \u0027.... beyond which pruner, if running, starts cleaning the images cache ....\u0027?\nJust trying to be explicit that pruner shouldn\u0027t be taken for granted. It is not something that kicks in automatically. It needs to be configured to run, otherwise your cache would just keep growing.\n\nSorry for being fussy on this one. Hope you understand :)","commit_id":"f8fe4d3d7e5b5d4997ccc68c7caba15f1e6ed5b8"}],"etc/glance-cache.conf":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"6ac75fdd1bf8d3f2f89a5bbeb482088d81634852","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# stalled and eligible for reaping"},{"line_number":23,"context_line":"image_cache_stall_time \u003d 86400"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Max cache size in bytes (Sum of cache of all images)"},{"line_number":26,"context_line":"image_cache_max_size \u003d 10737418240"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Address to find the registry server"}],"source_content_type":"text/plain","patch_set":2,"id":"da86d52c_37c19f54","line":25,"updated":"2015-02-04 19:32:54.000000000","message":"sum with lower s","commit_id":"b3078d4583bc46f35e316631a92f8db69b55eaa5"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ffe667b5e1b50a2124a1f2b85a135a0d66a15fc2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"image_cache_stall_time \u003d 86400"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# The upper limit (the maximum size of accumulated cache in bytes) beyond"},{"line_number":26,"context_line":"# which pruner starts cleaning the images cache."},{"line_number":27,"context_line":"image_cache_max_size \u003d 10737418240"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Address to find the registry server"}],"source_content_type":"text/plain","patch_set":3,"id":"da86d52c_32995620","line":26,"updated":"2015-02-06 18:30:46.000000000","message":"same","commit_id":"f8fe4d3d7e5b5d4997ccc68c7caba15f1e6ed5b8"}],"glance/image_cache/__init__.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ffe667b5e1b50a2124a1f2b85a135a0d66a15fc2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"               help\u003d_(\u0027The driver to use for image cache management.\u0027)),"},{"line_number":41,"context_line":"    cfg.IntOpt(\u0027image_cache_max_size\u0027, default\u003d10 * units.Gi,  # 10 GB"},{"line_number":42,"context_line":"               help\u003d_(\u0027The upper limit (the maximum size of accumulated \u0027"},{"line_number":43,"context_line":"                      \u0027cache in bytes) beyond which pruner starts \u0027"},{"line_number":44,"context_line":"                      \u0027cleaning the images cache.\u0027)),"},{"line_number":45,"context_line":"    cfg.IntOpt(\u0027image_cache_stall_time\u0027, default\u003d86400,  # 24 hours"},{"line_number":46,"context_line":"               help\u003d_(\u0027The amount of time to let an image remain in the \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_529eca08","line":43,"updated":"2015-02-06 18:30:46.000000000","message":"same","commit_id":"f8fe4d3d7e5b5d4997ccc68c7caba15f1e6ed5b8"}]}