)]}'
{"glance/api/authorization.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"1cc4cc129845c74af97331def5d509347ae0bf3e","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def list(self, *args, **kwargs):"},{"line_number":135,"context_line":"        members \u003d self.member_repo.list(*args, **kwargs)"},{"line_number":136,"context_line":"        if self.context.is_admin or self.context.owner \u003d\u003d self.image.owner:"},{"line_number":137,"context_line":"            return [proxy_member(self.context, m) for m in members]"},{"line_number":138,"context_line":"        for member in members:"},{"line_number":139,"context_line":"            if member.member_id \u003d\u003d self.context.owner:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_85bfb1fb","line":136,"updated":"2015-02-10 13:33:56.000000000","message":"I do not think that this change improves readability. Quite opposite.","commit_id":"a5aa66fc16e176791ae1dfaa4ec86627c28a0690"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"6d5039fd932bbe65d686bfe65c856c9a0d8014a2","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def list(self, *args, **kwargs):"},{"line_number":135,"context_line":"        members \u003d self.member_repo.list(*args, **kwargs)"},{"line_number":136,"context_line":"        if self.context.is_admin or self.context.owner \u003d\u003d self.image.owner:"},{"line_number":137,"context_line":"            return [proxy_member(self.context, m) for m in members]"},{"line_number":138,"context_line":"        for member in members:"},{"line_number":139,"context_line":"            if member.member_id \u003d\u003d self.context.owner:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_85589158","line":136,"in_reply_to":"da86d52c_48bb2475","updated":"2015-02-17 11:34:39.000000000","message":"Reverted.","commit_id":"a5aa66fc16e176791ae1dfaa4ec86627c28a0690"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"17e5bc4595c4419409cd22d9b949021c3e8e28d2","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def list(self, *args, **kwargs):"},{"line_number":135,"context_line":"        members \u003d self.member_repo.list(*args, **kwargs)"},{"line_number":136,"context_line":"        if self.context.is_admin or self.context.owner \u003d\u003d self.image.owner:"},{"line_number":137,"context_line":"            return [proxy_member(self.context, m) for m in members]"},{"line_number":138,"context_line":"        for member in members:"},{"line_number":139,"context_line":"            if member.member_id \u003d\u003d self.context.owner:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_e958df8b","line":136,"in_reply_to":"da86d52c_85bfb1fb","updated":"2015-02-12 14:26:21.000000000","message":"Don\u0027t you think that adding here unnecessary parentheses and having two lines of code instead of one is non-pythonic? If we would go that way, why not splitting every conditional statement in this manner to use parentheses?","commit_id":"a5aa66fc16e176791ae1dfaa4ec86627c28a0690"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"fd5daac2daa48833112a94edc860c9fb31b0da10","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def list(self, *args, **kwargs):"},{"line_number":135,"context_line":"        members \u003d self.member_repo.list(*args, **kwargs)"},{"line_number":136,"context_line":"        if self.context.is_admin or self.context.owner \u003d\u003d self.image.owner:"},{"line_number":137,"context_line":"            return [proxy_member(self.context, m) for m in members]"},{"line_number":138,"context_line":"        for member in members:"},{"line_number":139,"context_line":"            if member.member_id \u003d\u003d self.context.owner:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_48bb2475","line":136,"in_reply_to":"da86d52c_e958df8b","updated":"2015-02-16 20:03:56.000000000","message":"I\u0027m +0 on the change but parentheses aren\u0027t inherently anti-pythonic since the definition of pythonic is a super subjective thing. There is no inherently objective definition of \"pythonic\".\n\nIf this is a check that is used repeated, however, we probably should consider making this a method that returns a boolean instead, e.g., is_admin_or_owner","commit_id":"a5aa66fc16e176791ae1dfaa4ec86627c28a0690"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"1225ffdbc83beed7a4f84f780da5c1a32bd2f803","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def get(self, member_id):"},{"line_number":126,"context_line":"        if (self.context.is_admin or"},{"line_number":127,"context_line":"                self.context.owner in (self.image.owner, member_id)):"},{"line_number":128,"context_line":"            member \u003d self.member_repo.get(member_id)"},{"line_number":129,"context_line":"            return proxy_member(self.context, member)"},{"line_number":130,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_baba6f6c","line":127,"updated":"2015-02-27 03:04:59.000000000","message":"I\u0027d say this is adding set of parentheses (not saying it wouldn\u0027t be more readable than the previous \u0027though.","commit_id":"58667c1bc497a3be22298193d4232c90149230bf"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"5e4002a4568ef6f27fd785a252733b8790796061","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def get(self, member_id):"},{"line_number":126,"context_line":"        if (self.context.is_admin or"},{"line_number":127,"context_line":"                self.context.owner in (self.image.owner, member_id)):"},{"line_number":128,"context_line":"            member \u003d self.member_repo.get(member_id)"},{"line_number":129,"context_line":"            return proxy_member(self.context, member)"},{"line_number":130,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_4148a3cc","line":127,"in_reply_to":"ba7be1f8_baba6f6c","updated":"2015-02-27 08:14:26.000000000","message":"See what you did there!","commit_id":"58667c1bc497a3be22298193d4232c90149230bf"}],"glance/api/v1/images.py":[{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"e5f9d255e04de5eb094954f34456efbb6a5427ee","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        # NOTE(ameade): If we are not removing existing properties,"},{"line_number":170,"context_line":"        # take them in to account"},{"line_number":171,"context_line":"        if not purge_props and orig_image_meta:"},{"line_number":172,"context_line":"            original_props \u003d orig_image_meta[\u0027properties\u0027].keys()"},{"line_number":173,"context_line":"            props.extend(original_props)"},{"line_number":174,"context_line":"            props \u003d set(props)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_663d95bb","line":171,"updated":"2015-02-09 17:10:12.000000000","message":"I\u0027d rather you left this one, since it makes the desired order of operations clearer.","commit_id":"ccdd31c77f640679bc406a07484076e29eb180e2"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"65a8d0b3610bb8fe6bc4a9010a4b921652432c2d","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        # NOTE(ameade): If we are not removing existing properties,"},{"line_number":170,"context_line":"        # take them in to account"},{"line_number":171,"context_line":"        if not purge_props and orig_image_meta:"},{"line_number":172,"context_line":"            original_props \u003d orig_image_meta[\u0027properties\u0027].keys()"},{"line_number":173,"context_line":"            props.extend(original_props)"},{"line_number":174,"context_line":"            props \u003d set(props)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_f40dae36","line":171,"in_reply_to":"da86d52c_663d95bb","updated":"2015-02-09 17:32:52.000000000","message":"Are you saying that some folks can read it now as if not (purge props and orig_image_meta)? If so, I will change it in next patch.","commit_id":"ccdd31c77f640679bc406a07484076e29eb180e2"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"1bac1facf6e1265f6474f8d5d82ebfd7355b4a06","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        # NOTE(ameade): If we are not removing existing properties,"},{"line_number":170,"context_line":"        # take them in to account"},{"line_number":171,"context_line":"        if not purge_props and orig_image_meta:"},{"line_number":172,"context_line":"            original_props \u003d orig_image_meta[\u0027properties\u0027].keys()"},{"line_number":173,"context_line":"            props.extend(original_props)"},{"line_number":174,"context_line":"            props \u003d set(props)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_edda2216","line":171,"in_reply_to":"da86d52c_663d95bb","updated":"2015-02-10 07:18:52.000000000","message":"Done","commit_id":"ccdd31c77f640679bc406a07484076e29eb180e2"}],"glance/api/v2/images.py":[{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"e5f9d255e04de5eb094954f34456efbb6a5427ee","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            pos \u003d int(path_pos)"},{"line_number":239,"context_line":"        elif path_pos !\u003d \u0027-\u0027:"},{"line_number":240,"context_line":"            return None"},{"line_number":241,"context_line":"        if not allow_max and pos not in range(max_pos):"},{"line_number":242,"context_line":"            return None"},{"line_number":243,"context_line":"        return pos"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_e69fc5b2","line":241,"updated":"2015-02-09 17:10:12.000000000","message":"Retain this one, also.","commit_id":"ccdd31c77f640679bc406a07484076e29eb180e2"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"5924811324a9fabb1dd1c95696ed46178294b246","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            pos \u003d int(path_pos)"},{"line_number":239,"context_line":"        elif path_pos !\u003d \u0027-\u0027:"},{"line_number":240,"context_line":"            return None"},{"line_number":241,"context_line":"        if not allow_max and pos not in range(max_pos):"},{"line_number":242,"context_line":"            return None"},{"line_number":243,"context_line":"        return pos"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_54375ab0","line":241,"in_reply_to":"da86d52c_14b9622e","updated":"2015-02-09 17:36:43.000000000","message":"I personally think grouping the two conditions makes the statement easier to mentally parse.","commit_id":"ccdd31c77f640679bc406a07484076e29eb180e2"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"1bac1facf6e1265f6474f8d5d82ebfd7355b4a06","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            pos \u003d int(path_pos)"},{"line_number":239,"context_line":"        elif path_pos !\u003d \u0027-\u0027:"},{"line_number":240,"context_line":"            return None"},{"line_number":241,"context_line":"        if not allow_max and pos not in range(max_pos):"},{"line_number":242,"context_line":"            return None"},{"line_number":243,"context_line":"        return pos"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_6de712e5","line":241,"in_reply_to":"da86d52c_4dd32e5f","updated":"2015-02-10 07:18:52.000000000","message":"Thanks for feedback, let\u0027s revert the confusing statements.","commit_id":"ccdd31c77f640679bc406a07484076e29eb180e2"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"f7685f29d93dffa0cb5c258a8c0dc76c91695a58","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            pos \u003d int(path_pos)"},{"line_number":239,"context_line":"        elif path_pos !\u003d \u0027-\u0027:"},{"line_number":240,"context_line":"            return None"},{"line_number":241,"context_line":"        if not allow_max and pos not in range(max_pos):"},{"line_number":242,"context_line":"            return None"},{"line_number":243,"context_line":"        return pos"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_4dd32e5f","line":241,"in_reply_to":"da86d52c_54375ab0","updated":"2015-02-10 07:08:12.000000000","message":"I think the brackets are not harmful, and if they help some readers thats fine, for both files.","commit_id":"ccdd31c77f640679bc406a07484076e29eb180e2"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"65a8d0b3610bb8fe6bc4a9010a4b921652432c2d","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            pos \u003d int(path_pos)"},{"line_number":239,"context_line":"        elif path_pos !\u003d \u0027-\u0027:"},{"line_number":240,"context_line":"            return None"},{"line_number":241,"context_line":"        if not allow_max and pos not in range(max_pos):"},{"line_number":242,"context_line":"            return None"},{"line_number":243,"context_line":"        return pos"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_14b9622e","line":241,"in_reply_to":"da86d52c_e69fc5b2","updated":"2015-02-09 17:32:52.000000000","message":"I\u0027m confused with that one. Raise your hand guys if have any opinion about it, so we can stick to the best one.","commit_id":"ccdd31c77f640679bc406a07484076e29eb180e2"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"fd5daac2daa48833112a94edc860c9fb31b0da10","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        except Exception as e:"},{"line_number":294,"context_line":"            raise webob.exc.HTTPInternalServerError("},{"line_number":295,"context_line":"                explanation\u003dutils.exception_to_str(e))"},{"line_number":296,"context_line":"        if not image.locations and image.status \u003d\u003d \u0027active\u0027:"},{"line_number":297,"context_line":"            image.status \u003d \u0027queued\u0027"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_48308407","line":296,"updated":"2015-02-16 20:03:56.000000000","message":"So you\u0027re inherently not just removing parentheses. I\u0027d rather you only remove parentheses in a commit with the subject:\n\n    Remove redundant parentheses in conditional statements\n\nPlease revert the change of\n\n    len(image.locations) \u003d\u003d 0","commit_id":"a5aa66fc16e176791ae1dfaa4ec86627c28a0690"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"6d5039fd932bbe65d686bfe65c856c9a0d8014a2","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        except Exception as e:"},{"line_number":294,"context_line":"            raise webob.exc.HTTPInternalServerError("},{"line_number":295,"context_line":"                explanation\u003dutils.exception_to_str(e))"},{"line_number":296,"context_line":"        if not image.locations and image.status \u003d\u003d \u0027active\u0027:"},{"line_number":297,"context_line":"            image.status \u003d \u0027queued\u0027"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_c5528934","line":296,"in_reply_to":"da86d52c_48308407","updated":"2015-02-17 11:34:39.000000000","message":"Done","commit_id":"a5aa66fc16e176791ae1dfaa4ec86627c28a0690"}],"glance/cmd/control.py":[{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"e5f9d255e04de5eb094954f34456efbb6a5427ee","unresolved":false,"context_lines":[{"line_number":380,"context_line":"            pid_file \u003d get_pid_file(server, CONF.pid_file)"},{"line_number":381,"context_line":"            do_start(\u0027Restart\u0027, pid_file, server, CONF.server.args)"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    if CONF.server.command in [\u0027reload\u0027, \u0027force-reload\u0027]:"},{"line_number":384,"context_line":"        for server in CONF.server.servers:"},{"line_number":385,"context_line":"            do_stop(server, CONF.server.args, graceful\u003dTrue)"},{"line_number":386,"context_line":"            pid_file \u003d get_pid_file(server, CONF.pid_file)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_6169ff24","line":383,"updated":"2015-02-09 17:10:12.000000000","message":"Could this be a tuple instead of a list?\n\n    if CONF.server.command in (\u0027reload\u0027, \u0027force-reload\u0027):","commit_id":"ccdd31c77f640679bc406a07484076e29eb180e2"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"38b978a3d8fbb5331a6011650308b129ad5a2aa3","unresolved":false,"context_lines":[{"line_number":380,"context_line":"            pid_file \u003d get_pid_file(server, CONF.pid_file)"},{"line_number":381,"context_line":"            do_start(\u0027Restart\u0027, pid_file, server, CONF.server.args)"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    if CONF.server.command in [\u0027reload\u0027, \u0027force-reload\u0027]:"},{"line_number":384,"context_line":"        for server in CONF.server.servers:"},{"line_number":385,"context_line":"            do_stop(server, CONF.server.args, graceful\u003dTrue)"},{"line_number":386,"context_line":"            pid_file \u003d get_pid_file(server, CONF.pid_file)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_e186cf64","line":383,"updated":"2015-02-09 17:39:33.000000000","message":"Good one, even despite the fact that this is a list;)","commit_id":"ccdd31c77f640679bc406a07484076e29eb180e2"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"74c19788cd118483939ac4ebdf364cca7a782e48","unresolved":false,"context_lines":[{"line_number":380,"context_line":"            pid_file \u003d get_pid_file(server, CONF.pid_file)"},{"line_number":381,"context_line":"            do_start(\u0027Restart\u0027, pid_file, server, CONF.server.args)"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    if CONF.server.command in [\u0027reload\u0027, \u0027force-reload\u0027]:"},{"line_number":384,"context_line":"        for server in CONF.server.servers:"},{"line_number":385,"context_line":"            do_stop(server, CONF.server.args, graceful\u003dTrue)"},{"line_number":386,"context_line":"            pid_file \u003d get_pid_file(server, CONF.pid_file)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_d1399cd9","line":383,"in_reply_to":"da86d52c_6169ff24","updated":"2015-02-09 17:13:39.000000000","message":"+1","commit_id":"ccdd31c77f640679bc406a07484076e29eb180e2"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"65a8d0b3610bb8fe6bc4a9010a4b921652432c2d","unresolved":false,"context_lines":[{"line_number":380,"context_line":"            pid_file \u003d get_pid_file(server, CONF.pid_file)"},{"line_number":381,"context_line":"            do_start(\u0027Restart\u0027, pid_file, server, CONF.server.args)"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    if CONF.server.command in [\u0027reload\u0027, \u0027force-reload\u0027]:"},{"line_number":384,"context_line":"        for server in CONF.server.servers:"},{"line_number":385,"context_line":"            do_stop(server, CONF.server.args, graceful\u003dTrue)"},{"line_number":386,"context_line":"            pid_file \u003d get_pid_file(server, CONF.pid_file)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_31a59847","line":383,"in_reply_to":"da86d52c_6169ff24","updated":"2015-02-09 17:32:52.000000000","message":"Roger that.","commit_id":"ccdd31c77f640679bc406a07484076e29eb180e2"}],"glance/common/client.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"fd5daac2daa48833112a94edc860c9fb31b0da10","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                        \"GLANCE_CLIENT_CERT_FILE environ variable\")"},{"line_number":257,"context_line":"                raise exception.ClientConnectionError(msg)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"            if self.key_file is not None and not os.path.exists(self.key_file):"},{"line_number":260,"context_line":"                msg \u003d _(\"The key file you specified %s does not \""},{"line_number":261,"context_line":"                        \"exist\") % self.key_file"},{"line_number":262,"context_line":"                raise exception.ClientConnectionError(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_a814a04d","line":259,"updated":"2015-02-16 20:03:56.000000000","message":"So this is a change where I have to agree with Erno\u0027s early statement. Shorter lines are inherently easier to read and reason about. In my opinion (note opinion), this is easier to read as two separate lines.","commit_id":"a5aa66fc16e176791ae1dfaa4ec86627c28a0690"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"6d5039fd932bbe65d686bfe65c856c9a0d8014a2","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                        \"GLANCE_CLIENT_CERT_FILE environ variable\")"},{"line_number":257,"context_line":"                raise exception.ClientConnectionError(msg)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"            if self.key_file is not None and not os.path.exists(self.key_file):"},{"line_number":260,"context_line":"                msg \u003d _(\"The key file you specified %s does not \""},{"line_number":261,"context_line":"                        \"exist\") % self.key_file"},{"line_number":262,"context_line":"                raise exception.ClientConnectionError(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_e0cf7bb1","line":259,"in_reply_to":"da86d52c_a814a04d","updated":"2015-02-17 11:34:39.000000000","message":"Done","commit_id":"a5aa66fc16e176791ae1dfaa4ec86627c28a0690"}],"glance/tests/stubs.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"1cc4cc129845c74af97331def5d509347ae0bf3e","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        DEFAULT_REGISTRY_PORT \u003d 9191"},{"line_number":168,"context_line":"        DEFAULT_API_PORT \u003d 9292"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        if client.port \u003d\u003d DEFAULT_API_PORT and client.host \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":171,"context_line":"            return FakeGlanceConnection"},{"line_number":172,"context_line":"        elif client.port \u003d\u003d DEFAULT_REGISTRY_PORT and client.host \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":173,"context_line":"            rserver \u003d kwargs.get(\"registry\", None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_05d4a145","line":170,"updated":"2015-02-10 13:33:56.000000000","message":"I do not think that this change improves readability. Quite opposite.","commit_id":"a5aa66fc16e176791ae1dfaa4ec86627c28a0690"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"6d5039fd932bbe65d686bfe65c856c9a0d8014a2","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        DEFAULT_REGISTRY_PORT \u003d 9191"},{"line_number":168,"context_line":"        DEFAULT_API_PORT \u003d 9292"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        if client.port \u003d\u003d DEFAULT_API_PORT and client.host \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":171,"context_line":"            return FakeGlanceConnection"},{"line_number":172,"context_line":"        elif client.port \u003d\u003d DEFAULT_REGISTRY_PORT and client.host \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":173,"context_line":"            rserver \u003d kwargs.get(\"registry\", None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_00ec8f28","line":170,"in_reply_to":"da86d52c_05d4a145","updated":"2015-02-17 11:34:39.000000000","message":"Done","commit_id":"a5aa66fc16e176791ae1dfaa4ec86627c28a0690"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"fd5daac2daa48833112a94edc860c9fb31b0da10","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        DEFAULT_REGISTRY_PORT \u003d 9191"},{"line_number":168,"context_line":"        DEFAULT_API_PORT \u003d 9292"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        if client.port \u003d\u003d DEFAULT_API_PORT and client.host \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":171,"context_line":"            return FakeGlanceConnection"},{"line_number":172,"context_line":"        elif client.port \u003d\u003d DEFAULT_REGISTRY_PORT and client.host \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":173,"context_line":"            rserver \u003d kwargs.get(\"registry\", None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_1ee1662a","line":170,"in_reply_to":"da86d52c_05d4a145","updated":"2015-02-16 20:03:56.000000000","message":"I feel less strongly about it\u0027s removal here than below.","commit_id":"a5aa66fc16e176791ae1dfaa4ec86627c28a0690"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"6d5039fd932bbe65d686bfe65c856c9a0d8014a2","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        DEFAULT_REGISTRY_PORT \u003d 9191"},{"line_number":168,"context_line":"        DEFAULT_API_PORT \u003d 9292"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        if client.port \u003d\u003d DEFAULT_API_PORT and client.host \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":171,"context_line":"            return FakeGlanceConnection"},{"line_number":172,"context_line":"        elif client.port \u003d\u003d DEFAULT_REGISTRY_PORT and client.host \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":173,"context_line":"            rserver \u003d kwargs.get(\"registry\", None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_40f687fa","line":170,"in_reply_to":"da86d52c_1ee1662a","updated":"2015-02-17 11:34:39.000000000","message":"Done","commit_id":"a5aa66fc16e176791ae1dfaa4ec86627c28a0690"}],"glance/tests/unit/utils.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"fd5daac2daa48833112a94edc860c9fb31b0da10","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            # pipeline, so peek under the hood of those objects to get at the"},{"line_number":197,"context_line":"            # string itself."},{"line_number":198,"context_line":"            size \u003d len(data.data.fd)"},{"line_number":199,"context_line":"        if current_store_size + size \u003e store_max_size:"},{"line_number":200,"context_line":"            raise exception.StorageFull()"},{"line_number":201,"context_line":"        if context.user \u003d\u003d USER2:"},{"line_number":202,"context_line":"            raise exception.Forbidden()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_9ecc76bd","line":199,"updated":"2015-02-16 20:03:56.000000000","message":"For many people, not having to recall operator precedence makes this easier to read the old way. It may be unnecessary the old way, but it\u0027s certainly easier to read","commit_id":"a5aa66fc16e176791ae1dfaa4ec86627c28a0690"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"6d5039fd932bbe65d686bfe65c856c9a0d8014a2","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            # pipeline, so peek under the hood of those objects to get at the"},{"line_number":197,"context_line":"            # string itself."},{"line_number":198,"context_line":"            size \u003d len(data.data.fd)"},{"line_number":199,"context_line":"        if current_store_size + size \u003e store_max_size:"},{"line_number":200,"context_line":"            raise exception.StorageFull()"},{"line_number":201,"context_line":"        if context.user \u003d\u003d USER2:"},{"line_number":202,"context_line":"            raise exception.Forbidden()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_e09a1bc4","line":199,"in_reply_to":"da86d52c_9ecc76bd","updated":"2015-02-17 11:34:39.000000000","message":"Done","commit_id":"a5aa66fc16e176791ae1dfaa4ec86627c28a0690"}]}