)]}'
{"glance/api/v2/images.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"5f7f0dca6619a86c85809d0955c9ff692a9a3888","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        value \u003d change[\u0027value\u0027]"},{"line_number":183,"context_line":"        if path_root \u003d\u003d \u0027locations\u0027:"},{"line_number":184,"context_line":"            self._do_replace_locations(image, value)"},{"line_number":185,"context_line":"        elif path_root \u003d\u003d \u0027owner\u0027 and req.context.is_admin \u003d\u003d False:"},{"line_number":186,"context_line":"            msg \u003d _(\"Owner can\u0027t be updated by non admin.\")"},{"line_number":187,"context_line":"            raise webob.exc.HTTPForbidden(msg)"},{"line_number":188,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_525df246","line":185,"updated":"2015-06-26 17:58:12.000000000","message":"Anyway I think that more pythonic way is \"is False\" rather than \"\u003d\u003d False\" :)","commit_id":"118c158a0cf98ea20e1a2bce5c034ebac88f4ded"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"ea1ba5f82f63e9caa6085c6722667a1edf92919c","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        value \u003d change[\u0027value\u0027]"},{"line_number":183,"context_line":"        if path_root \u003d\u003d \u0027locations\u0027:"},{"line_number":184,"context_line":"            self._do_replace_locations(image, value)"},{"line_number":185,"context_line":"        elif path_root \u003d\u003d \u0027owner\u0027 and req.context.is_admin \u003d\u003d False:"},{"line_number":186,"context_line":"            msg \u003d _(\"Owner can\u0027t be updated by non admin.\")"},{"line_number":187,"context_line":"            raise webob.exc.HTTPForbidden(msg)"},{"line_number":188,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_b0674bb6","line":185,"updated":"2015-06-23 12:09:09.000000000","message":"FWIW, I agree with Abhishek here but I\u0027m not going to block this patch on that","commit_id":"118c158a0cf98ea20e1a2bce5c034ebac88f4ded"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"dc39486455142ed17fd866e731b08c9111986b12","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        value \u003d change[\u0027value\u0027]"},{"line_number":183,"context_line":"        if path_root \u003d\u003d \u0027locations\u0027:"},{"line_number":184,"context_line":"            self._do_replace_locations(image, value)"},{"line_number":185,"context_line":"        elif path_root \u003d\u003d \u0027owner\u0027 and req.context.is_admin \u003d\u003d False:"},{"line_number":186,"context_line":"            msg \u003d _(\"Owner can\u0027t be updated by non admin.\")"},{"line_number":187,"context_line":"            raise webob.exc.HTTPForbidden(msg)"},{"line_number":188,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_ba46891f","line":185,"updated":"2015-06-22 09:48:11.000000000","message":"req.context.is_admin \u003d\u003d False \u003e\u003e not req.context.is_admin","commit_id":"118c158a0cf98ea20e1a2bce5c034ebac88f4ded"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"f11924259b2a3e24a73114e8513e6ec971db4415","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        value \u003d change[\u0027value\u0027]"},{"line_number":183,"context_line":"        if path_root \u003d\u003d \u0027locations\u0027:"},{"line_number":184,"context_line":"            self._do_replace_locations(image, value)"},{"line_number":185,"context_line":"        elif path_root \u003d\u003d \u0027owner\u0027 and req.context.is_admin \u003d\u003d False:"},{"line_number":186,"context_line":"            msg \u003d _(\"Owner can\u0027t be updated by non admin.\")"},{"line_number":187,"context_line":"            raise webob.exc.HTTPForbidden(msg)"},{"line_number":188,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_99e5210a","line":185,"in_reply_to":"ba3cc151_350d7490","updated":"2015-07-03 11:00:57.000000000","message":"It also should be red.","commit_id":"118c158a0cf98ea20e1a2bce5c034ebac88f4ded"},{"author":{"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"},"change_message_id":"47644ec9b5b858f5f7272f8b096e9da77ab8bd01","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        value \u003d change[\u0027value\u0027]"},{"line_number":183,"context_line":"        if path_root \u003d\u003d \u0027locations\u0027:"},{"line_number":184,"context_line":"            self._do_replace_locations(image, value)"},{"line_number":185,"context_line":"        elif path_root \u003d\u003d \u0027owner\u0027 and req.context.is_admin \u003d\u003d False:"},{"line_number":186,"context_line":"            msg \u003d _(\"Owner can\u0027t be updated by non admin.\")"},{"line_number":187,"context_line":"            raise webob.exc.HTTPForbidden(msg)"},{"line_number":188,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_350d7490","line":185,"in_reply_to":"fa32b979_525df246","updated":"2015-07-01 06:49:50.000000000","message":"Agree. \"is False\" is better than \"\u003d\u003d False\".","commit_id":"118c158a0cf98ea20e1a2bce5c034ebac88f4ded"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"12bcc08aaca0299135202da5da6ee7dbb6c455d6","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        value \u003d change[\u0027value\u0027]"},{"line_number":183,"context_line":"        if path_root \u003d\u003d \u0027locations\u0027:"},{"line_number":184,"context_line":"            self._do_replace_locations(image, value)"},{"line_number":185,"context_line":"        elif path_root \u003d\u003d \u0027owner\u0027 and req.context.is_admin \u003d\u003d False:"},{"line_number":186,"context_line":"            msg \u003d _(\"Owner can\u0027t be updated by non admin.\")"},{"line_number":187,"context_line":"            raise webob.exc.HTTPForbidden(msg)"},{"line_number":188,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_b363eb40","line":185,"in_reply_to":"fa32b979_ba46891f","updated":"2015-06-23 02:34:17.000000000","message":"I would like to use current way to make it more explicit.","commit_id":"118c158a0cf98ea20e1a2bce5c034ebac88f4ded"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"dc39486455142ed17fd866e731b08c9111986b12","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            self._do_replace_locations(image, value)"},{"line_number":185,"context_line":"        elif path_root \u003d\u003d \u0027owner\u0027 and req.context.is_admin \u003d\u003d False:"},{"line_number":186,"context_line":"            msg \u003d _(\"Owner can\u0027t be updated by non admin.\")"},{"line_number":187,"context_line":"            raise webob.exc.HTTPForbidden(msg)"},{"line_number":188,"context_line":"        else:"},{"line_number":189,"context_line":"            if hasattr(image, path_root):"},{"line_number":190,"context_line":"                setattr(image, path_root, value)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_da57cdc8","line":187,"updated":"2015-06-22 09:48:11.000000000","message":"nit: you can directly pass message to HTTPForbidden as msg is used only once","commit_id":"118c158a0cf98ea20e1a2bce5c034ebac88f4ded"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"12bcc08aaca0299135202da5da6ee7dbb6c455d6","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            self._do_replace_locations(image, value)"},{"line_number":185,"context_line":"        elif path_root \u003d\u003d \u0027owner\u0027 and req.context.is_admin \u003d\u003d False:"},{"line_number":186,"context_line":"            msg \u003d _(\"Owner can\u0027t be updated by non admin.\")"},{"line_number":187,"context_line":"            raise webob.exc.HTTPForbidden(msg)"},{"line_number":188,"context_line":"        else:"},{"line_number":189,"context_line":"            if hasattr(image, path_root):"},{"line_number":190,"context_line":"                setattr(image, path_root, value)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_f6e5eca7","line":187,"in_reply_to":"fa32b979_da57cdc8","updated":"2015-06-23 02:34:17.000000000","message":"I can\u0027t see much benefit to pass the message directly, at least it will need a new line. And I would like to keep consistence with the other code.","commit_id":"118c158a0cf98ea20e1a2bce5c034ebac88f4ded"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"f11924259b2a3e24a73114e8513e6ec971db4415","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            self._do_replace_locations(image, value)"},{"line_number":185,"context_line":"        elif path_root \u003d\u003d \u0027owner\u0027 and req.context.is_admin \u003d\u003d False:"},{"line_number":186,"context_line":"            msg \u003d _(\"Owner can\u0027t be updated by non admin.\")"},{"line_number":187,"context_line":"            raise webob.exc.HTTPForbidden(msg)"},{"line_number":188,"context_line":"        else:"},{"line_number":189,"context_line":"            if hasattr(image, path_root):"},{"line_number":190,"context_line":"                setattr(image, path_root, value)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_591479e7","line":187,"in_reply_to":"fa32b979_f6e5eca7","updated":"2015-07-03 11:00:57.000000000","message":"++ of being consistent and not having benefit of combining those two lines to two new lines.","commit_id":"118c158a0cf98ea20e1a2bce5c034ebac88f4ded"}]}