)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"a9a17b399cc4491a7b883056f4e692704530d603","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gorka Eguileor \u003cgeguileo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-17 15:38:25 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Partial fix for bug #1422699 by expecting BadStoreConfiguration exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since glance-store will now be propagate exception BadStoreConfiguration on method"},{"line_number":10,"context_line":"create_stores we need to catch it and properly display the error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_d3dc0549","line":7,"updated":"2015-02-17 17:55:12.000000000","message":"Titles should be less than 50 characters long and preferably imperative, e.g.,\n\n    Add BadStoreConfiguration exception handling to glance-api\n\n(Which might not be 50 characters or less but demonstrates the imperative way of writing the message).","commit_id":"72b57ec76fa892c94ac985951c1c33020062ad61"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"a9a17b399cc4491a7b883056f4e692704530d603","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Partial fix for bug #1422699 by expecting BadStoreConfiguration exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since glance-store will now be propagate exception BadStoreConfiguration on method"},{"line_number":10,"context_line":"create_stores we need to catch it and properly display the error."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifc038874aa0388b036729790a883ae1e1efd323d"},{"line_number":13,"context_line":"Partial-Bug: #1422699"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da86d52c_d3b32508","line":10,"updated":"2015-02-17 17:55:12.000000000","message":"Messages should be hard wrapped at 72 characters.","commit_id":"72b57ec76fa892c94ac985951c1c33020062ad61"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"0a7188304839a5332a25073b117d2bedbae223f9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add BadStoreConfiguration handling to glance-api"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partial fix for bug #1422699"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Glace-api now handles BadStoreConfiguration exceptions from glance-store"},{"line_number":12,"context_line":"library."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da86d52c_797a57bb","line":9,"updated":"2015-02-17 19:00:16.000000000","message":"This duplicates the \u0027Partial-Bug\u0027 line","commit_id":"82ac4ca11c562c98ce4b7bf8c1fd1bf484a9d98e"}],"glance/cmd/api.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"0a7188304839a5332a25073b117d2bedbae223f9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"def fail(e):"},{"line_number":63,"context_line":"    global KNOWN_EXCEPTIONS"},{"line_number":64,"context_line":"    try:"},{"line_number":65,"context_line":"        return_code \u003d KNOWN_EXCEPTIONS.index(type(e)) + 1"},{"line_number":66,"context_line":"        sys.stderr.write(\"ERROR: %s\\n\" % utils.exception_to_str(e))"},{"line_number":67,"context_line":"        sys.exit(return_code)"},{"line_number":68,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_598f53cd","line":65,"updated":"2015-02-17 19:00:16.000000000","message":"You don\u0027t need the try/except code here since we\u0027re only ever catching exception types in KNOWN_EXCEPTIONS","commit_id":"82ac4ca11c562c98ce4b7bf8c1fd1bf484a9d98e"}]}