)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"963f44ba5cfdfabdabe73d86986edb1e82df4ae2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Geetika Batra \u003cgeetika791@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-24 04:40:56 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"asserts used in cache.py"},{"line_number":8,"context_line":"The assert statement is replaced by if not condition: raise AssertionError."},{"line_number":9,"context_line":"As stated in the Python documentation assert statements will not be evaluated"},{"line_number":10,"context_line":"when the Python code is compiled with optimization flags. This means that these"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba7be1f8_e92f6ef4","line":7,"updated":"2015-02-23 23:23:53.000000000","message":"The title can be more along the lines of:\n\n\"Fixes insecure use of asserts in cache.py\"","commit_id":"908383c7356c60f51dd5345da63ce2cb77f8cceb"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"f0f3b264d5e1142033a022aa1e1e8e4626cb6ea3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Geetika Batra \u003cgeetika791@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-24 04:40:56 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"asserts used in cache.py"},{"line_number":8,"context_line":"The assert statement is replaced by if not condition: raise AssertionError."},{"line_number":9,"context_line":"As stated in the Python documentation assert statements will not be evaluated"},{"line_number":10,"context_line":"when the Python code is compiled with optimization flags. This means that these"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba7be1f8_29a42656","line":7,"in_reply_to":"ba7be1f8_e92f6ef4","updated":"2015-02-23 23:28:25.000000000","message":"A very useful page on writing good commit messages is here: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"908383c7356c60f51dd5345da63ce2cb77f8cceb"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"963f44ba5cfdfabdabe73d86986edb1e82df4ae2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-02-24 04:40:56 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"asserts used in cache.py"},{"line_number":8,"context_line":"The assert statement is replaced by if not condition: raise AssertionError."},{"line_number":9,"context_line":"As stated in the Python documentation assert statements will not be evaluated"},{"line_number":10,"context_line":"when the Python code is compiled with optimization flags. This means that these"},{"line_number":11,"context_line":"checks will not be properly executed and one can in that case call a specific"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba7be1f8_49407aa5","line":8,"updated":"2015-02-23 23:23:53.000000000","message":"Need a blank line after the title.","commit_id":"908383c7356c60f51dd5345da63ce2cb77f8cceb"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"963f44ba5cfdfabdabe73d86986edb1e82df4ae2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"checks will not be properly executed and one can in that case call a specific"},{"line_number":12,"context_line":"method with a completely different HTTP verb. This can result in security"},{"line_number":13,"context_line":"issues."},{"line_number":14,"context_line":"Fixing this ensures security."},{"line_number":15,"context_line":"Closes-bug: #1414532"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I60b42d5a5d71602be7adc321406ea87dfcf93f46"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba7be1f8_496eba30","line":14,"updated":"2015-02-23 23:23:53.000000000","message":"Just replace this line with flag:\n\nSecurityImpact \n\nPlease see http://docs.openstack.org/infra/manual/developers.html#peer-review","commit_id":"908383c7356c60f51dd5345da63ce2cb77f8cceb"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"4cb71258c7025aa023c61765a2634f7e74a0d8cc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Geetika Batra \u003cgeetika791@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-24 05:00:11 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\"Fixes insecure use of asserts in cache.py\""},{"line_number":8,"context_line":"The assert statement is replaced by"},{"line_number":9,"context_line":"if not condition:"},{"line_number":10,"context_line":" raise AssertionError."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba7be1f8_693efa29","line":7,"updated":"2015-02-24 16:53:48.000000000","message":"Please remove quotes.","commit_id":"f42af53af1f1568dc9221754f611b0f16fee9889"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"7f4b3abf00c370356c984700c36dbdc9b36a4f0f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"The assert statement is replaced by"},{"line_number":9,"context_line":"if not condition:"},{"line_number":10,"context_line":" raise AssertionError."},{"line_number":11,"context_line":"As stated in the Python documentation assert statements will not be evaluated"},{"line_number":12,"context_line":"when the Python code is compiled with optimization flags. This means that these"},{"line_number":13,"context_line":"checks will not be properly executed and one can in that case call a specific"},{"line_number":14,"context_line":"method with a completely different HTTP verb. This can result in security"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba7be1f8_ddbb40e3","line":11,"updated":"2015-02-24 01:16:00.000000000","message":"The subject should not be quoted and there needs to be a new line between the subject and the body. For example:\n\n    Fixes use of asserts in cache.py\n\n    The assert statement is replaced by\n     ....\n\nNote I also removed the use of \"insecure\" as it\u0027s inflammatory in this context. There isn\u0027t much of an attack vector here, as has been discussed on issue 1414532 so you\u0027re more fixing a bug than fixing a security issue.","commit_id":"f42af53af1f1568dc9221754f611b0f16fee9889"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"9f52a1f7190dbf865a88c1376ef25a1ddbf2ec54","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-03-03 16:12:03 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes insecure use of asserts in cache.py"},{"line_number":8,"context_line":"The assert statement is replaced by"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if image_id \u003d\u003d \u0027detail\u0027:"},{"line_number":11,"context_line":"    continue"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba7be1f8_9b00c235","line":8,"updated":"2015-03-03 10:53:02.000000000","message":"I think it\u0027s not necessary to write what you exactly do in the commit. People can see it by looking at the code. Besides, you change two asserts there, but mention only one here...\n\nI suggest to rewrite this a little bit simpler:\n\nThe asserts are replaced with if statements.\n\nAnd also, put an empty line after the commit title.","commit_id":"565566f417876a84ae815a7381d93d62597a9196"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"9f52a1f7190dbf865a88c1376ef25a1ddbf2ec54","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    continue"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"As stated in the Python documentation assert statements will not be evaluated"},{"line_number":14,"context_line":"when the Python code is compiled with optimization flags. This means that these"},{"line_number":15,"context_line":"checks will not be properly executed and one can in that case call a specific"},{"line_number":16,"context_line":"method with a completely different HTTP verb. This can result in security"},{"line_number":17,"context_line":"issues."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba7be1f8_bbf90650","line":14,"updated":"2015-03-03 10:53:02.000000000","message":"Please, wrap these lines in 72 symbols as it stated in https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"565566f417876a84ae815a7381d93d62597a9196"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"a6844182a8ab3ce592aab77509e9258d9d37f45e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"checks will not be properly executed and one can in that case call a specific"},{"line_number":16,"context_line":"method with a completely different HTTP verb. This can result in security"},{"line_number":17,"context_line":"issues."},{"line_number":18,"context_line":"SecurityImpact"},{"line_number":19,"context_line":"Closes-bug: #1414532"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I60b42d5a5d71602be7adc321406ea87dfcf93f46"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba7be1f8_6784290b","line":18,"updated":"2015-03-04 00:48:07.000000000","message":"If I recall correctly, the discussion on the bug decided this is not a security problem. Please remove this flag, it is misleading.","commit_id":"565566f417876a84ae815a7381d93d62597a9196"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"d1c90e60b7bb32bfdc01d188cdf375f954498d23","unresolved":false,"context_lines":[{"line_number":11,"context_line":"elif) prevents the matcher from returning an invalid match."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1414532"},{"line_number":14,"context_line":"Co-Authored-By: Ian Cordasco \u003cian.cordasco@rackspace.com\u003e"},{"line_number":15,"context_line":"Change-Id: I60b42d5a5d71602be7adc321406ea87dfcf93f46"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a80dd14_6e246bc6","line":14,"updated":"2015-03-18 11:13:07.000000000","message":"Please, add Geetika as a co-author here too. \n\nCo-Authored-By: Geetika Batra \u003cgeetika791@gmail.com\u003e\n\nBecause otherwise she won\u0027t be mentioned in the stats.","commit_id":"f075c4e10f303a2a3375f9d82ce52f991a173296"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"87d8926570340fcd641b9da4acc28becbf60988e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"elif) prevents the matcher from returning an invalid match."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1414532"},{"line_number":14,"context_line":"Co-Authored-By: Ian Cordasco \u003cian.cordasco@rackspace.com\u003e"},{"line_number":15,"context_line":"Change-Id: I60b42d5a5d71602be7adc321406ea87dfcf93f46"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a80dd14_f733c710","line":14,"in_reply_to":"9a80dd14_6e246bc6","updated":"2015-03-18 14:07:44.000000000","message":"She is the author of the commit (look above).","commit_id":"f075c4e10f303a2a3375f9d82ce52f991a173296"}],"glance/api/middleware/cache.py":[{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"f0f3b264d5e1142033a022aa1e1e8e4626cb6ea3","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        for ((version, method), pattern) in PATTERNS.items():"},{"line_number":86,"context_line":"            match \u003d pattern.match(request.path_info)"},{"line_number":87,"context_line":"            try:"},{"line_number":88,"context_line":"               if not request.method \u003d\u003d method: raise AssertionError"},{"line_number":89,"context_line":"                image_id \u003d match.group(1)"},{"line_number":90,"context_line":"                # Ensure the image id we got looks like an image id to filter"},{"line_number":91,"context_line":"                # out a URI like /images/detail. See LP Bug #879136"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_a91c96c2","line":88,"updated":"2015-02-23 23:28:25.000000000","message":"Could you please indent the raise statement under the if statement like:\n\n    if not request.method \u003d\u003d method:\n        raise AssertionError","commit_id":"908383c7356c60f51dd5345da63ce2cb77f8cceb"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"7f4b3abf00c370356c984700c36dbdc9b36a4f0f","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        for ((version, method), pattern) in PATTERNS.items():"},{"line_number":86,"context_line":"            match \u003d pattern.match(request.path_info)"},{"line_number":87,"context_line":"            try:"},{"line_number":88,"context_line":"               if not request.method \u003d\u003d method: raise AssertionError"},{"line_number":89,"context_line":"                image_id \u003d match.group(1)"},{"line_number":90,"context_line":"                # Ensure the image id we got looks like an image id to filter"},{"line_number":91,"context_line":"                # out a URI like /images/detail. See LP Bug #879136"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_dd90a045","line":88,"updated":"2015-02-24 01:16:00.000000000","message":"You need to indent this by a space and put the raise statement on a new-line\n\n    try:\n        if request.method !\u003d method:\n            continue\n        image_id \u003d match.group(1)\n        ...\n    except AttributeError:\n        continue\n\nThere\u0027s also no need to raise an AssertionError here when we can just continue the loop without triggering an exception, so please remove the handling for an AssertionError here.","commit_id":"f42af53af1f1568dc9221754f611b0f16fee9889"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"5f5e21eb4d93a5a7cff6c81ce42bd2900a31fb09","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        for ((version, method), pattern) in PATTERNS.items():"},{"line_number":86,"context_line":"            match \u003d pattern.match(request.path_info)"},{"line_number":87,"context_line":"            try:"},{"line_number":88,"context_line":"               if not request.method \u003d\u003d method: raise AssertionError"},{"line_number":89,"context_line":"                image_id \u003d match.group(1)"},{"line_number":90,"context_line":"                # Ensure the image id we got looks like an image id to filter"},{"line_number":91,"context_line":"                # out a URI like /images/detail. See LP Bug #879136"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_d58e542d","line":88,"in_reply_to":"ba7be1f8_293fa2d7","updated":"2015-02-25 21:36:48.000000000","message":"I think doing the exact same thing makes sense since we\u0027re using assertions here for control flow and python -O can remove them. Good catch Mike","commit_id":"f42af53af1f1568dc9221754f611b0f16fee9889"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"4cb71258c7025aa023c61765a2634f7e74a0d8cc","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        for ((version, method), pattern) in PATTERNS.items():"},{"line_number":86,"context_line":"            match \u003d pattern.match(request.path_info)"},{"line_number":87,"context_line":"            try:"},{"line_number":88,"context_line":"               if not request.method \u003d\u003d method: raise AssertionError"},{"line_number":89,"context_line":"                image_id \u003d match.group(1)"},{"line_number":90,"context_line":"                # Ensure the image id we got looks like an image id to filter"},{"line_number":91,"context_line":"                # out a URI like /images/detail. See LP Bug #879136"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_293fa2d7","line":88,"in_reply_to":"ba7be1f8_dd90a045","updated":"2015-02-24 16:53:48.000000000","message":"It\u0027s not exactly correct, because there is another assert to check:\nassert image_id !\u003d \u0027detail\u0027\n\nI would prefer to leave this handling:\n\ntry:\n    if request.method !\u003d method:\n        continue\n    image_id \u003d match.group(1)\n    ...\n    assert image_id !\u003d \u0027detail\u0027\nexcept (AttributeError, AssertionError):\n    continue\n\nor just write exactly the same thing:\n\nif image_id \u003d\u003d \u0027detail\u0027:\n    continue","commit_id":"f42af53af1f1568dc9221754f611b0f16fee9889"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d815498f81c70b02888367bce779dde8c51cdac5","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            try:"},{"line_number":88,"context_line":"               if request.method !\u003d method:"},{"line_number":89,"context_line":"                   continue"},{"line_number":90,"context_line":"                image_id \u003d match.group(1)"},{"line_number":91,"context_line":"                # Ensure the image id we got looks like an image id to filter"},{"line_number":92,"context_line":"                # out a URI like /images/detail. See LP Bug #879136"},{"line_number":93,"context_line":"                if image_id \u003d\u003d \u0027detail\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_800db140","line":90,"updated":"2015-03-03 10:31:09.000000000","message":"Code is not aligned properly.","commit_id":"7f0b2c98a55dbac09b82a237f8670e8910e8b793"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d815498f81c70b02888367bce779dde8c51cdac5","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                # out a URI like /images/detail. See LP Bug #879136"},{"line_number":93,"context_line":"                if image_id \u003d\u003d \u0027detail\u0027:"},{"line_number":94,"context_line":"                    continue"},{"line_number":95,"context_line":"           \telse:"},{"line_number":96,"context_line":"                    return (version, method, image_id)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def _enforce(self, req, action, target\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_203885ee","line":95,"updated":"2015-03-03 10:31:09.000000000","message":"no need of else block.","commit_id":"7f0b2c98a55dbac09b82a237f8670e8910e8b793"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"9f52a1f7190dbf865a88c1376ef25a1ddbf2ec54","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        for ((version, method), pattern) in PATTERNS.items():"},{"line_number":86,"context_line":"            match \u003d pattern.match(request.path_info)"},{"line_number":87,"context_line":"            try:"},{"line_number":88,"context_line":"               if request.method !\u003d method:"},{"line_number":89,"context_line":"                   continue"},{"line_number":90,"context_line":"            image_id \u003d match.group(1)"},{"line_number":91,"context_line":"                # Ensure the image id we got looks like an image id to filter"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_fb329e0e","line":88,"updated":"2015-03-03 10:53:02.000000000","message":"Add one space before \u0027if\u0027","commit_id":"565566f417876a84ae815a7381d93d62597a9196"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"9f52a1f7190dbf865a88c1376ef25a1ddbf2ec54","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            try:"},{"line_number":88,"context_line":"               if request.method !\u003d method:"},{"line_number":89,"context_line":"                   continue"},{"line_number":90,"context_line":"            image_id \u003d match.group(1)"},{"line_number":91,"context_line":"                # Ensure the image id we got looks like an image id to filter"},{"line_number":92,"context_line":"                # out a URI like /images/detail. See LP Bug #879136"},{"line_number":93,"context_line":"                if image_id \u003d\u003d \u0027detail\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_1606671d","line":90,"updated":"2015-03-03 10:53:02.000000000","message":"Shift this line for 4 symbols right, to make this on one layer with if statements.","commit_id":"565566f417876a84ae815a7381d93d62597a9196"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4bf59383e2b1579a0896b56d4baec16d0cba9d67","unresolved":false,"context_lines":[{"line_number":88,"context_line":"               if request.method !\u003d method:"},{"line_number":89,"context_line":"                   continue"},{"line_number":90,"context_line":"            image_id \u003d match.group(1)"},{"line_number":91,"context_line":"                # Ensure the image id we got looks like an image id to filter"},{"line_number":92,"context_line":"                # out a URI like /images/detail. See LP Bug #879136"},{"line_number":93,"context_line":"                if image_id \u003d\u003d \u0027detail\u0027:"},{"line_number":94,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_3607eb19","line":91,"updated":"2015-03-03 10:53:21.000000000","message":"The below lines of codes should match with line 91","commit_id":"565566f417876a84ae815a7381d93d62597a9196"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4bf59383e2b1579a0896b56d4baec16d0cba9d67","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            image_id \u003d match.group(1)"},{"line_number":91,"context_line":"                # Ensure the image id we got looks like an image id to filter"},{"line_number":92,"context_line":"                # out a URI like /images/detail. See LP Bug #879136"},{"line_number":93,"context_line":"                if image_id \u003d\u003d \u0027detail\u0027:"},{"line_number":94,"context_line":"                    continue"},{"line_number":95,"context_line":"           \t"},{"line_number":96,"context_line":"    def _enforce(self, req, action, target\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_db523a34","line":93,"updated":"2015-03-03 10:53:21.000000000","message":"Hi GB21,\n\nSorry for not being specific in the previous comment.\n\nYour code should be like,\n\nif image_id \u003d\u003d \u0027detail\u0027:\n    continue\nreturn (version, method, image_id)","commit_id":"565566f417876a84ae815a7381d93d62597a9196"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"9f52a1f7190dbf865a88c1376ef25a1ddbf2ec54","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                # out a URI like /images/detail. See LP Bug #879136"},{"line_number":93,"context_line":"                if image_id \u003d\u003d \u0027detail\u0027:"},{"line_number":94,"context_line":"                    continue"},{"line_number":95,"context_line":"           \t"},{"line_number":96,"context_line":"    def _enforce(self, req, action, target\u003dNone):"},{"line_number":97,"context_line":"        \"\"\"Authorize an action against our policies\"\"\""},{"line_number":98,"context_line":"        if target is None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_96117754","line":95,"updated":"2015-03-03 10:53:02.000000000","message":"Bring back the removed code.","commit_id":"565566f417876a84ae815a7381d93d62597a9196"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4bf59383e2b1579a0896b56d4baec16d0cba9d67","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                # out a URI like /images/detail. See LP Bug #879136"},{"line_number":93,"context_line":"                if image_id \u003d\u003d \u0027detail\u0027:"},{"line_number":94,"context_line":"                    continue"},{"line_number":95,"context_line":"           \t"},{"line_number":96,"context_line":"    def _enforce(self, req, action, target\u003dNone):"},{"line_number":97,"context_line":"        \"\"\"Authorize an action against our policies\"\"\""},{"line_number":98,"context_line":"        if target is None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_9bae022d","line":95,"updated":"2015-03-03 10:53:21.000000000","message":"Remove these blank spaces","commit_id":"565566f417876a84ae815a7381d93d62597a9196"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"275ca1cf4e944d09b9e00df0d0092692033b19f0","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                continue"},{"line_number":96,"context_line":"            # If the method matches and the image_id is different from detail"},{"line_number":97,"context_line":"            # we\u0027ve found a match."},{"line_number":98,"context_line":"            return (version, method, image_id)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _enforce(self, req, action, target\u003dNone):"},{"line_number":101,"context_line":"        \"\"\"Authorize an action against our policies\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_99b2cce3","line":98,"updated":"2015-03-18 09:46:13.000000000","message":"we can eliminate continue statement\n\nif image_id !\u003d \u0027detail\u0027:\n    # If the method matches and the image_id is different from detail\n    # we\u0027ve found a match.\n    return (version, method, image_id)","commit_id":"f075c4e10f303a2a3375f9d82ce52f991a173296"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"87d8926570340fcd641b9da4acc28becbf60988e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                continue"},{"line_number":96,"context_line":"            # If the method matches and the image_id is different from detail"},{"line_number":97,"context_line":"            # we\u0027ve found a match."},{"line_number":98,"context_line":"            return (version, method, image_id)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _enforce(self, req, action, target\u003dNone):"},{"line_number":101,"context_line":"        \"\"\"Authorize an action against our policies\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_2a0c163b","line":98,"in_reply_to":"9a80dd14_99b2cce3","updated":"2015-03-18 14:07:44.000000000","message":"Done","commit_id":"f075c4e10f303a2a3375f9d82ce52f991a173296"}],"glance/api/middleware/cache.py~":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d815498f81c70b02888367bce779dde8c51cdac5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2011 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"ba7be1f8_e0002d04","line":1,"updated":"2015-03-03 10:31:09.000000000","message":"Is this file added by mistake?","commit_id":"7f0b2c98a55dbac09b82a237f8670e8910e8b793"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"9f52a1f7190dbf865a88c1376ef25a1ddbf2ec54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ba7be1f8_dba4fa4c","updated":"2015-03-03 10:53:02.000000000","message":"Please, remove this garbage file from your commit!","commit_id":"565566f417876a84ae815a7381d93d62597a9196"}]}