)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"735d5d1fd8e4921c50d6c0322da13f8552489c86","unresolved":false,"context_lines":[{"line_number":9,"context_line":"We added the eventlet executor waiting for taskflow to land and be ready"},{"line_number":10,"context_line":"for us to consume it. Now that we have it, it\u0027s time to remove the"},{"line_number":11,"context_line":"eventlet executor in favor of taskflow\u0027s parallel executors."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-implements blueprint: new-upload-workflow"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I220a14b2a92949772d5322c9947c42e892cfdbfa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba7be1f8_d2203b4b","line":12,"updated":"2015-03-03 21:03:27.000000000","message":"Probably needs a DocImpact tag too since the default option is changing and there are newly deprecated options","commit_id":"2f27828747e75614e432edbf72d095e94e8c5197"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"ae331986329d5867a3575805a1474814826166d2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"We added the eventlet executor waiting for taskflow to land and be ready"},{"line_number":10,"context_line":"for us to consume it. Now that we have it, it\u0027s time to remove the"},{"line_number":11,"context_line":"eventlet executor in favor of taskflow\u0027s parallel executors."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-implements blueprint: new-upload-workflow"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I220a14b2a92949772d5322c9947c42e892cfdbfa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba7be1f8_72186fd3","line":12,"in_reply_to":"ba7be1f8_d2203b4b","updated":"2015-03-03 21:12:10.000000000","message":"I...","commit_id":"2f27828747e75614e432edbf72d095e94e8c5197"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"7e4ec024090f19a516d365997735ab5b6c38a007","unresolved":false,"context_lines":[{"line_number":10,"context_line":"for us to consume it. Now that we have it, it\u0027s time to remove the"},{"line_number":11,"context_line":"eventlet executor in favor of taskflow\u0027s parallel executors."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":"Partially-implements blueprint: new-upload-workflow"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I220a14b2a92949772d5322c9947c42e892cfdbfa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba7be1f8_35f25a06","line":13,"updated":"2015-03-04 00:16:17.000000000","message":"UpgradeImpact","commit_id":"960b0bc01b7dda578a247935914ce553d29d91dd"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"38c6cd5185697b098d7a1a8d2989b2ef3c0de403","unresolved":false,"context_lines":[{"line_number":10,"context_line":"for us to consume it. Now that we have it, it\u0027s time to remove the"},{"line_number":11,"context_line":"eventlet executor in favor of taskflow\u0027s parallel executors."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":"Partially-implements blueprint: new-upload-workflow"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I220a14b2a92949772d5322c9947c42e892cfdbfa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_e491b353","line":13,"in_reply_to":"ba7be1f8_35f25a06","updated":"2015-03-04 11:47:07.000000000","message":"Done\n\nP.S: I really hate this flags, there should be a better way to do this.","commit_id":"960b0bc01b7dda578a247935914ce553d29d91dd"}],"doc/source/configuring.rst":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fb6c73246894592a0725f4bca4e9b01f3a084f67","unresolved":false,"context_lines":[{"line_number":1375,"context_line":"instantiated per executor instance."},{"line_number":1376,"context_line":""},{"line_number":1377,"context_line":"The default value for the ``engine_mode`` is ``worker-based``, whereas"},{"line_number":1378,"context_line":"the default number of ``max_workers`` is ``2``."},{"line_number":1379,"context_line":""},{"line_number":1380,"context_line":"Configuring Glance performance profiling"},{"line_number":1381,"context_line":"----------------------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba7be1f8_fa4d119b","line":1378,"updated":"2015-02-25 17:18:02.000000000","message":"Defaults are parallel and max is 50","commit_id":"3c90e1841ef08e02ca0cd06eb598d651e8b2711a"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"8dfede1d57e45ec41721b66b6afc8857a3d2bf61","unresolved":false,"context_lines":[{"line_number":1375,"context_line":"instantiated per executor instance."},{"line_number":1376,"context_line":""},{"line_number":1377,"context_line":"The default value for the ``engine_mode`` is ``worker-based``, whereas"},{"line_number":1378,"context_line":"the default number of ``max_workers`` is ``2``."},{"line_number":1379,"context_line":""},{"line_number":1380,"context_line":"Configuring Glance performance profiling"},{"line_number":1381,"context_line":"----------------------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba7be1f8_df37434b","line":1378,"in_reply_to":"ba7be1f8_f5e0c2ce","updated":"2015-02-26 07:52:15.000000000","message":"erm, mind elaborating? :D\n\nI explained here where this number came from but I agree we should have a better discussion around it. Could you please raise your concerns here?\n\nhttps://review.openstack.org/#/c/156249/10/glance/async/taskflow_executor.py,cm","commit_id":"3c90e1841ef08e02ca0cd06eb598d651e8b2711a"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"b839c16c7f7cae5253c4dd10127a24c6c25064ad","unresolved":false,"context_lines":[{"line_number":1375,"context_line":"instantiated per executor instance."},{"line_number":1376,"context_line":""},{"line_number":1377,"context_line":"The default value for the ``engine_mode`` is ``worker-based``, whereas"},{"line_number":1378,"context_line":"the default number of ``max_workers`` is ``2``."},{"line_number":1379,"context_line":""},{"line_number":1380,"context_line":"Configuring Glance performance profiling"},{"line_number":1381,"context_line":"----------------------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba7be1f8_f5e0c2ce","line":1378,"in_reply_to":"ba7be1f8_fa4d119b","updated":"2015-02-25 17:32:35.000000000","message":"Good catch, \u0027though this might need some discussion.","commit_id":"3c90e1841ef08e02ca0cd06eb598d651e8b2711a"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"aaf1edd7649f38a7f2f5714405690f608b57075e","unresolved":false,"context_lines":[{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"The config value ``task_executor`` is used to determine which executor"},{"line_number":1361,"context_line":"should be used by the Glance service to process the task. Options include"},{"line_number":1362,"context_line":"``taskflow``."},{"line_number":1363,"context_line":""},{"line_number":1364,"context_line":"* ``task_executor\u003d\u003cexecutor_type\u003e``"},{"line_number":1365,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba7be1f8_4984a10a","line":1362,"updated":"2015-03-04 00:33:48.000000000","message":"Nit: Can we rephrase \u0027options include\u0027 since we just have taskflow now?","commit_id":"960b0bc01b7dda578a247935914ce553d29d91dd"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"38c6cd5185697b098d7a1a8d2989b2ef3c0de403","unresolved":false,"context_lines":[{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"The config value ``task_executor`` is used to determine which executor"},{"line_number":1361,"context_line":"should be used by the Glance service to process the task. Options include"},{"line_number":1362,"context_line":"``taskflow``."},{"line_number":1363,"context_line":""},{"line_number":1364,"context_line":"* ``task_executor\u003d\u003cexecutor_type\u003e``"},{"line_number":1365,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a80dd14_c494af46","line":1362,"in_reply_to":"ba7be1f8_4984a10a","updated":"2015-03-04 11:47:07.000000000","message":"I\u0027ll rephrase it, although I think it\u0027s fine as it is now too.","commit_id":"960b0bc01b7dda578a247935914ce553d29d91dd"}],"etc/glance-api.conf":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"cf2cc3a0209b51117b304c199901ca40740b7247","unresolved":false,"context_lines":[{"line_number":450,"context_line":"# task_time_to_live \u003d 48"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"# Specifies which task executor to be used to run the task scripts."},{"line_number":453,"context_line":"# The default value for task_executor is eventlet."},{"line_number":454,"context_line":"# task_executor \u003d taskflow"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"# Specifies the maximum number of eventlet threads which can be spun up by"}],"source_content_type":"text/plain","patch_set":4,"id":"ba7be1f8_fa6dc79a","line":453,"updated":"2015-02-27 02:43:55.000000000","message":"No it\u0027s not anymore ^^","commit_id":"7c753014571933fac968a733225315359ecb40a7"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"ea8ba7ee3658c4db4649a0a87b5ba9b4cb058204","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"# Specifies the maximum number of eventlet threads which can be spun up by"},{"line_number":457,"context_line":"# the eventlet based task executor to perform execution of Glance tasks."},{"line_number":458,"context_line":"# DEPRECATED: Use taskflow_executor::max_workers instead."},{"line_number":459,"context_line":"# eventlet_executor_pool_size \u003d 1000"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"[taskflow_executor]"}],"source_content_type":"text/plain","patch_set":5,"id":"ba7be1f8_923ec389","line":458,"updated":"2015-03-03 21:02:28.000000000","message":"Do you mean \n\n    [taskflow_executor]/max_workers\n\n(That\u0027s the common syntax I see)","commit_id":"2f27828747e75614e432edbf72d095e94e8c5197"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"ae331986329d5867a3575805a1474814826166d2","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"# Specifies the maximum number of eventlet threads which can be spun up by"},{"line_number":457,"context_line":"# the eventlet based task executor to perform execution of Glance tasks."},{"line_number":458,"context_line":"# DEPRECATED: Use taskflow_executor::max_workers instead."},{"line_number":459,"context_line":"# eventlet_executor_pool_size \u003d 1000"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"[taskflow_executor]"}],"source_content_type":"text/plain","patch_set":5,"id":"ba7be1f8_f23c5f31","line":458,"in_reply_to":"ba7be1f8_923ec389","updated":"2015-03-03 21:12:10.000000000","message":"... hate you \u003e.\u003e","commit_id":"2f27828747e75614e432edbf72d095e94e8c5197"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"72b198ffedd3cfcbb757ce145854b894e68eaf52","unresolved":false,"context_lines":[{"line_number":464,"context_line":""},{"line_number":465,"context_line":"# The number of parallel activities executed at the same time by"},{"line_number":466,"context_line":"# the engine. The value can be greater than one when the engine mode is"},{"line_number":467,"context_line":"# \u0027parallel\u0027."},{"line_number":468,"context_line":"#max_workers \u003d 50"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"[glance_store]"}],"source_content_type":"text/plain","patch_set":7,"id":"9a80dd14_7bee308d","line":467,"updated":"2015-03-04 17:17:07.000000000","message":"What about when the engine mode is \u0027serial\u0027? The existing comment doesn\u0027t make it clear if that\u0027s an error or just ignored.","commit_id":"44fddcfd8fdff611913bbe54458a8e0374fe13eb"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"0f5480a7ae24ccae52e6f80c34b14d4d705cecf8","unresolved":false,"context_lines":[{"line_number":465,"context_line":"# The number of parallel activities executed at the same time by"},{"line_number":466,"context_line":"# the engine. The value can be greater than one when the engine mode is"},{"line_number":467,"context_line":"# \u0027parallel\u0027, otherwise this value will be ignored."},{"line_number":468,"context_line":"#max_workers \u003d 10"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"[glance_store]"},{"line_number":471,"context_line":"# List of which store classes and store class locations are"}],"source_content_type":"text/plain","patch_set":9,"id":"9a80dd14_56329e5f","line":468,"updated":"2015-03-06 22:27:55.000000000","message":"Wasn\u0027t the agreed upon default 4?","commit_id":"ae3135e1d67df77697a24fddaee3efeadb34a0dd"}],"glance/async/taskflow_executor.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"b402128fd31461d6f6b10fadd6d41abf21d3d1b4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    @contextlib.contextmanager"},{"line_number":94,"context_line":"    def _executor(self):"},{"line_number":95,"context_line":"        if CONF.taskflow_executor.engine_mode !\u003d \u0027parallel\u0027:"},{"line_number":96,"context_line":"            yield None"},{"line_number":97,"context_line":"        else:"},{"line_number":98,"context_line":"            max_workers \u003d CONF.taskflow_executor.max_workers"},{"line_number":99,"context_line":"            if eventlet_utils.EVENTLET_AVAILABLE:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_5ec08ae0","line":96,"updated":"2015-02-27 01:12:35.000000000","message":"Is it worth logging once the fact that nothing was yielded because the engine_mode wasn\u0027t recognized?","commit_id":"7c753014571933fac968a733225315359ecb40a7"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"2007a99e21537f255658a6f0f37ed430e7639fa3","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    @contextlib.contextmanager"},{"line_number":94,"context_line":"    def _executor(self):"},{"line_number":95,"context_line":"        if CONF.taskflow_executor.engine_mode !\u003d \u0027parallel\u0027:"},{"line_number":96,"context_line":"            yield None"},{"line_number":97,"context_line":"        else:"},{"line_number":98,"context_line":"            max_workers \u003d CONF.taskflow_executor.max_workers"},{"line_number":99,"context_line":"            if eventlet_utils.EVENTLET_AVAILABLE:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_58d7a9bf","line":96,"in_reply_to":"ba7be1f8_5ec08ae0","updated":"2015-02-27 12:47:23.000000000","message":"I don\u0027t think so, this is just a way to tell taskflow \"do whatever you think is best\" :D","commit_id":"7c753014571933fac968a733225315359ecb40a7"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"b402128fd31461d6f6b10fadd6d41abf21d3d1b4","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                                      executor\u003dexecutor, **self.engine_kwargs)"},{"line_number":117,"context_line":"                with llistener.DynamicLoggingListener(engine, log\u003dLOG):"},{"line_number":118,"context_line":"                    engine.run()"},{"line_number":119,"context_line":"        except Exception as exc:"},{"line_number":120,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":121,"context_line":"                LOG.error(_LE(\u0027Failed to execute task %(task_id)s: %(exc)s\u0027) %"},{"line_number":122,"context_line":"                          {\u0027task_id\u0027: task_id, \u0027exc\u0027: exc.message})"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_1ea61254","line":119,"updated":"2015-02-27 01:12:35.000000000","message":"I just noticed this, and I know you didn\u0027t write it, but would it be plausible to narrow down what we expect to be raised here?","commit_id":"7c753014571933fac968a733225315359ecb40a7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0df9d15082b7b58de1efb4ce37b70016e6a75f40","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                                      executor\u003dexecutor, **self.engine_kwargs)"},{"line_number":117,"context_line":"                with llistener.DynamicLoggingListener(engine, log\u003dLOG):"},{"line_number":118,"context_line":"                    engine.run()"},{"line_number":119,"context_line":"        except Exception as exc:"},{"line_number":120,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":121,"context_line":"                LOG.error(_LE(\u0027Failed to execute task %(task_id)s: %(exc)s\u0027) %"},{"line_number":122,"context_line":"                          {\u0027task_id\u0027: task_id, \u0027exc\u0027: exc.message})"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_374a0d56","line":119,"updated":"2015-02-27 09:02:55.000000000","message":"I think that\u0027s out of the scope of this patch and that change should go on another one.","commit_id":"7c753014571933fac968a733225315359ecb40a7"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"aaf1edd7649f38a7f2f5714405690f608b57075e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"               help\u003d_(\"The mode in which the engine will run. \""},{"line_number":45,"context_line":"                      \"Can be \u0027serial\u0027 or \u0027parallel\u0027.\")),"},{"line_number":46,"context_line":"    cfg.IntOpt(\u0027max_workers\u0027,"},{"line_number":47,"context_line":"               default\u003d50,"},{"line_number":48,"context_line":"               help\u003d_(\"The number of parallel activities executed at the \""},{"line_number":49,"context_line":"                      \"same time by the engine. The value can be greater \""},{"line_number":50,"context_line":"                      \"than one when the engine mode is \u0027parallel\u0027.\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba7be1f8_142c7c98","line":47,"updated":"2015-03-04 00:33:48.000000000","message":"I\u0027m wondering whether 50 is too high in the parallel mode. The reason I say this is, import, export, conversion and cloning etc are operations that maybe fairly long running and disk i/o intensive (possibly CPU intensive too). So, I\u0027m thinking 50 such operations operations may make the API node slower for other operations maybe?","commit_id":"960b0bc01b7dda578a247935914ce553d29d91dd"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"38c6cd5185697b098d7a1a8d2989b2ef3c0de403","unresolved":false,"context_lines":[{"line_number":44,"context_line":"               help\u003d_(\"The mode in which the engine will run. \""},{"line_number":45,"context_line":"                      \"Can be \u0027serial\u0027 or \u0027parallel\u0027.\")),"},{"line_number":46,"context_line":"    cfg.IntOpt(\u0027max_workers\u0027,"},{"line_number":47,"context_line":"               default\u003d50,"},{"line_number":48,"context_line":"               help\u003d_(\"The number of parallel activities executed at the \""},{"line_number":49,"context_line":"                      \"same time by the engine. The value can be greater \""},{"line_number":50,"context_line":"                      \"than one when the engine mode is \u0027parallel\u0027.\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_e4e37303","line":47,"in_reply_to":"ba7be1f8_142c7c98","updated":"2015-03-04 11:47:07.000000000","message":"I don\u0027t think this is too high. FWIW, the default in taskflow is 1000.\n\nI don\u0027t think we\u0027ll get this number right from the beginning and 50 is a conservative enough number that will let us tune it based on the feedback we\u0027ll get and the things we\u0027ll see.","commit_id":"960b0bc01b7dda578a247935914ce553d29d91dd"}],"glance/domain/__init__.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1e6403dbc4c4cc03153e429b80bc5ba12b61069d","unresolved":false,"context_lines":[{"line_number":467,"context_line":"            # executor."},{"line_number":468,"context_line":"            task_executor \u003d CONF.task.task_executor"},{"line_number":469,"context_line":"            if task_executor \u003d\u003d \u0027eventlet\u0027:"},{"line_number":470,"context_line":"                task_executor \u003d \u0027taskflow\u0027"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"            executor_cls \u003d (\u0027glance.async.%s_executor.\u0027"},{"line_number":473,"context_line":"                            \u0027TaskExecutor\u0027 % task_executor)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_648151fa","line":470,"updated":"2015-02-26 18:00:57.000000000","message":"No deprecation message?","commit_id":"30d032001f5bf02f681b841cbae6577995cd20ef"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0df9d15082b7b58de1efb4ce37b70016e6a75f40","unresolved":false,"context_lines":[{"line_number":467,"context_line":"            # executor."},{"line_number":468,"context_line":"            task_executor \u003d CONF.task.task_executor"},{"line_number":469,"context_line":"            if task_executor \u003d\u003d \u0027eventlet\u0027:"},{"line_number":470,"context_line":"                task_executor \u003d \u0027taskflow\u0027"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"            executor_cls \u003d (\u0027glance.async.%s_executor.\u0027"},{"line_number":473,"context_line":"                            \u0027TaskExecutor\u0027 % task_executor)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_173d09bc","line":470,"updated":"2015-02-27 09:02:55.000000000","message":"I don\u0027t think it should be changed to 1000 since we are changing the executor here and forcing taskflow, and for taskflow we don\u0027t use the defalt 1000 value.\nBut it may be worth logging a deprecation warning regarding this, as user may believe he is using eventlets.","commit_id":"7c753014571933fac968a733225315359ecb40a7"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"cf2cc3a0209b51117b304c199901ca40740b7247","unresolved":false,"context_lines":[{"line_number":467,"context_line":"            # executor."},{"line_number":468,"context_line":"            task_executor \u003d CONF.task.task_executor"},{"line_number":469,"context_line":"            if task_executor \u003d\u003d \u0027eventlet\u0027:"},{"line_number":470,"context_line":"                task_executor \u003d \u0027taskflow\u0027"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"            executor_cls \u003d (\u0027glance.async.%s_executor.\u0027"},{"line_number":473,"context_line":"                            \u0027TaskExecutor\u0027 % task_executor)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_5ad25335","line":470,"updated":"2015-02-27 02:43:55.000000000","message":"Shouldn\u0027t we set the pool size to 1000 here then as well if the eventlet is used?","commit_id":"7c753014571933fac968a733225315359ecb40a7"}]}