)]}'
{"etc/glance-api.conf":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"91ddbf9e852281410544d87ab2b9acbeefc98bc8","unresolved":false,"context_lines":[{"line_number":113,"context_line":"# which will use the request\u0027s host_url attribute to populate the URL base."},{"line_number":114,"context_line":"# If Glance is operating behind a proxy, you will want to change this to"},{"line_number":115,"context_line":"# represent the proxy\u0027s URL."},{"line_number":116,"context_line":"#public_endpoint\u003d\u003cNone\u003e"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# http_keepalive option. If False, server will return the header"},{"line_number":119,"context_line":"# \"Connection: close\", If True, server will return \"Connection: Keep-Alive\""}],"source_content_type":"text/plain","patch_set":1,"id":"9a80dd14_db82aac7","line":116,"updated":"2015-03-11 10:36:07.000000000","message":"Did I miss something? Don\u0027t see this used anywhere in the change.","commit_id":"495fabf068e9ee95e4bee07215d41d730618a18c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4b37392a456e9ddb3e7f665303f397e4f11462f9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"# which will use the request\u0027s host_url attribute to populate the URL base."},{"line_number":114,"context_line":"# If Glance is operating behind a proxy, you will want to change this to"},{"line_number":115,"context_line":"# represent the proxy\u0027s URL."},{"line_number":116,"context_line":"#public_endpoint\u003d\u003cNone\u003e"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# http_keepalive option. If False, server will return the header"},{"line_number":119,"context_line":"# \"Connection: close\", If True, server will return \"Connection: Keep-Alive\""}],"source_content_type":"text/plain","patch_set":1,"id":"9a80dd14_76b55530","line":116,"in_reply_to":"9a80dd14_db82aac7","updated":"2015-03-11 10:42:10.000000000","message":"Hi Erno,\n\nIt\u0027s my bad, thank you for pointing it out","commit_id":"495fabf068e9ee95e4bee07215d41d730618a18c"}],"glance/common/wsgi.py":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"aaeef8085ca8f651732078b6b1629ee84d2b3750","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                      \u0027max_header_line may need to be increased when using \u0027"},{"line_number":90,"context_line":"                      \u0027large tokens (typically those generated by the \u0027"},{"line_number":91,"context_line":"                      \u0027Keystone v3 API with big service catalogs\u0027)),"},{"line_number":92,"context_line":"    cfg.BoolOpt(\u0027http_keepalive\u0027, default\u003dTrue,"},{"line_number":93,"context_line":"                help\u003d_(\u0027If False, closes the client socket connection \u0027"},{"line_number":94,"context_line":"                       \u0027explicitly.\u0027)),"},{"line_number":95,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_c4ae9880","line":92,"updated":"2015-03-16 06:38:28.000000000","message":"I saw master change has been merged which gone this way (Sorry I couldn\u0027t review it and comment my idea there on time). However, I\u0027m a little worries on this option, IMO it just like says \"Set it to False please to prevent bug #1361360 happens, otherwise set it to True to make glance goes wrong\", so IMO we shouldn\u0027t optional it here, we have to set keepalive\u003dFalse for eventlet wsgi server directly.\n\nFrom backward-compatibility perspective, it just like says keeping thing goes wrong as original logic (default value is True), imo, at least we can set it to False in master, and be True for port back.","commit_id":"d569ed9db9dc1941ef74d38f85f8f67a85ff10b0"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4af4a41ee02a0a18055fe45532d1332e9909fd02","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                      \u0027max_header_line may need to be increased when using \u0027"},{"line_number":90,"context_line":"                      \u0027large tokens (typically those generated by the \u0027"},{"line_number":91,"context_line":"                      \u0027Keystone v3 API with big service catalogs\u0027)),"},{"line_number":92,"context_line":"    cfg.BoolOpt(\u0027http_keepalive\u0027, default\u003dTrue,"},{"line_number":93,"context_line":"                help\u003d_(\u0027If False, closes the client socket connection \u0027"},{"line_number":94,"context_line":"                       \u0027explicitly.\u0027)),"},{"line_number":95,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_e4d2bccf","line":92,"in_reply_to":"9a80dd14_c4ae9880","updated":"2015-03-16 06:41:38.000000000","message":"Hi Zhi,\n\nI will add new bug to address this concern for master patch.","commit_id":"d569ed9db9dc1941ef74d38f85f8f67a85ff10b0"}],"glance/tests/unit/common/test_wsgi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b4340f0f9a4e4b579ba13e7e521190562ea6ac84","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    @mock.patch.object(wsgi, \u0027get_socket\u0027)"},{"line_number":470,"context_line":"    def test_http_keepalive(self, mock_get_socket):"},{"line_number":471,"context_line":"        fake_socket \u003d \u0027fake_socket\u0027"},{"line_number":472,"context_line":"        mock_get_socket.return_value \u003d \u0027fake_socket\u0027"},{"line_number":473,"context_line":"        self.config(http_keepalive\u003dFalse)"},{"line_number":474,"context_line":"        self.config(workers\u003d0)"},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_9a75399a","line":472,"updated":"2015-03-12 18:48:52.000000000","message":"I believe you meant to reference the fake_socket variable and not a string literal","commit_id":"d569ed9db9dc1941ef74d38f85f8f67a85ff10b0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b4340f0f9a4e4b579ba13e7e521190562ea6ac84","unresolved":false,"context_lines":[{"line_number":476,"context_line":"        server \u003d wsgi.Server(threads\u003d1)"},{"line_number":477,"context_line":"        # mocking eventlet.wsgi server method to check it is called with"},{"line_number":478,"context_line":"        # configured \u0027http_keepalive\u0027 value."},{"line_number":479,"context_line":"        with mock.patch.object(eventlet.wsgi,"},{"line_number":480,"context_line":"                               \u0027server\u0027) as mock_server:"},{"line_number":481,"context_line":"            fake_application \u003d \"fake-application\""},{"line_number":482,"context_line":"            server.start(fake_application, 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_ba7afd85","line":479,"updated":"2015-03-12 18:48:52.000000000","message":"Why aren\u0027t we doing the mock as a decorator for the test method?","commit_id":"d569ed9db9dc1941ef74d38f85f8f67a85ff10b0"}]}